| Message ID | 20220922204434.74764-2-mranostay@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: PCI: ti,j721e-pci-*: resolve unexpected property warnings | expand |
On Thu, 22 Sep 2022 13:44:33 -0700, Matt Ranostay wrote: > Add missing 'interrupt-controller' property and related subnodes to resolve > the following warning: You did not Cc respective maintainers on your patch. Use scripts/get_maintainers.pl. > > arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-conroller' was unexpected) > From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > > Signed-off-by: Matt Ranostay <mranostay@ti.com> > --- > .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/patch/1681334 pcie@2900000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-sk.dtb pcie@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-sk.dtb pcie@2920000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-sk.dtb pcie@2930000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb arch/arm64/boot/dts/ti/k3-j721e-sk.dtb pcie@f102000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) arch/arm64/boot/dts/ti/k3-am642-evm.dtb arch/arm64/boot/dts/ti/k3-am642-sk.dtb
On Fri, Sep 23, 2022 at 11:31:11AM +0200, Krzysztof Kozlowski wrote: > On Thu, 22 Sep 2022 13:44:33 -0700, Matt Ranostay wrote: > > Add missing 'interrupt-controller' property and related subnodes to resolve > > the following warning: > > You did not Cc respective maintainers on your patch. Use > scripts/get_maintainers.pl. > Yeah noticed I forgot to Cc Rob Herring :-/ > > > > > arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-conroller' was unexpected) > > From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml > > > > Signed-off-by: Matt Ranostay <mranostay@ti.com> > > --- > > .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > Running 'make dtbs_check' with the schema in this patch gives the > following warnings. Consider if they are expected or the schema is > incorrect. These may not be new warnings. > > Note that it is not yet a requirement to have 0 warnings for dtbs_check. > This will change in the future. > > Full log is available here: https://patchwork.ozlabs.org/patch/1681334 > > > pcie@2900000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb > arch/arm64/boot/dts/ti/k3-j721e-sk.dtb > > pcie@2910000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) > arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dtb > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb > arch/arm64/boot/dts/ti/k3-j721e-sk.dtb > > pcie@2920000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb > arch/arm64/boot/dts/ti/k3-j721e-sk.dtb > > pcie@2930000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) > arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dtb > arch/arm64/boot/dts/ti/k3-j721e-sk.dtb > > pcie@f102000: Unevaluated properties are not allowed ('interrupt-names', 'interrupts' were unexpected) > arch/arm64/boot/dts/ti/k3-am642-evm.dtb > arch/arm64/boot/dts/ti/k3-am642-sk.dtb This get resolved in the second patchset in this series. - Matt
On 24/09/2022 22:46, Matt Ranostay wrote: > On Fri, Sep 23, 2022 at 11:31:11AM +0200, Krzysztof Kozlowski wrote: >> On Thu, 22 Sep 2022 13:44:33 -0700, Matt Ranostay wrote: >>> Add missing 'interrupt-controller' property and related subnodes to resolve >>> the following warning: >> >> You did not Cc respective maintainers on your patch. Use >> scripts/get_maintainers.pl. >> > > Yeah noticed I forgot to Cc Rob Herring :-/ You did not Cc anyone... No one from PCI maintainers, no one from DT bindings. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml index 2115d5a3f0e1..0f5914a22c14 100644 --- a/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml +++ b/Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml @@ -76,6 +76,19 @@ properties: msi-map: true + interrupt-controller: + type: object + additionalProperties: false + + properties: + interrupt-controller: true + + '#interrupt-cells': + const: 1 + + interrupts: + maxItems: 1 + required: - compatible - reg
Add missing 'interrupt-controller' property and related subnodes to resolve the following warning: arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dtb: pcie@2910000: Unevaluated properties are not allowed ('interrupt-conroller' was unexpected) From schema: Documentation/devicetree/bindings/pci/ti,j721e-pci-host.yaml Signed-off-by: Matt Ranostay <mranostay@ti.com> --- .../devicetree/bindings/pci/ti,j721e-pci-host.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)