| Message ID | 20220921-mt8183-disables-thermal-zones-up-v2-1-4a31a0b19e1e@baylibre.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: mediatek: mt8183: disable thermal zones without trips. | expand |
Hi Amjad,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on 60891ec99e141b74544d11e897a245ef06263052]
url: https://github.com/intel-lab-lkp/linux/commits/Amjad-Ouled-Ameur/arm64-dts-mediatek-mt8183-disable-thermal-zones-without-trips/20220921-170816
base: 60891ec99e141b74544d11e897a245ef06263052
config: arm64-randconfig-r013-20220922
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project 791a7ae1ba3efd6bca96338e10ffde557ba83920)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/d76f5ce41f97b219a80f00ec441bb733d1b94766
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Amjad-Ouled-Ameur/arm64-dts-mediatek-mt8183-disable-thermal-zones-without-trips/20220921-170816
git checkout d76f5ce41f97b219a80f00ec441bb733d1b94766
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> Error: arch/arm64/boot/dts/mediatek/mt8183.dtsi:1196.5-25 Properties must precede subnodes
FATAL ERROR: Unable to parse input tree
On 21/09/2022 11:05, Amjad Ouled-Ameur wrote: > Thermal zones without trip point are not registered by thermal core. > > tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose > only. > > Disable the zones above and keep only cpu_thermal enabled. Please test your patches before sending upstream. :( Best regards, Krzysztof
Hi Krzysztof, On 9/25/22 09:57, Krzysztof Kozlowski wrote: > On 21/09/2022 11:05, Amjad Ouled-Ameur wrote: >> Thermal zones without trip point are not registered by thermal core. >> >> tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose >> only. >> >> Disable the zones above and keep only cpu_thermal enabled. > Please test your patches before sending upstream. :( My apologies for the inconvenience, I mistakenly missed the error, will send a proper V3. Regards, Amjad > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi index 9d32871973a2..44a197e92c99 100644 --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi @@ -1193,6 +1193,7 @@ tzts1: tzts1 { sustainable-power = <5000>; trips {}; cooling-maps {}; + status = "disabled"; }; tzts2: tzts2 { @@ -1202,6 +1203,7 @@ tzts2: tzts2 { sustainable-power = <5000>; trips {}; cooling-maps {}; + status = "disabled"; }; tzts3: tzts3 { @@ -1211,6 +1213,7 @@ tzts3: tzts3 { sustainable-power = <5000>; trips {}; cooling-maps {}; + status = "disabled"; }; tzts4: tzts4 { @@ -1220,6 +1223,7 @@ tzts4: tzts4 { sustainable-power = <5000>; trips {}; cooling-maps {}; + status = "disabled"; }; tzts5: tzts5 { @@ -1229,6 +1233,7 @@ tzts5: tzts5 { sustainable-power = <5000>; trips {}; cooling-maps {}; + status = "disabled"; }; tztsABB: tztsABB { @@ -1238,6 +1243,7 @@ tztsABB: tztsABB { sustainable-power = <5000>; trips {}; cooling-maps {}; + status = "disabled"; }; };
Thermal zones without trip point are not registered by thermal core. tzts1 ~ tzts6 zones of mt8183 were intially introduced for test-purpose only. Disable the zones above and keep only cpu_thermal enabled. Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com>