[v2] dt-bindings: phy: Add compatible for Mediatek MT8188

Commit Message

Xinlei Lee (李昕磊) Sept. 26, 2022, 9:11 a.m. UTC

From: xinlei lee <[e-mail]>

Add dt-binding documentation of dsi-phy for MediaTek MT8188 SoC.

Signed-off-by: xinlei lee <[e-mail]>
---
Change since v1:
Adjust mt8188 position.
---
---
 Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 26, 2022, 12:55 p.m. UTC | #1

On 26/09/2022 11:23, Krzysztof Kozlowski wrote:
> On 26/09/2022 11:11, [e-mail] wrote:
>> From: xinlei lee <[e-mail]>
>>
>> Add dt-binding documentation of dsi-phy for MediaTek MT8188 SoC.
>>
>> Signed-off-by: xinlei lee <[e-mail]>
> 
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
> 
> https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540
> 
> If a tag was not added on purpose, please state why and what changed.
> 
> 
> Acked-by: Krzysztof Kozlowski <[e-mail]>


As pointed out in other discussion - these bindings might not be
correct. Please post DTS, so we can validate them.

Best regards,
Krzysztof

Xinlei Lee (李昕磊) Sept. 27, 2022, 4:21 a.m. UTC | #2

On Mon, 2022-09-26 at 14:55 +0200, Krzysztof Kozlowski wrote:
> On 26/09/2022 11:23, Krzysztof Kozlowski wrote:
> > On 26/09/2022 11:11, [e-mail] wrote:
> > > From: xinlei lee <[e-mail]>
> > > 
> > > Add dt-binding documentation of dsi-phy for MediaTek MT8188 SoC.
> > > 
> > > Signed-off-by: xinlei lee <[e-mail]>
> > 
> > Please add Acked-by/Reviewed-by tags when posting new versions.
> > However,
> > there's no need to repost patches *only* to add the tags. The
> > upstream
> > maintainer will do that for acks received on the version they
> > apply.
> > 
> > 
https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst*L540__;Iw!!CTRNKA9wMg0ARbw!w9FOgUcssBRstcHm65UMMbvSlgAOjT8c0c_GP_CgTrR1-5iA7mcb64YFfdNkY227eQ$
> >  
> > 
> > If a tag was not added on purpose, please state why and what
> > changed.
> > 
> > 
> > Acked-by: Krzysztof Kozlowski <[e-mail]>
> 
> 
> As pointed out in other discussion - these bindings might not be
> correct. Please post DTS, so we can validate them.
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof:

Thanks for your review.

In the previous patch,I changed the addition position, so I re-send it.
I don't know if you have any suggestions,so I didn't add the acked tag.

I will wait until the mt8188.dts file exits before sending this patch.

Best Regards!
xinlei

Patch

diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
index 9c2a734..7ea29ad 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml
@@ -26,6 +26,7 @@  properties:
           - const: mediatek,mt2701-mipi-tx
       - items:
           - enum:
+              - mediatek,mt8188-mipi-tx
               - mediatek,mt8365-mipi-tx
           - const: mediatek,mt8183-mipi-tx
       - const: mediatek,mt2701-mipi-tx