| Message ID | 20220924095025.7778-1-akihiko.odaki@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ASoC: amd: acp3x-5682: Remove SND_JACK_LINEOUT | expand |
On Sat, Sep 24, 2022 at 06:50:24PM +0900, Akihiko Odaki wrote: > RT5682 only has a headset jack. > ret = snd_soc_card_jack_new(card, "Headset Jack", > - SND_JACK_HEADSET | SND_JACK_LINEOUT | > + SND_JACK_HEADSET | Will the device by any chance happily drive this as a line output (possibly even detect if it's a headphone or a line output device attached)? The CODEC hardware is often interchangable.
diff --git a/sound/soc/amd/acp3x-rt5682-max9836.c b/sound/soc/amd/acp3x-rt5682-max9836.c index 0543dda75b99..0bdd9c26dd22 100644 --- a/sound/soc/amd/acp3x-rt5682-max9836.c +++ b/sound/soc/amd/acp3x-rt5682-max9836.c @@ -87,7 +87,7 @@ static int acp3x_5682_init(struct snd_soc_pcm_runtime *rtd) rt5682_dai_bclk = clk_get(component->dev, "rt5682-dai-bclk"); ret = snd_soc_card_jack_new(card, "Headset Jack", - SND_JACK_HEADSET | SND_JACK_LINEOUT | + SND_JACK_HEADSET | SND_JACK_BTN_0 | SND_JACK_BTN_1 | SND_JACK_BTN_2 | SND_JACK_BTN_3, &pco_jack);
RT5682 only has a headset jack. Signed-off-by: Akihiko Odaki <akihiko.odaki@gmail.com> --- sound/soc/amd/acp3x-rt5682-max9836.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)