| Message ID | 20220809172017.215412-2-aouledameur@baylibre.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: amlogic: meson-spicc: Use pinctrl to drive CLK line when idle | expand |
Hi, On 09/08/2022 19:20, Amjad Ouled-Ameur wrote: > SPI pins of the SPICC Controller in Meson-GX needs to be controlled by > pin biais when idle. Therefore define three pinctrl names: > - default: SPI pins are controlled by spi function. > - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled > by spi function. > - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled > by spi function. > > Reported-by: Da Xue <da@libre.computer> > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com> Don't forget to CC devicetree@vger.kernel.org otherwise it won't be reviewed. > --- > .../bindings/spi/amlogic,meson-gx-spicc.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml > index 50de0da42c13..10707a8216f5 100644 > --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml > +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml > @@ -43,6 +43,14 @@ properties: > minItems: 1 > maxItems: 2 > > + pinctrl-0: > + minItems: 1 > + > + pinctrl-1: > + maxItems: 1 > + > + pinctrl-names: true > + > if: > properties: > compatible: > @@ -69,6 +77,13 @@ else: > items: > - const: core > > + pinctrl-names: > + minItems: 1 > + items: > + - const: default > + - const: idle-high > + - const: idle-low > + > required: > - compatible > - reg
Hi Neil On 9/27/22 10:29, Neil Armstrong wrote: > Hi, > > On 09/08/2022 19:20, Amjad Ouled-Ameur wrote: >> SPI pins of the SPICC Controller in Meson-GX needs to be controlled by >> pin biais when idle. Therefore define three pinctrl names: >> - default: SPI pins are controlled by spi function. >> - idle-high: SCLK pin is pulled-up, but MOSI/MISO are still controlled >> by spi function. >> - idle-low: SCLK pin is pulled-down, but MOSI/MISO are still controlled >> by spi function. >> >> Reported-by: Da Xue <da@libre.computer> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> Signed-off-by: Amjad Ouled-Ameur <aouledameur@baylibre.com> > > Don't forget to CC devicetree@vger.kernel.org otherwise it won't be > reviewed. Sure, will do in V2. Regards, Amjad > > >> --- >> .../bindings/spi/amlogic,meson-gx-spicc.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git >> a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >> b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >> index 50de0da42c13..10707a8216f5 100644 >> --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >> +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml >> @@ -43,6 +43,14 @@ properties: >> minItems: 1 >> maxItems: 2 >> + pinctrl-0: >> + minItems: 1 >> + >> + pinctrl-1: >> + maxItems: 1 >> + >> + pinctrl-names: true >> + >> if: >> properties: >> compatible: >> @@ -69,6 +77,13 @@ else: >> items: >> - const: core >> + pinctrl-names: >> + minItems: 1 >> + items: >> + - const: default >> + - const: idle-high >> + - const: idle-low >> + >> required: >> - compatible >> - reg
diff --git a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml index 50de0da42c13..10707a8216f5 100644 --- a/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml +++ b/Documentation/devicetree/bindings/spi/amlogic,meson-gx-spicc.yaml @@ -43,6 +43,14 @@ properties: minItems: 1 maxItems: 2 + pinctrl-0: + minItems: 1 + + pinctrl-1: + maxItems: 1 + + pinctrl-names: true + if: properties: compatible: @@ -69,6 +77,13 @@ else: items: - const: core + pinctrl-names: + minItems: 1 + items: + - const: default + - const: idle-high + - const: idle-low + required: - compatible - reg