mbox series

[v9,0/3] Add support for lan966x flexcom chip-select configuration

Message ID 20220916075744.1879428-1-kavyasree.kotagiri@microchip.com (mailing list archive)
Headers show
Series Add support for lan966x flexcom chip-select configuration | expand

Message

Kavyasree Kotagiri Sept. 16, 2022, 7:57 a.m. UTC
This patch series converts atmel-flexcom bindings into json-schema format.
Adds support for lan966x flexcom chip-select configurations and its
DT bindings.

v8 -> v9:
 - Use full schema path for i2c bindings.

v7 -> v8:
 - Added back patternProperties for child nodes.
 - Changed compatible string to microchip,lan9668-flexcom.

v6 -> v7:
 - Change filename to atmel,sama5d2-flexcom.yaml
 - Add #address-cells, #size-cells to flexcom node - Fixed warnings.

v5 -> v6:
 - Removed spi node from example as suggested by Rob and
   also pattern properties(spi dt-bindings conversion to yaml patch is under review).
   https://patchwork.kernel.org/project/linux-arm-kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
   Once this is accepted, I will add back spi example through new patch.

v4 -> v5:
 - Fix indentations of DT example.
 - Fix dt-schema errors - removed minItems, maxItems for allOf:if:then
   "reg" property as it is not required.

v3 -> v4:
 - Fix dtschema errors.
 - Add a condition to flexcom chip-selects configuration as chip-select
   lines are optional.

v2 -> v3:
 - changed IRQ flag in dt-bindings example.
 - added reg property specific to lan66x which is missed in v2.
 - used goto label for clk_disable in error cases.

v1 -> v2:
 - minor fix in title of dt-bindings.
 - Modified new dt properties usage in atmel,flexcom.yaml.
 - Used GENMASK and macros for maximum allowed values.
 - Use u32 values for flexcom chipselects instead of strings.
 - disable clock in case of errors.

Kavyasree Kotagiri (3):
  dt-bindings: mfd: Convert atmel-flexcom to json-schema
  dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for
    lan966x
  mfd: atmel-flexcom: Add support for lan966x flexcom chip-select
    configuration

 .../bindings/mfd/atmel,sama5d2-flexcom.yaml   | 155 ++++++++++++++++++
 .../devicetree/bindings/mfd/atmel-flexcom.txt |  63 -------
 drivers/mfd/atmel-flexcom.c                   |  94 ++++++++++-
 3 files changed, 248 insertions(+), 64 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
 delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-flexcom.txt

Comments

Kavyasree Kotagiri Sept. 27, 2022, 9:11 a.m. UTC | #1
> This patch series converts atmel-flexcom bindings into json-schema format.
> Adds support for lan966x flexcom chip-select configurations and its
> DT bindings.
> 
> v8 -> v9:
>  - Use full schema path for i2c bindings.
> 
Hi Rob & Krzysztof,

Please let me know your comments on v9 patch series.

Thanks,
Kavya

> v7 -> v8:
>  - Added back patternProperties for child nodes.
>  - Changed compatible string to microchip,lan9668-flexcom.
> 
> v6 -> v7:
>  - Change filename to atmel,sama5d2-flexcom.yaml
>  - Add #address-cells, #size-cells to flexcom node - Fixed warnings.
> 
> v5 -> v6:
>  - Removed spi node from example as suggested by Rob and
>    also pattern properties(spi dt-bindings conversion to yaml patch is under
> review).
>    https://patchwork.kernel.org/project/linux-arm-
> kernel/patch/20220629125804.137099-1-sergiu.moga@microchip.com/
>    Once this is accepted, I will add back spi example through new patch.
> 
> v4 -> v5:
>  - Fix indentations of DT example.
>  - Fix dt-schema errors - removed minItems, maxItems for allOf:if:then
>    "reg" property as it is not required.
> 
> v3 -> v4:
>  - Fix dtschema errors.
>  - Add a condition to flexcom chip-selects configuration as chip-select
>    lines are optional.
> 
> v2 -> v3:
>  - changed IRQ flag in dt-bindings example.
>  - added reg property specific to lan66x which is missed in v2.
>  - used goto label for clk_disable in error cases.
> 
> v1 -> v2:
>  - minor fix in title of dt-bindings.
>  - Modified new dt properties usage in atmel,flexcom.yaml.
>  - Used GENMASK and macros for maximum allowed values.
>  - Use u32 values for flexcom chipselects instead of strings.
>  - disable clock in case of errors.
> 
> Kavyasree Kotagiri (3):
>   dt-bindings: mfd: Convert atmel-flexcom to json-schema
>   dt-bindings: mfd: atmel,sama5d2-flexcom: Add new compatible string for
>     lan966x
>   mfd: atmel-flexcom: Add support for lan966x flexcom chip-select
>     configuration
> 
>  .../bindings/mfd/atmel,sama5d2-flexcom.yaml   | 155 ++++++++++++++++++
>  .../devicetree/bindings/mfd/atmel-flexcom.txt |  63 -------
>  drivers/mfd/atmel-flexcom.c                   |  94 ++++++++++-
>  3 files changed, 248 insertions(+), 64 deletions(-)
>  create mode 100644
> Documentation/devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml
>  delete mode 100644 Documentation/devicetree/bindings/mfd/atmel-
> flexcom.txt
> 
> --
> 2.25.1