| Message ID | 20220927013951.12833-2-zhuyinbo@loongson.cn (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | [v3,1/3] MAINTAINERS: add maintainer for thermal driver for loongson2 SoCs | expand |
On Tue, 27 Sep 2022 09:39:50 +0800, Yinbo Zhu wrote: > Add the loongson2 thermal binding with DT schema format using > json-schema. > > Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> > --- > Change in v3: > 1. Remove the sensor id. > 2. Remove the interrupt-parent in thermal required property. > 3. Update the thermal binding file name. > 4. Fixup the commit log information. > > .../thermal/loongson,loongson2-thermal.yaml | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/thermal/loongson,loongson2-thermal.yaml# Error: Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.example.dts:25.29-30 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:384: Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1420: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
在 2022/9/27 下午10:39, Rob Herring 写道:
> make DT_CHECKER_FLAGS=-m dt_binding_check
Hi Rob,
this issue had been fix in v4 version.
TKs,
Yinbo.
diff --git a/Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.yaml b/Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.yaml new file mode 100644 index 000000000000..65a10a7390a7 --- /dev/null +++ b/Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.yaml @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/thermal/loongson2-thermal.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Thermal sensors on loongson2 SoCs + +maintainers: + - zhanghongchen <zhanghongchen@loongson.cn> + - Yinbo Zhu <zhuyinbo@loongson.cn> + +properties: + compatible: + const: loongson,loongson2-thermal + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#thermal-sensor-cells": + const: 1 + +required: + - compatible + - reg + - interrupts + - '#thermal-sensor-cells' + +additionalProperties: false + +examples: + - | + thermal: thermal-sensor@1fe01500 { + compatible = "loongson,loongson2-thermal"; + reg = <0 0x1fe01500 0 0x30>; + interrupt-parent = <&liointc0>; + interrupts = <7 IRQ_TYPE_LEVEL_LOW>; + #thermal-sensor-cells = <1>; + };
Add the loongson2 thermal binding with DT schema format using json-schema. Signed-off-by: Yinbo Zhu <zhuyinbo@loongson.cn> --- Change in v3: 1. Remove the sensor id. 2. Remove the interrupt-parent in thermal required property. 3. Update the thermal binding file name. 4. Fixup the commit log information. .../thermal/loongson,loongson2-thermal.yaml | 42 +++++++++++++++++++ 1 file changed, 42 insertions(+) create mode 100644 Documentation/devicetree/bindings/thermal/loongson,loongson2-thermal.yaml