| Message ID | 20220927100347.176606-3-jean-philippe@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | hw/arm/virt: Fix dt-schema warnings | expand |
On Tue, 27 Sept 2022 at 11:12, Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > The GICv3 bindings requires a #msi-cells property for the ITS node. Fix > the corresponding dt-validate warning: > > interrupt-controller@8000000: msi-controller@8080000: '#msi-cells' is a required property > From schema: linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- Reviewed-by: Peter Maydell <peter.maydell@linaro.org> thanks -- PMM
Hi Jean, On 9/27/22 12:03, Jean-Philippe Brucker wrote: > The GICv3 bindings requires a #msi-cells property for the ITS node. Fix > the corresponding dt-validate warning: > > interrupt-controller@8000000: msi-controller@8080000: '#msi-cells' is a required property > From schema: linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml nit: you may add linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml says "#msi-cells": description: The single msi-cell is the DeviceID of the device which will generate the MSI. const: 1 > > Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> Besides, Reviewed-by: Eric Auger <eric.auger@redhat.com> Eric > --- > hw/arm/virt.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 83ab1a37fb..ed6f1ac41e 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -487,6 +487,7 @@ static void fdt_add_its_gic_node(VirtMachineState *vms) > qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", > "arm,gic-v3-its"); > qemu_fdt_setprop(ms->fdt, nodename, "msi-controller", NULL, 0); > + qemu_fdt_setprop_cell(ms->fdt, nodename, "#msi-cells", 1); > qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", > 2, vms->memmap[VIRT_GIC_ITS].base, > 2, vms->memmap[VIRT_GIC_ITS].size);
diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 83ab1a37fb..ed6f1ac41e 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -487,6 +487,7 @@ static void fdt_add_its_gic_node(VirtMachineState *vms) qemu_fdt_setprop_string(ms->fdt, nodename, "compatible", "arm,gic-v3-its"); qemu_fdt_setprop(ms->fdt, nodename, "msi-controller", NULL, 0); + qemu_fdt_setprop_cell(ms->fdt, nodename, "#msi-cells", 1); qemu_fdt_setprop_sized_cells(ms->fdt, nodename, "reg", 2, vms->memmap[VIRT_GIC_ITS].base, 2, vms->memmap[VIRT_GIC_ITS].size);
The GICv3 bindings requires a #msi-cells property for the ITS node. Fix the corresponding dt-validate warning: interrupt-controller@8000000: msi-controller@8080000: '#msi-cells' is a required property From schema: linux/Documentation/devicetree/bindings/interrupt-controller/arm,gic-v3.yaml Signed-off-by: Jean-Philippe Brucker <jean-philippe@linaro.org> --- hw/arm/virt.c | 1 + 1 file changed, 1 insertion(+)