mbox series

[0/8] ALSA: hda: Add model option to codec drivers, too

Message ID 20220929073545.1085-1-tiwai@suse.de (mailing list archive)
Headers show
Series ALSA: hda: Add model option to codec drivers, too | expand

Message

Takashi Iwai Sept. 29, 2022, 7:35 a.m. UTC 
Hi,

this is a trivial patch set to add the "model" option to each HD-audio
codec driver that works equivalently with snd-hda-intel or SOF
driver's model option.  It makes it easer for users to specify the
quirk to the right target.


Takashi

===

Takashi Iwai (8):
  ALSA: hda/realtek: Add model option to codec driver, too
  ALSA: hda/cirrus: Add model option to codec driver, too
  ALSA: hda/conexant: Add model option to codec driver, too
  ALSA: hda/cs8409: Add model option to codec driver, too
  ALSA: hda/analog: Add model option to codec driver, too
  ALSA: hda/sigmatel: Add model option to codec driver, too
  ALSA: hda/via: Add model option to codec driver, too
  ALSA: doc: Explain more about model option

 Documentation/sound/hd-audio/notes.rst | 16 ++++++++++++++++
 sound/pci/hda/patch_analog.c           | 10 ++++++++++
 sound/pci/hda/patch_cirrus.c           | 10 ++++++++++
 sound/pci/hda/patch_conexant.c         | 10 ++++++++++
 sound/pci/hda/patch_cs8409.c           | 10 ++++++++++
 sound/pci/hda/patch_realtek.c          | 11 +++++++++++
 sound/pci/hda/patch_sigmatel.c         | 11 +++++++++++
 sound/pci/hda/patch_via.c              | 11 +++++++++++
 8 files changed, 89 insertions(+)

Comments

Jaroslav Kysela Sept. 29, 2022, 7:46 a.m. UTC | #1 
On 29. 09. 22 9:35, Takashi Iwai wrote:
> Hi,
> 
> this is a trivial patch set to add the "model" option to each HD-audio
> codec driver that works equivalently with snd-hda-intel or SOF
> driver's model option.  It makes it easer for users to specify the
> quirk to the right target.

I am not convinced, if it's "easier" for users. Perhaps, it will make more 
sense to add this option to the snd_intel_dspcfg module (so the model can be 
controlled in the one place). I admit that users are a bit confused with the 
snd-hda-intel and SOF differences.

					Jaroslav
Takashi Iwai Sept. 29, 2022, 8:25 a.m. UTC | #2 
On Thu, 29 Sep 2022 09:46:47 +0200,
Jaroslav Kysela wrote:
> 
> On 29. 09. 22 9:35, Takashi Iwai wrote:
> > Hi,
> > 
> > this is a trivial patch set to add the "model" option to each HD-audio
> > codec driver that works equivalently with snd-hda-intel or SOF
> > driver's model option.  It makes it easer for users to specify the
> > quirk to the right target.
> 
> I am not convinced, if it's "easier" for users. Perhaps, it will make
> more sense to add this option to the snd_intel_dspcfg module (so the
> model can be controlled in the one place). I admit that users are a
> bit confused with the snd-hda-intel and SOF differences.

Yes, and that's another reason for moving this rather to codec.
By applying directly the option to the codec driver, it works no
matter which control driver is used.

And, snd_intel_dspcfg is no better choice, IMO.  If you have multiple
controllers, you'll hit the same problem as snd-hda-intel.
(And SOF ignores that use case completely, but it's fine, as SOF is
more or less bound only with the onboard controller.)


Takashi