[v2,00/11] phy: qcom-qmp: more fixes and cleanups

Message

Johan Hovold Sept. 29, 2022, 9:29 a.m. UTC

Here's the next batch of QMP driver fixes and cleanups.

Dmitry suggested that the register layout structs could all be using
per-IP version defines, which in principle sounds like a good idea. It
is a separate change though, and one which would require some more work
as it is not always clear which IP version a specific SoC uses (e.g.
some of the IPQ platforms appear to mix and match currently).

As such a change shouldn't block these clean ups, I've dropped the
merging of the IPQ SDM845 PCIe layout structs in v2.

I've also moved the bogus register update last in case it turns out that
that one needs more discussion.

Johan


Changes in v2
 - drop the two patches that dropped the IPC and SDM845 PCIe layout
   structs
 - move the bogus register fix last in case this one needs some more
   discussion


Johan Hovold (11):
  phy: qcom-qmp: fix obsolete lane comments
  phy: qcom-qmp-combo: drop unused UFS reset
  phy: qcom-qmp-pcie: drop unused common-block registers
  phy: qcom-qmp-pcie: clean up power-down handling
  phy: qcom-qmp-pcie: move power-down update
  phy: qcom-qmp-pcie-msm8996: clean up power-down handling
  phy: qcom-qmp-combo: clean up power-down handling
  phy: qcom-qmp-ufs: clean up power-down handling
  phy: qcom-qmp-usb: clean up power-down handling
  phy: qcom-qmp-pcie: clean up clock lists
  phy: qcom-qmp-pcie: drop bogus register update

 drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 30 +++---------
 .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c  | 12 ++---
 drivers/phy/qualcomm/phy-qcom-qmp-pcie.c      | 49 +++++--------------
 drivers/phy/qualcomm/phy-qcom-qmp-ufs.c       | 24 ++++-----
 drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 22 +++------
 5 files changed, 38 insertions(+), 99 deletions(-)

Comments

Johan Hovold Sept. 29, 2022, 9:47 a.m. UTC | #1

On Thu, Sep 29, 2022 at 11:29:05AM +0200, Johan Hovold wrote:
> Here's the next batch of QMP driver fixes and cleanups.

> Johan Hovold (11):
>   phy: qcom-qmp: fix obsolete lane comments
>   phy: qcom-qmp-combo: drop unused UFS reset
>   phy: qcom-qmp-pcie: drop unused common-block registers
>   phy: qcom-qmp-pcie: clean up power-down handling
>   phy: qcom-qmp-pcie: move power-down update

>   phy: qcom-qmp-pcie-msm8996: clean up power-down handling
>   phy: qcom-qmp-combo: clean up power-down handling
>   phy: qcom-qmp-ufs: clean up power-down handling
>   phy: qcom-qmp-usb: clean up power-down handling
>   phy: qcom-qmp-pcie: clean up clock lists

I forgot to add Dmitry's reviewed-by tag to patches 6 through 10 when
resending. Sorry about that.

>   phy: qcom-qmp-pcie: drop bogus register update
> 
>  drivers/phy/qualcomm/phy-qcom-qmp-combo.c     | 30 +++---------
>  .../phy/qualcomm/phy-qcom-qmp-pcie-msm8996.c  | 12 ++---
>  drivers/phy/qualcomm/phy-qcom-qmp-pcie.c      | 49 +++++--------------
>  drivers/phy/qualcomm/phy-qcom-qmp-ufs.c       | 24 ++++-----
>  drivers/phy/qualcomm/phy-qcom-qmp-usb.c       | 22 +++------
>  5 files changed, 38 insertions(+), 99 deletions(-)

Johan