| Message ID | 20220929220021.247097-5-bvanassche@acm.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix a deadlock in the UFS driver | expand |
On Thu, 2022-09-29 at 15:00 -0700, Bart Van Assche wrote: > Although the host lock had to be held by > ufshcd_clk_scaling_start_busy() > callers when that function was introduced, that is no longer the case > today. Hence remove the comment that claims that callers of this > function > must hold the host lock. > > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Bean Huo <beanhuo@micron.com>
On 30/09/22 01:00, Bart Van Assche wrote: > Although the host lock had to be held by ufshcd_clk_scaling_start_busy() > callers when that function was introduced, that is no longer the case > today. Hence remove the comment that claims that callers of this function > must hold the host lock. > > Signed-off-by: Bart Van Assche <bvanassche@acm.org> Reviewed-by: Adrian Hunter <adrian.hunter@intel.com> > --- > drivers/ufs/core/ufshcd.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c > index 7c15cbc737b4..78c980585dc3 100644 > --- a/drivers/ufs/core/ufshcd.c > +++ b/drivers/ufs/core/ufshcd.c > @@ -2013,7 +2013,6 @@ static void ufshcd_exit_clk_gating(struct ufs_hba *hba) > destroy_workqueue(hba->clk_gating.clk_gating_workq); > } > > -/* Must be called with host lock acquired */ > static void ufshcd_clk_scaling_start_busy(struct ufs_hba *hba) > { > bool queue_resume_work = false;
diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c index 7c15cbc737b4..78c980585dc3 100644 --- a/drivers/ufs/core/ufshcd.c +++ b/drivers/ufs/core/ufshcd.c @@ -2013,7 +2013,6 @@ static void ufshcd_exit_clk_gating(struct ufs_hba *hba) destroy_workqueue(hba->clk_gating.clk_gating_workq); } -/* Must be called with host lock acquired */ static void ufshcd_clk_scaling_start_busy(struct ufs_hba *hba) { bool queue_resume_work = false;
Although the host lock had to be held by ufshcd_clk_scaling_start_busy() callers when that function was introduced, that is no longer the case today. Hence remove the comment that claims that callers of this function must hold the host lock. Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/ufs/core/ufshcd.c | 1 - 1 file changed, 1 deletion(-)