mbox series

[v2,0/2] drm/i915/slpc: Update frequency debugfs for SLPC

Message ID 20221004222903.23898-1-vinay.belgaumkar@intel.com (mailing list archive)
Headers show
Series drm/i915/slpc: Update frequency debugfs for SLPC | expand

Message

Vinay Belgaumkar Oct. 4, 2022, 10:29 p.m. UTC
Remove the RPS related information that is not valid when
SLPC is enabled.

v2: Add version numbers and address other comments (Jani)

Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>

Vinay Belgaumkar (2):
  drm/i915: Add a wrapper for frequency debugfs
  drm/i915/slpc: Update the frequency debugfs

 drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 157 +------------
 drivers/gpu/drm/i915/gt/intel_rps.c           | 207 ++++++++++++++++++
 drivers/gpu/drm/i915/gt/intel_rps.h           |   3 +
 3 files changed, 211 insertions(+), 156 deletions(-)

Comments

Vinay Belgaumkar Oct. 4, 2022, 11:57 p.m. UTC | #1
On 10/4/2022 4:33 PM, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/slpc: Update frequency debugfs for SLPC (rev3)
> URL   : https://patchwork.freedesktop.org/series/109328/
> State : failure
>
> == Summary ==
>
> Error: make failed
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/atomic/check-atomics.sh
>    DESCEND objtool
>    CHK     include/generated/compile.h
>    CC [M]  drivers/gpu/drm/i915/gt/intel_rps.o
> drivers/gpu/drm/i915/gt/intel_rps.c:2222:6: error: no previous prototype for ‘rps_frequency_dump’ [-Werror=missing-prototypes]
>   void rps_frequency_dump(struct intel_rps *rps, struct drm_printer *p)

Forgot to use static for this function definition, will send out another 
version.

Thanks,

Vinay.

>        ^~~~~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> scripts/Makefile.build:249: recipe for target 'drivers/gpu/drm/i915/gt/intel_rps.o' failed
> make[4]: *** [drivers/gpu/drm/i915/gt/intel_rps.o] Error 1
> scripts/Makefile.build:465: recipe for target 'drivers/gpu/drm/i915' failed
> make[3]: *** [drivers/gpu/drm/i915] Error 2
> scripts/Makefile.build:465: recipe for target 'drivers/gpu/drm' failed
> make[2]: *** [drivers/gpu/drm] Error 2
> scripts/Makefile.build:465: recipe for target 'drivers/gpu' failed
> make[1]: *** [drivers/gpu] Error 2
> Makefile:1852: recipe for target 'drivers' failed
> make: *** [drivers] Error 2
>
>