diff mbox series

[v10,07/17] net: socket: Don't ignore EINVAL on netdev socket connection

Message ID 20221005162051.1120041-8-lvivier@redhat.com (mailing list archive)
State New, archived
Headers show
Series qapi: net: add unix socket type support to netdev backend | expand

Commit Message

Laurent Vivier Oct. 5, 2022, 4:20 p.m. UTC 
From: Stefano Brivio <sbrivio@redhat.com>

Other errors are treated as failure by net_socket_connect_init(),
but if connect() returns EINVAL, we'll fail silently. Remove the
related exception.

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 net/socket.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

David Gibson Oct. 6, 2022, 8:13 a.m. UTC | #1 
On Wed, Oct 05, 2022 at 06:20:41PM +0200, Laurent Vivier wrote:
> From: Stefano Brivio <sbrivio@redhat.com>
> 
> Other errors are treated as failure by net_socket_connect_init(),
> but if connect() returns EINVAL, we'll fail silently. Remove the
> related exception.
> 
> Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>

Reviewed-by: David Gibson <david@gibson.dropbear.id.au>

> ---
>  net/socket.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/net/socket.c b/net/socket.c
> index ade1ecf38b87..4944bb70d580 100644
> --- a/net/socket.c
> +++ b/net/socket.c
> @@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *peer,
>              if (errno == EINTR || errno == EWOULDBLOCK) {
>                  /* continue */
>              } else if (errno == EINPROGRESS ||
> -                       errno == EALREADY ||
> -                       errno == EINVAL) {
> +                       errno == EALREADY) {
>                  break;
>              } else {
>                  error_setg_errno(errp, errno, "can't connect socket");
diff mbox series

Patch

diff --git a/net/socket.c b/net/socket.c
index ade1ecf38b87..4944bb70d580 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -577,8 +577,7 @@  static int net_socket_connect_init(NetClientState *peer,
             if (errno == EINTR || errno == EWOULDBLOCK) {
                 /* continue */
             } else if (errno == EINPROGRESS ||
-                       errno == EALREADY ||
-                       errno == EINVAL) {
+                       errno == EALREADY) {
                 break;
             } else {
                 error_setg_errno(errp, errno, "can't connect socket");