| Message ID | 20221005152809.3785786-8-dave.stevenson@raspberrypi.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Updates to ov9282 sensor driver | expand |
Hi Dave, On Wed, Oct 05, 2022 at 04:28:00PM +0100, Dave Stevenson wrote: > The configured vblank_min setting of 250 (meaning VTS of Do you mean 151 ? > 720 + 250 = 970) is far higher than the setting that works on > the sensor, and there are no obvious restrictions stated in the > datasheet. > > Reduce the vblank_min to allow for faster frame rates. > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > --- > drivers/media/i2c/ov9282.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > index 1cd6cb4addfb..abb1223c0260 100644 > --- a/drivers/media/i2c/ov9282.c > +++ b/drivers/media/i2c/ov9282.c > @@ -268,7 +268,7 @@ static const struct ov9282_mode supported_modes[] = { > .height = 720, > .hblank = 250, > .vblank = 1022, > - .vblank_min = 151, > + .vblank_min = 41, > .vblank_max = 51540, > .link_freq_idx = 0, > .reg_list = { > -- > 2.34.1 >
Hi Jacopo On Thu, 6 Oct 2022 at 12:56, Jacopo Mondi <jacopo@jmondi.org> wrote: > > Hi Dave, > > On Wed, Oct 05, 2022 at 04:28:00PM +0100, Dave Stevenson wrote: > > The configured vblank_min setting of 250 (meaning VTS of > > Do you mean 151 ? I did. Misread hblank for vblank. Dave > > 720 + 250 = 970) is far higher than the setting that works on > > the sensor, and there are no obvious restrictions stated in the > > datasheet. > > > > Reduce the vblank_min to allow for faster frame rates. > > > > Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> > > --- > > drivers/media/i2c/ov9282.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c > > index 1cd6cb4addfb..abb1223c0260 100644 > > --- a/drivers/media/i2c/ov9282.c > > +++ b/drivers/media/i2c/ov9282.c > > @@ -268,7 +268,7 @@ static const struct ov9282_mode supported_modes[] = { > > .height = 720, > > .hblank = 250, > > .vblank = 1022, > > - .vblank_min = 151, > > + .vblank_min = 41, > > .vblank_max = 51540, > > .link_freq_idx = 0, > > .reg_list = { > > -- > > 2.34.1 > >
diff --git a/drivers/media/i2c/ov9282.c b/drivers/media/i2c/ov9282.c index 1cd6cb4addfb..abb1223c0260 100644 --- a/drivers/media/i2c/ov9282.c +++ b/drivers/media/i2c/ov9282.c @@ -268,7 +268,7 @@ static const struct ov9282_mode supported_modes[] = { .height = 720, .hblank = 250, .vblank = 1022, - .vblank_min = 151, + .vblank_min = 41, .vblank_max = 51540, .link_freq_idx = 0, .reg_list = {
The configured vblank_min setting of 250 (meaning VTS of 720 + 250 = 970) is far higher than the setting that works on the sensor, and there are no obvious restrictions stated in the datasheet. Reduce the vblank_min to allow for faster frame rates. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com> --- drivers/media/i2c/ov9282.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)