| Message ID | 20221006095257.6934-1-vadym.kochan@plvision.eu (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform | expand |
On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote: > From: Elad Nachman <enachman@marvell.com> > > Signed-off-by: Elad Nachman <enachman@marvell.com> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> > --- > drivers/usb/host/ehci-orion.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c > index a3454a3ea4e0..c6205abebbdf 100644 > --- a/drivers/usb/host/ehci-orion.c > +++ b/drivers/usb/host/ehci-orion.c > @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev) > * set. Since shared usb code relies on it, set it here for > * now. Once we have dma capability bindings this can go away. > */ > - err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); > + err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); > if (err) > goto err; Apart from the fact that you didn't include a patch description, how come the Subject: line says this applies to the AC5 platform when the actual code change applies to all platforms? Do you know that this change is safe for all those other platforms? Alan Stern
On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote: > From: Elad Nachman <enachman@marvell.com> > > Signed-off-by: Elad Nachman <enachman@marvell.com> > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> For obvious reasons, I can't take patches without any changelog text. Nor would you want me to do so. Please read the documentation for how to write a good changelog text. thanks, greg k-h
Hi Alan, Greg, On Thu, 6 Oct 2022 21:26:43 +0200, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote: > > From: Elad Nachman <enachman@marvell.com> > > > > Signed-off-by: Elad Nachman <enachman@marvell.com> > > Signed-off-by: Vadym Kochan <vadym.kochan@plvision.eu> > > For obvious reasons, I can't take patches without any changelog text. > Nor would you want me to do so. Please read the documentation for how > to write a good changelog text. Sorry for that. > > thanks, > > greg k-h The AC5 is a 64-bit SoC, from my understanding - for 32-bit system the 64-bit mask should be truncated to 32-bit. Regards, Vadym
diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c index a3454a3ea4e0..c6205abebbdf 100644 --- a/drivers/usb/host/ehci-orion.c +++ b/drivers/usb/host/ehci-orion.c @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev) * set. Since shared usb code relies on it, set it here for * now. Once we have dma capability bindings this can go away. */ - err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); + err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64)); if (err) goto err;