diff mbox series

[bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list

Message ID 20221006053429.3549165-1-yhs@fb.com (mailing list archive)
State Accepted
Commit 8206e4e95230daeeba43c59fc7c39656883ecd62
Delegated to: BPF
Headers show
Series [bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for bpf-next
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers warning 10 maintainers not CCed: sdf@google.com john.fastabend@gmail.com haoluo@google.com linux-kselftest@vger.kernel.org jolsa@kernel.org kpsingh@kernel.org song@kernel.org shuah@kernel.org mykolal@fb.com martin.lau@linux.dev
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 4 lines checked
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
bpf/vmtest-bpf-next-VM_Test-2 success Logs for build for x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-3 success Logs for build for x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-4 success Logs for llvm-toolchain
bpf/vmtest-bpf-next-VM_Test-5 success Logs for set-matrix
bpf/vmtest-bpf-next-VM_Test-1 success Logs for build for s390x with gcc
bpf/vmtest-bpf-next-VM_Test-17 success Logs for test_verifier on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-16 success Logs for test_verifier on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-7 success Logs for test_maps on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-8 success Logs for test_maps on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-9 success Logs for test_progs on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-10 success Logs for test_progs on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-13 success Logs for test_progs_no_alu32 on x86_64 with gcc
bpf/vmtest-bpf-next-VM_Test-14 success Logs for test_progs_no_alu32 on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-15 success Logs for test_verifier on s390x with gcc
bpf/vmtest-bpf-next-PR fail PR summary
bpf/vmtest-bpf-next-VM_Test-6 success Logs for test_maps on s390x with gcc
bpf/vmtest-bpf-next-VM_Test-11 success Logs for test_progs on x86_64 with llvm-16
bpf/vmtest-bpf-next-VM_Test-12 fail Logs for test_progs_no_alu32 on s390x with gcc

Commit Message

Yonghong Song Oct. 6, 2022, 5:34 a.m. UTC
BPF CI reported that selftest deny_namespace failed with s390x.

  test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
  test_deny_namespace:PASS:skel load 0 nsec
  libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
  libbpf: prog 'test_userns_create': failed to auto-attach: -524
  test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
  #57/1    deny_namespace/unpriv_userns_create_no_bpf:FAIL
  #57      deny_namespace:FAIL

BPF program test_userns_create is a BPF LSM type program which is
based on trampoline and s390x does not support s390x. Let add the
test to x390x deny list to avoid this failure in BPF CI.

Signed-off-by: Yonghong Song <yhs@fb.com>
---
 tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
 1 file changed, 1 insertion(+)

Comments

Jiri Olsa Oct. 6, 2022, 7:27 a.m. UTC | #1
On Wed, Oct 05, 2022 at 10:34:29PM -0700, Yonghong Song wrote:
> BPF CI reported that selftest deny_namespace failed with s390x.
> 
>   test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
>   test_deny_namespace:PASS:skel load 0 nsec
>   libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
>   libbpf: prog 'test_userns_create': failed to auto-attach: -524
>   test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
>   #57/1    deny_namespace/unpriv_userns_create_no_bpf:FAIL
>   #57      deny_namespace:FAIL
> 
> BPF program test_userns_create is a BPF LSM type program which is
> based on trampoline and s390x does not support s390x. Let add the
> test to x390x deny list to avoid this failure in BPF CI.
> 
> Signed-off-by: Yonghong Song <yhs@fb.com>

lgtm

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
>  tools/testing/selftests/bpf/DENYLIST.s390x | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
> index 17e074eb42b8..0fb03b8047d5 100644
> --- a/tools/testing/selftests/bpf/DENYLIST.s390x
> +++ b/tools/testing/selftests/bpf/DENYLIST.s390x
> @@ -75,3 +75,4 @@ user_ringbuf                             # failed to find kernel BTF type ID of
>  lookup_key                               # JIT does not support calling kernel function                                (kfunc)
>  verify_pkcs7_sig                         # JIT does not support calling kernel function                                (kfunc)
>  kfunc_dynptr_param                       # JIT does not support calling kernel function                                (kfunc)
> +deny_namespace                           # failed to attach: ERROR: strerror_r(-524)=22                                (trampoline)
> -- 
> 2.30.2
>
patchwork-bot+netdevbpf@kernel.org Oct. 6, 2022, 3:30 p.m. UTC | #2
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Alexei Starovoitov <ast@kernel.org>:

On Wed, 5 Oct 2022 22:34:29 -0700 you wrote:
> BPF CI reported that selftest deny_namespace failed with s390x.
> 
>   test_unpriv_userns_create_no_bpf:PASS:no-bpf unpriv new user ns 0 nsec
>   test_deny_namespace:PASS:skel load 0 nsec
>   libbpf: prog 'test_userns_create': failed to attach: ERROR: strerror_r(-524)=22
>   libbpf: prog 'test_userns_create': failed to auto-attach: -524
>   test_deny_namespace:FAIL:attach unexpected error: -524 (errno 524)
>   #57/1    deny_namespace/unpriv_userns_create_no_bpf:FAIL
>   #57      deny_namespace:FAIL
> 
> [...]

Here is the summary with links:
  - [bpf-next] selftests/bpf: Add selftest deny_namespace to s390x deny list
    https://git.kernel.org/bpf/bpf-next/c/8206e4e95230

You are awesome, thank you!
diff mbox series

Patch

diff --git a/tools/testing/selftests/bpf/DENYLIST.s390x b/tools/testing/selftests/bpf/DENYLIST.s390x
index 17e074eb42b8..0fb03b8047d5 100644
--- a/tools/testing/selftests/bpf/DENYLIST.s390x
+++ b/tools/testing/selftests/bpf/DENYLIST.s390x
@@ -75,3 +75,4 @@  user_ringbuf                             # failed to find kernel BTF type ID of
 lookup_key                               # JIT does not support calling kernel function                                (kfunc)
 verify_pkcs7_sig                         # JIT does not support calling kernel function                                (kfunc)
 kfunc_dynptr_param                       # JIT does not support calling kernel function                                (kfunc)
+deny_namespace                           # failed to attach: ERROR: strerror_r(-524)=22                                (trampoline)