diff mbox series

[[PATCH,net] ] ptp: ocp: remove symlink for second GNSS

Message ID 20221010012934.25639-1-vfedorenko@novek.ru (mailing list archive)
State Accepted
Commit 84cdf5bcbdce1622eeb6c857f8a7e383de1074a9
Delegated to: Netdev Maintainers
Headers show
Series [[PATCH,net] ] ptp: ocp: remove symlink for second GNSS | expand

Checks

Context Check Description
netdev/tree_selection success Clearly marked for net
netdev/fixes_present success Fixes tag present in non-next series
netdev/subject_prefix success Link
netdev/cover_letter success Single patches do not need cover letters
netdev/patch_count success Link
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/cc_maintainers fail 1 blamed authors not CCed: davem@davemloft.net; 2 maintainers not CCed: richardcochran@gmail.com davem@davemloft.net
netdev/build_clang success Errors and warnings before: 0 this patch: 0
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success Fixes tag looks correct
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch warning WARNING: From:/Signed-off-by: email address mismatch: 'From: Vadim Fedorenko <vfedorenko@novek.ru>' != 'Signed-off-by: Vadim Fedorenko <vadfed@fb.com>'
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Vadim Fedorenko Oct. 10, 2022, 1:29 a.m. UTC 
Destroy code doesn't remove symlink for ttyGNSS2 device introduced
earlier. Add cleanup code.

Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
---
 drivers/ptp/ptp_ocp.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Jonathan Lemon Oct. 10, 2022, 3:45 a.m. UTC | #1 
On 10/9/22 6:29 PM, Vadim Fedorenko wrote:
> Destroy code doesn't remove symlink for ttyGNSS2 device introduced
> earlier. Add cleanup code.
> 
> Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
> Signed-off-by: Vadim Fedorenko <vadfed@fb.com>

Thanks, Vadim!

Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>

> ---
>   drivers/ptp/ptp_ocp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index d36c3f597f77..a48d9b7d2921 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3657,6 +3657,7 @@ ptp_ocp_detach_sysfs(struct ptp_ocp *bp)
>   	struct device *dev = &bp->dev;
>   
>   	sysfs_remove_link(&dev->kobj, "ttyGNSS");
> +	sysfs_remove_link(&dev->kobj, "ttyGNSS2");
>   	sysfs_remove_link(&dev->kobj, "ttyMAC");
>   	sysfs_remove_link(&dev->kobj, "ptp");
>   	sysfs_remove_link(&dev->kobj, "pps");
patchwork-bot+netdevbpf@kernel.org Oct. 10, 2022, 7:40 a.m. UTC | #2 
Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon, 10 Oct 2022 04:29:34 +0300 you wrote:
> Destroy code doesn't remove symlink for ttyGNSS2 device introduced
> earlier. Add cleanup code.
> 
> Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
> Signed-off-by: Vadim Fedorenko <vadfed@fb.com>
> ---
>  drivers/ptp/ptp_ocp.c | 1 +
>  1 file changed, 1 insertion(+)

Here is the summary with links:
  - [[PATCH,net] ] ptp: ocp: remove symlink for second GNSS
    https://git.kernel.org/netdev/net/c/84cdf5bcbdce

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
index d36c3f597f77..a48d9b7d2921 100644
--- a/drivers/ptp/ptp_ocp.c
+++ b/drivers/ptp/ptp_ocp.c
@@ -3657,6 +3657,7 @@  ptp_ocp_detach_sysfs(struct ptp_ocp *bp)
 	struct device *dev = &bp->dev;
 
 	sysfs_remove_link(&dev->kobj, "ttyGNSS");
+	sysfs_remove_link(&dev->kobj, "ttyGNSS2");
 	sysfs_remove_link(&dev->kobj, "ttyMAC");
 	sysfs_remove_link(&dev->kobj, "ptp");
 	sysfs_remove_link(&dev->kobj, "pps");