diff mbox series

[2/2] ci(main): linux32 uses actions/checkout@v2

Message ID 4ee163b9a2c4c657e649159ae6c83b13613028f3.1665388136.git.gitgitgadget@gmail.com (mailing list archive)
State New, archived
Headers show
Series ci(main): upgrade actions/checkout to v3 | expand

Commit Message

Óscar Domínguez Celada Oct. 10, 2022, 7:48 a.m. UTC 
From: Oscar Dominguez <dominguez.celada@gmail.com>

to prevent issue tracked in https://github.com/actions/checkout/issues/560

Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
---
 .github/workflows/main.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Comments

Junio C Hamano Oct. 10, 2022, 9 p.m. UTC | #1 
"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to prevent issue tracked in https://github.com/actions/checkout/issues/560
>
> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
> ---
>  .github/workflows/main.yml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)

So, this is "[Patch 1/2] broke the musl job by blindly updating them
to v3 and here is a fix-up" patch?  Can we rearrange so that we have
no such "oops here is a fix" that breaks bisection easily?

> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 8dc9d938159..4eb5042f0d6 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -281,17 +281,20 @@ jobs:
>          vector:
>          - jobname: linux-musl
>            image: alpine
> +          checkout_version: 3
>          - jobname: linux32
>            os: ubuntu32
>            image: daald/ubuntu32:xenial
> +          checkout_version: 2
>          - jobname: pedantic
>            image: fedora
> +          checkout_version: 3
>      env:
>        jobname: ${{matrix.vector.jobname}}
>      runs-on: ubuntu-latest
>      container: ${{matrix.vector.image}}
>      steps:
> -    - uses: actions/checkout@v3
> +    - uses: actions/checkout@${{matrix.vector.checkout_version}}
>      - run: ci/install-docker-dependencies.sh
>      - run: ci/run-build-and-tests.sh
>      - name: print test failures
Junio C Hamano Oct. 10, 2022, 9:43 p.m. UTC | #2 
"Oscar Dominguez via GitGitGadget" <gitgitgadget@gmail.com> writes:

> From: Oscar Dominguez <dominguez.celada@gmail.com>
>
> to prevent issue tracked in https://github.com/actions/checkout/issues/560
>
> Signed-off-by: Oscar Dominguez <dominguez.celada@gmail.com>
> ---
>  .github/workflows/main.yml | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
> index 8dc9d938159..4eb5042f0d6 100644
> --- a/.github/workflows/main.yml
> +++ b/.github/workflows/main.yml
> @@ -281,17 +281,20 @@ jobs:
> ...
>      steps:
> -    - uses: actions/checkout@v3
> +    - uses: actions/checkout@${{matrix.vector.checkout_version}}
>      - run: ci/install-docker-dependencies.sh
>      - run: ci/run-build-and-tests.sh
>      - name: print test failures

I think the breakage we see in

    https://github.com/git/git/actions/runs/3222517697

is due to this change.
diff mbox series

Patch

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 8dc9d938159..4eb5042f0d6 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -281,17 +281,20 @@  jobs:
         vector:
         - jobname: linux-musl
           image: alpine
+          checkout_version: 3
         - jobname: linux32
           os: ubuntu32
           image: daald/ubuntu32:xenial
+          checkout_version: 2
         - jobname: pedantic
           image: fedora
+          checkout_version: 3
     env:
       jobname: ${{matrix.vector.jobname}}
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@${{matrix.vector.checkout_version}}
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures