| Message ID | 20221009230044.10961-2-prabhakar.mahadev-lad.rj@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | arm64: dts: renesas: rzg2l/rzg2lc/rzg2ul/rzv2l: Drop WDT2 | expand |
On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote: > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if > used from CA55 CPU would result in an unexpected behaviour. Hence drop > enabling WDT2. > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> I'd squash patches 1+2, but that's minor.
Hi Wolfram, Thank you for the review. On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote: > > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote: > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if > > used from CA55 CPU would result in an unexpected behaviour. Hence drop > > enabling WDT2. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > I'd squash patches 1+2, but that's minor. > OK, I'll wait for Geert before sending a v2. Cheers, Prabhakar
Hi Prabhakar, On Mon, Oct 10, 2022 at 10:01 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote: > > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote: > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if > > > used from CA55 CPU would result in an unexpected behaviour. Hence drop > > > enabling WDT2. > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > > > I'd squash patches 1+2, but that's minor. > > > OK, I'll wait for Geert before sending a v2. I'd even squash the whole series into a single patch "arm64: dts: renesas: rzg2l: Drop WDT2 node". If that would be the only change for v2, I can take care of that while applying. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Tue, Oct 11, 2022 at 8:39 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Mon, Oct 10, 2022 at 10:01 PM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote: > > > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote: > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if > > > > used from CA55 CPU would result in an unexpected behaviour. Hence drop > > > > enabling WDT2. > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > > > > > I'd squash patches 1+2, but that's minor. > > > > > OK, I'll wait for Geert before sending a v2. > > I'd even squash the whole series into a single patch > "arm64: dts: renesas: rzg2l: Drop WDT2 node". > OK. > If that would be the only change for v2, I can take care of that while > applying. > Thanks for taking care of it. Cheers, Prabhakar
On Tue, Oct 11, 2022 at 9:51 AM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > On Tue, Oct 11, 2022 at 8:39 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > On Mon, Oct 10, 2022 at 10:01 PM Lad, Prabhakar > > <prabhakar.csengg@gmail.com> wrote: > > > On Mon, Oct 10, 2022 at 7:53 AM Wolfram Sang <wsa@kernel.org> wrote: > > > > On Mon, Oct 10, 2022 at 12:00:40AM +0100, Prabhakar wrote: > > > > > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > > > > > WDT CH2 is specifically to check the operation of Cortex-M33 CPU and if > > > > > used from CA55 CPU would result in an unexpected behaviour. Hence drop > > > > > enabling WDT2. > > > > > > > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> > > > > > > > > Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > > > > > > > > I'd squash patches 1+2, but that's minor. > > > > > > > OK, I'll wait for Geert before sending a v2. > > > > I'd even squash the whole series into a single patch > > "arm64: dts: renesas: rzg2l: Drop WDT2 node". > > > OK. > > > If that would be the only change for v2, I can take care of that while > > applying. > > > Thanks for taking care of it. OK. Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> i.e. will queue in renesas-devel for v6.2. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi index c4faff092380..fbbb4f03440b 100644 --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi @@ -351,8 +351,3 @@ &wdt1 { status = "okay"; timeout-sec = <60>; }; - -&wdt2 { - status = "okay"; - timeout-sec = <60>; -};