mbox series

[bpf-next,v8,0/3] bpftool: Add autoattach for bpf prog load|loadall

Message ID 1665399601-29668-1-git-send-email-wangyufen@huawei.com (mailing list archive)
Headers show
Series bpftool: Add autoattach for bpf prog load|loadall | expand

Message

wangyufen Oct. 10, 2022, 10:59 a.m. UTC 
This patchset add "autoattach" optional for "bpftool prog load(_all)" to support
one-step load-attach-pin_link.

v7 -> v8: for the programs not supporting autoattach, fall back to reguler pinning
	  instead of skipping
v6 -> v7: add info msg print and update doc for the skip program
v5 -> v6: skip the programs not supporting auto-attach,
	  and change optional name from "auto_attach" to "autoattach"
v4 -> v5: some formatting nits of doc
v3 -> v4: rename functions, update doc, bash and do_help()
v2 -> v3: switch to extend prog load command instead of extend perf
v2: https://patchwork.kernel.org/project/netdevbpf/patch/20220824033837.458197-1-weiyongjun1@huawei.com/
v1: https://patchwork.kernel.org/project/netdevbpf/patch/20220816151725.153343-1-weiyongjun1@huawei.com/

Wang Yufen (3):
  bpftool: Add autoattach for bpf prog load|loadall
  bpftool: Update doc (add autoattach to prog load)
  bpftool: Update the bash completion(add autoattach to prog load)

 tools/bpf/bpftool/Documentation/bpftool-prog.rst | 15 ++++-
 tools/bpf/bpftool/bash-completion/bpftool        |  1 +
 tools/bpf/bpftool/prog.c                         | 78 +++++++++++++++++++++++-
 3 files changed, 90 insertions(+), 4 deletions(-)

Comments

Quentin Monnet Oct. 11, 2022, 4:17 p.m. UTC | #1 
2022-10-10 18:59 UTC+0800 ~ Wang Yufen <wangyufen@huawei.com>
> This patchset add "autoattach" optional for "bpftool prog load(_all)" to support
> one-step load-attach-pin_link.
> 
> v7 -> v8: for the programs not supporting autoattach, fall back to reguler pinning
> 	  instead of skipping
> v6 -> v7: add info msg print and update doc for the skip program
> v5 -> v6: skip the programs not supporting auto-attach,
> 	  and change optional name from "auto_attach" to "autoattach"
> v4 -> v5: some formatting nits of doc
> v3 -> v4: rename functions, update doc, bash and do_help()
> v2 -> v3: switch to extend prog load command instead of extend perf
> v2: https://patchwork.kernel.org/project/netdevbpf/patch/20220824033837.458197-1-weiyongjun1@huawei.com/
> v1: https://patchwork.kernel.org/project/netdevbpf/patch/20220816151725.153343-1-weiyongjun1@huawei.com/
> 
> Wang Yufen (3):
>   bpftool: Add autoattach for bpf prog load|loadall
>   bpftool: Update doc (add autoattach to prog load)
>   bpftool: Update the bash completion(add autoattach to prog load)
> 
>  tools/bpf/bpftool/Documentation/bpftool-prog.rst | 15 ++++-
>  tools/bpf/bpftool/bash-completion/bpftool        |  1 +
>  tools/bpf/bpftool/prog.c                         | 78 +++++++++++++++++++++++-
>  3 files changed, 90 insertions(+), 4 deletions(-)
> 

The series looks good to me, thank you!

Reviewed-by: Quentin Monnet <quentin@isovalent.com>