mbox series

[v9,0/2] add device Xiaomi Mi 6 (codename sagit) and board binding

Message ID 20221012185245.1282599-1-dsankouski@gmail.com (mailing list archive)
Headers show
Series add device Xiaomi Mi 6 (codename sagit) and board binding | expand

Message

Dzmitry Sankouski Oct. 12, 2022, 6:52 p.m. UTC
Add initial support for Xiaomi Mi 6 phone (codename sagit)

Dzmitry Sankouski (2):
  dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
  arm64: dts: qcom: sagit: add initial device tree for sagit

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../boot/dts/qcom/msm8998-xiaomi-sagit.dts    | 681 ++++++++++++++++++
 arch/arm64/boot/dts/qcom/pm8998.dtsi          |   8 +
 4 files changed, 691 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts

Comments

Konrad Dybcio Oct. 12, 2022, 7:25 p.m. UTC | #1
On 2022-10-12 20:52, Dzmitry Sankouski wrote:
> Add initial support for Xiaomi Mi 6 phone (codename sagit)
> 
> Dzmitry Sankouski (2):
>   dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
>   arm64: dts: qcom: sagit: add initial device tree for sagit
> 
Looks like you resent this series just to add the A-b on the dt-bindings 
patch?
If that's the case, you don't have to do it, the maintainer will pick up 
the tags
when applying your patch and an essentially empty revision just adds 
confusion.

Konrad
>  .../devicetree/bindings/arm/qcom.yaml         |   1 +
>  arch/arm64/boot/dts/qcom/Makefile             |   1 +
>  .../boot/dts/qcom/msm8998-xiaomi-sagit.dts    | 681 ++++++++++++++++++
>  arch/arm64/boot/dts/qcom/pm8998.dtsi          |   8 +
>  4 files changed, 691 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/qcom/msm8998-xiaomi-sagit.dts
Krzysztof Kozlowski Oct. 13, 2022, 1:41 p.m. UTC | #2
On 12/10/2022 15:25, konrad.dybcio@somainline.org wrote:
> On 2022-10-12 20:52, Dzmitry Sankouski wrote:
>> Add initial support for Xiaomi Mi 6 phone (codename sagit)
>>
>> Dzmitry Sankouski (2):
>>   dt-bindings: arm: add xiaomi,sagit board based on msm8998 chip
>>   arm64: dts: qcom: sagit: add initial device tree for sagit
>>
> Looks like you resent this series just to add the A-b on the dt-bindings 
> patch?
> If that's the case, you don't have to do it, the maintainer will pick up 
> the tags
> when applying your patch and an essentially empty revision just adds 
> confusion.

The ack was ignored in last two previous revisions, so the resend was
needed. Maintainer would not find that ack...

Best regards,
Krzysztof