| Message ID | 20221005151309.7278-1-jagan@amarulasolutions.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm: bridge: Add Samsung MIPI DSIM bridge | expand |
Hi Jagan, On 05.10.2022 17:12, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Patch 0001: Samsung DSIM bridge > > Patch 0002: PHY optional > > Patch 0003: OF-graph or Child node lookup > > Patch 0004: DSI host initialization > > Patch 0005: atomic check > > Patch 0006: PMS_P offset via plat data > > Patch 0007: atomic_get_input_bus_fmts > > Patch 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. This finally doesn't break Exynos DSI. :) Feel free to add: Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski The next step would be to merge Dave's patchset and remove the hacks added here and there. Otherwise we will end up adding even more hacks soon. > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? > Jagan. > > Jagan Teki (10): > drm: bridge: Add Samsung DSIM bridge driver > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Handle proper DSI host initialization > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > drm: bridge: samsung-dsim: Add i.MX8MM support > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1856 +++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 +--------------- > include/drm/bridge/samsung-dsim.h | 115 + > 8 files changed, 2108 insertions(+), 1653 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h > Best regards
Hi Marek, On Thu, Oct 6, 2022 at 2:21 AM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Jagan, > > On 05.10.2022 17:12, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > Changes for v7: > > * fix the drm bridge attach chain for exynos drm dsi driver > > * fix the hw_type checking logic > > > > Changes for v6: > > * handle previous bridge for exynos dsi while attaching bridge > > > > Changes for v5: > > * bridge changes to support multi-arch > > * updated and clear commit messages > > * add hw_type via plat data > > * removed unneeded quirk > > * rebased on linux-next > > > > Changes for v4: > > * include Inki Dae in MAINTAINERS > > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > > * update init handling to ensure host init done on first cmd transfer > > > > Changes for v3: > > * fix the mult-arch build > > * fix dsi host init > > * updated commit messages > > > > Changes for v2: > > * fix bridge handling > > * fix dsi host init > > * correct the commit messages > > > > Patch 0001: Samsung DSIM bridge > > > > Patch 0002: PHY optional > > > > Patch 0003: OF-graph or Child node lookup > > > > Patch 0004: DSI host initialization > > > > Patch 0005: atomic check > > > > Patch 0006: PMS_P offset via plat data > > > > Patch 0007: atomic_get_input_bus_fmts > > > > Patch 0008: input_bus_flags > > > > Patch 0009: document fsl,imx8mm-mipi-dsim > > > > Patch 0010: add i.MX8MM DSIM support > > > > Tested in Engicam i.Core MX8M Mini SoM. > > This finally doesn't break Exynos DSI. :) Feel free to add: > > Acked-by: Marek Szyprowski > > Tested-by: Marek Szyprowski > > The next step would be to merge Dave's patchset and remove the hacks > added here and there. Otherwise we will end up adding even more hacks soon. I've some concerns about one of those patches, I will try to comment on that patch in mailing list or will send updated changes on top of those. Thanks, Jagan.
On Wed, Oct 5, 2022 at 1:51 PM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi Jagan, > > On 05.10.2022 17:12, Jagan Teki wrote: > > This series supports common bridge support for Samsung MIPI DSIM > > which is used in Exynos and i.MX8MM SoC's. > > > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > > > Changes for v7: > > * fix the drm bridge attach chain for exynos drm dsi driver > > * fix the hw_type checking logic > > > > Changes for v6: > > * handle previous bridge for exynos dsi while attaching bridge > > > > Changes for v5: > > * bridge changes to support multi-arch > > * updated and clear commit messages > > * add hw_type via plat data > > * removed unneeded quirk > > * rebased on linux-next > > > > Changes for v4: > > * include Inki Dae in MAINTAINERS > > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > > * update init handling to ensure host init done on first cmd transfer > > > > Changes for v3: > > * fix the mult-arch build > > * fix dsi host init > > * updated commit messages > > > > Changes for v2: > > * fix bridge handling > > * fix dsi host init > > * correct the commit messages > > > > Patch 0001: Samsung DSIM bridge > > > > Patch 0002: PHY optional > > > > Patch 0003: OF-graph or Child node lookup > > > > Patch 0004: DSI host initialization > > > > Patch 0005: atomic check > > > > Patch 0006: PMS_P offset via plat data > > > > Patch 0007: atomic_get_input_bus_fmts > > > > Patch 0008: input_bus_flags > > > > Patch 0009: document fsl,imx8mm-mipi-dsim > > > > Patch 0010: add i.MX8MM DSIM support > > > > Tested in Engicam i.Core MX8M Mini SoM. > > This finally doesn't break Exynos DSI. :) Feel free to add: > > Acked-by: Marek Szyprowski > > Tested-by: Marek Szyprowski > > The next step would be to merge Dave's patchset and remove the hacks > added here and there. Otherwise we will end up adding even more hacks soon. Jagan, I've also tested this latest series with a Gateworks imx8mm-venice-gw73xx-0x with a RaspberryPi MIPI DSI compatible DFR0550 display with the following dt overlay: /dts-v1/; /plugin/; &{/} { compatible = "gw,imx8mm-gw73xx-0x", "fsl,imx8mm"; panel { compatible = "powertip,ph800480t013-idf02"; power-supply = <&attiny>; backlight = <&attiny>; port { panel_out_bridge: endpoint { remote-endpoint = <&bridge_out_panel>; }; }; }; }; &i2c3 { #address-cells = <1>; #size-cells = <0>; attiny: regulator@45 { compatible = "raspberrypi,7inch-touchscreen-panel-regulator"; reg = <0x45>; }; }; &dsi { #address-cells = <1>; #size-cells = <0>; status = "okay"; bridge@0 { compatible = "toshiba,tc358762"; reg = <0>; vddc-supply = <&attiny>; status = "okay"; ports { #address-cells = <1>; #size-cells = <0>; port@0 { reg = <0>; bridge_in_dsi: endpoint { remote-endpoint = <&dsi_out_bridge>; }; }; port@1 { reg = <1>; bridge_out_panel: endpoint { remote-endpoint = <&panel_out_bridge>; }; }; }; }; ports { #address-cells = <1>; #size-cells = <0>; port@1 { reg = <1>; dsi_out_bridge: endpoint { remote-endpoint = <&bridge_in_dsi>; }; }; }; }; &lcdif { status = "okay"; }; Tested-by: Tim Harvey <tharvey@gateworks.com> # imx8mm-venice-gw73xx-0x Thanks for all your work on this! Best Regards, Tim > > > Repo: > > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > > > Any inputs? > > Jagan. > > > > Jagan Teki (10): > > drm: bridge: Add Samsung DSIM bridge driver > > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > > drm: bridge: samsung-dsim: Mark PHY as optional > > drm: bridge: samsung-dsim: Handle proper DSI host initialization > > drm: bridge: samsung-dsim: Add atomic_check > > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > > drm: bridge: samsung-dsim: Add input_bus_flags > > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > > drm: bridge: samsung-dsim: Add i.MX8MM support > > > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > > MAINTAINERS | 9 + > > drivers/gpu/drm/bridge/Kconfig | 12 + > > drivers/gpu/drm/bridge/Makefile | 1 + > > drivers/gpu/drm/bridge/samsung-dsim.c | 1856 +++++++++++++++++ > > drivers/gpu/drm/exynos/Kconfig | 1 + > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 +--------------- > > include/drm/bridge/samsung-dsim.h | 115 + > > 8 files changed, 2108 insertions(+), 1653 deletions(-) > > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > > create mode 100644 include/drm/bridge/samsung-dsim.h > > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland >
On 10/5/22 17:13, Jagan Teki wrote: > Samsung MIPI DSIM controller is common DSI IP that can be used in various > SoCs like Exynos, i.MX8M Mini/Nano. > > In order to access this DSI controller between various platform SoCs, > the ideal way to incorporate this in the drm stack is via the drm bridge > driver. > > This patch is trying to differentiate platform-specific and bridge driver > code by maintaining exynos platform glue code in exynos_drm_dsi.c driver > and common bridge driver code in samsung-dsim.c providing that the new > platform-specific glue should be supported in the bridge driver, unlike > exynos platform drm drivers. > > - Add samsung_dsim_plat_data for keeping platform-specific attributes like > host_ops, irq_ops, and hw_type. > > - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c. > > - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and > samsung-dsim.c. > > - plat_data hooks like host_ops and irq_ops are invoked during the > respective bridge call chains. Maybe the Subject should say "Split ... driver" or "Move ... driver" , since it is not adding a new driver here ?
On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: > > On 10/5/22 17:13, Jagan Teki wrote: > > Samsung MIPI DSIM controller is common DSI IP that can be used in various > > SoCs like Exynos, i.MX8M Mini/Nano. > > > > In order to access this DSI controller between various platform SoCs, > > the ideal way to incorporate this in the drm stack is via the drm bridge > > driver. > > > > This patch is trying to differentiate platform-specific and bridge driver > > code by maintaining exynos platform glue code in exynos_drm_dsi.c driver > > and common bridge driver code in samsung-dsim.c providing that the new > > platform-specific glue should be supported in the bridge driver, unlike > > exynos platform drm drivers. > > > > - Add samsung_dsim_plat_data for keeping platform-specific attributes like > > host_ops, irq_ops, and hw_type. > > > > - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c. > > > > - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and > > samsung-dsim.c. > > > > - plat_data hooks like host_ops and irq_ops are invoked during the > > respective bridge call chains. > > Maybe the Subject should say "Split ... driver" or "Move ... driver" , > since it is not adding a new driver here ? Though it is not added a completely new driver, it is adding more infrastructure platform code to be compatible with both Exynos and i.MX8M. This is the prime reason for adding that commit head and explaining the same in the commit body. Jagan.
On 10/17/22 04:49, Jagan Teki wrote: > On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: >> >> On 10/5/22 17:13, Jagan Teki wrote: >>> Samsung MIPI DSIM controller is common DSI IP that can be used in various >>> SoCs like Exynos, i.MX8M Mini/Nano. >>> >>> In order to access this DSI controller between various platform SoCs, >>> the ideal way to incorporate this in the drm stack is via the drm bridge >>> driver. >>> >>> This patch is trying to differentiate platform-specific and bridge driver >>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver >>> and common bridge driver code in samsung-dsim.c providing that the new >>> platform-specific glue should be supported in the bridge driver, unlike >>> exynos platform drm drivers. >>> >>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like >>> host_ops, irq_ops, and hw_type. >>> >>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c. >>> >>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and >>> samsung-dsim.c. >>> >>> - plat_data hooks like host_ops and irq_ops are invoked during the >>> respective bridge call chains. >> >> Maybe the Subject should say "Split ... driver" or "Move ... driver" , >> since it is not adding a new driver here ? > > Though it is not added a completely new driver, it is adding more > infrastructure platform code to be compatible with both Exynos and > i.MX8M. This is the prime reason for adding that commit head and > explaining the same in the commit body. Diffstat looks like this: drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++ drivers/gpu/drm/exynos/Kconfig | 1 + drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++--------------------- include/drm/bridge/samsung-dsim.h | 113 ++ 7 files changed, 1952 insertions(+), 1653 deletions(-) Looks to me like most of the code is just moved from existing driver in this patch.
On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote: > > On 10/17/22 04:49, Jagan Teki wrote: > > On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: > >> > >> On 10/5/22 17:13, Jagan Teki wrote: > >>> Samsung MIPI DSIM controller is common DSI IP that can be used in various > >>> SoCs like Exynos, i.MX8M Mini/Nano. > >>> > >>> In order to access this DSI controller between various platform SoCs, > >>> the ideal way to incorporate this in the drm stack is via the drm bridge > >>> driver. > >>> > >>> This patch is trying to differentiate platform-specific and bridge driver > >>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver > >>> and common bridge driver code in samsung-dsim.c providing that the new > >>> platform-specific glue should be supported in the bridge driver, unlike > >>> exynos platform drm drivers. > >>> > >>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like > >>> host_ops, irq_ops, and hw_type. > >>> > >>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c. > >>> > >>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and > >>> samsung-dsim.c. > >>> > >>> - plat_data hooks like host_ops and irq_ops are invoked during the > >>> respective bridge call chains. > >> > >> Maybe the Subject should say "Split ... driver" or "Move ... driver" , > >> since it is not adding a new driver here ? > > > > Though it is not added a completely new driver, it is adding more > > infrastructure platform code to be compatible with both Exynos and > > i.MX8M. This is the prime reason for adding that commit head and > > explaining the same in the commit body. > > Diffstat looks like this: > > drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++--------------------- > include/drm/bridge/samsung-dsim.h | 113 ++ > 7 files changed, 1952 insertions(+), 1653 deletions(-) > > Looks to me like most of the code is just moved from existing driver in > this patch. Yeah, as I explained (from commit) it is moved, updated, and written the plat code. How about this head? "drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)" Jagan.
On 10/17/22 09:43, Jagan Teki wrote: > On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote: >> >> On 10/17/22 04:49, Jagan Teki wrote: >>> On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: >>>> >>>> On 10/5/22 17:13, Jagan Teki wrote: >>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in various >>>>> SoCs like Exynos, i.MX8M Mini/Nano. >>>>> >>>>> In order to access this DSI controller between various platform SoCs, >>>>> the ideal way to incorporate this in the drm stack is via the drm bridge >>>>> driver. >>>>> >>>>> This patch is trying to differentiate platform-specific and bridge driver >>>>> code by maintaining exynos platform glue code in exynos_drm_dsi.c driver >>>>> and common bridge driver code in samsung-dsim.c providing that the new >>>>> platform-specific glue should be supported in the bridge driver, unlike >>>>> exynos platform drm drivers. >>>>> >>>>> - Add samsung_dsim_plat_data for keeping platform-specific attributes like >>>>> host_ops, irq_ops, and hw_type. >>>>> >>>>> - Initialize the plat_data hooks for exynos platform in exynos_drm_dsi.c. >>>>> >>>>> - samsung_dsim_probe is the common probe call across exynos_drm_dsi.c and >>>>> samsung-dsim.c. >>>>> >>>>> - plat_data hooks like host_ops and irq_ops are invoked during the >>>>> respective bridge call chains. >>>> >>>> Maybe the Subject should say "Split ... driver" or "Move ... driver" , >>>> since it is not adding a new driver here ? >>> >>> Though it is not added a completely new driver, it is adding more >>> infrastructure platform code to be compatible with both Exynos and >>> i.MX8M. This is the prime reason for adding that commit head and >>> explaining the same in the commit body. >> >> Diffstat looks like this: >> >> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 ++++++++++++++++++++++ >> drivers/gpu/drm/exynos/Kconfig | 1 + >> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 ++--------------------- >> include/drm/bridge/samsung-dsim.h | 113 ++ >> 7 files changed, 1952 insertions(+), 1653 deletions(-) >> >> Looks to me like most of the code is just moved from existing driver in >> this patch. > > Yeah, as I explained (from commit) it is moved, updated, and written > the plat code. How about this head? > > "drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)" I disagree with the "Add" part of the Subject, but I'll wait for others' opinion here.
Hi, On 17.10.2022 10:48, Marek Vasut wrote: > On 10/17/22 09:43, Jagan Teki wrote: >> On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote: >>> On 10/17/22 04:49, Jagan Teki wrote: >>>> On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: >>>>> >>>>> On 10/5/22 17:13, Jagan Teki wrote: >>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in >>>>>> various >>>>>> SoCs like Exynos, i.MX8M Mini/Nano. >>>>>> >>>>>> In order to access this DSI controller between various platform >>>>>> SoCs, >>>>>> the ideal way to incorporate this in the drm stack is via the drm >>>>>> bridge >>>>>> driver. >>>>>> >>>>>> This patch is trying to differentiate platform-specific and >>>>>> bridge driver >>>>>> code by maintaining exynos platform glue code in exynos_drm_dsi.c >>>>>> driver >>>>>> and common bridge driver code in samsung-dsim.c providing that >>>>>> the new >>>>>> platform-specific glue should be supported in the bridge driver, >>>>>> unlike >>>>>> exynos platform drm drivers. >>>>>> >>>>>> - Add samsung_dsim_plat_data for keeping platform-specific >>>>>> attributes like >>>>>> host_ops, irq_ops, and hw_type. >>>>>> >>>>>> - Initialize the plat_data hooks for exynos platform in >>>>>> exynos_drm_dsi.c. >>>>>> >>>>>> - samsung_dsim_probe is the common probe call across >>>>>> exynos_drm_dsi.c and >>>>>> samsung-dsim.c. >>>>>> >>>>>> - plat_data hooks like host_ops and irq_ops are invoked during the >>>>>> respective bridge call chains. >>>>> >>>>> Maybe the Subject should say "Split ... driver" or "Move ... >>>>> driver" , >>>>> since it is not adding a new driver here ? >>>> >>>> Though it is not added a completely new driver, it is adding more >>>> infrastructure platform code to be compatible with both Exynos and >>>> i.MX8M. This is the prime reason for adding that commit head and >>>> explaining the same in the commit body. >>> >>> Diffstat looks like this: >>> >>> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 >>> ++++++++++++++++++++++ >>> drivers/gpu/drm/exynos/Kconfig | 1 + >>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 >>> ++--------------------- >>> include/drm/bridge/samsung-dsim.h | 113 ++ >>> 7 files changed, 1952 insertions(+), 1653 deletions(-) >>> >>> Looks to me like most of the code is just moved from existing driver in >>> this patch. >> >> Yeah, as I explained (from commit) it is moved, updated, and written >> the plat code. How about this head? >> >> "drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)" > > I disagree with the "Add" part of the Subject, but I'll wait for > others' opinion here. Maybe something like a "Generalize Exynos-DSI DRM driver into a generic Samsung DSIM bridge"? Best regards
On Mon, Oct 17, 2022 at 2:31 PM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Hi, > > On 17.10.2022 10:48, Marek Vasut wrote: > > On 10/17/22 09:43, Jagan Teki wrote: > >> On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote: > >>> On 10/17/22 04:49, Jagan Teki wrote: > >>>> On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: > >>>>> > >>>>> On 10/5/22 17:13, Jagan Teki wrote: > >>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in > >>>>>> various > >>>>>> SoCs like Exynos, i.MX8M Mini/Nano. > >>>>>> > >>>>>> In order to access this DSI controller between various platform > >>>>>> SoCs, > >>>>>> the ideal way to incorporate this in the drm stack is via the drm > >>>>>> bridge > >>>>>> driver. > >>>>>> > >>>>>> This patch is trying to differentiate platform-specific and > >>>>>> bridge driver > >>>>>> code by maintaining exynos platform glue code in exynos_drm_dsi.c > >>>>>> driver > >>>>>> and common bridge driver code in samsung-dsim.c providing that > >>>>>> the new > >>>>>> platform-specific glue should be supported in the bridge driver, > >>>>>> unlike > >>>>>> exynos platform drm drivers. > >>>>>> > >>>>>> - Add samsung_dsim_plat_data for keeping platform-specific > >>>>>> attributes like > >>>>>> host_ops, irq_ops, and hw_type. > >>>>>> > >>>>>> - Initialize the plat_data hooks for exynos platform in > >>>>>> exynos_drm_dsi.c. > >>>>>> > >>>>>> - samsung_dsim_probe is the common probe call across > >>>>>> exynos_drm_dsi.c and > >>>>>> samsung-dsim.c. > >>>>>> > >>>>>> - plat_data hooks like host_ops and irq_ops are invoked during the > >>>>>> respective bridge call chains. > >>>>> > >>>>> Maybe the Subject should say "Split ... driver" or "Move ... > >>>>> driver" , > >>>>> since it is not adding a new driver here ? > >>>> > >>>> Though it is not added a completely new driver, it is adding more > >>>> infrastructure platform code to be compatible with both Exynos and > >>>> i.MX8M. This is the prime reason for adding that commit head and > >>>> explaining the same in the commit body. > >>> > >>> Diffstat looks like this: > >>> > >>> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 > >>> ++++++++++++++++++++++ > >>> drivers/gpu/drm/exynos/Kconfig | 1 + > >>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 > >>> ++--------------------- > >>> include/drm/bridge/samsung-dsim.h | 113 ++ > >>> 7 files changed, 1952 insertions(+), 1653 deletions(-) > >>> > >>> Looks to me like most of the code is just moved from existing driver in > >>> this patch. > >> > >> Yeah, as I explained (from commit) it is moved, updated, and written > >> the plat code. How about this head? > >> > >> "drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)" > > > > I disagree with the "Add" part of the Subject, but I'll wait for > > others' opinion here. > > Maybe something like a "Generalize Exynos-DSI DRM driver into a generic > Samsung DSIM bridge"? I agreed. Jagan.
Hi Jagan On Wed, 2022-10-05 at 20:42 +0530, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Patch 0001: Samsung DSIM bridge > > Patch 0002: PHY optional > > Patch 0003: OF-graph or Child node lookup > > Patch 0004: DSI host initialization > > Patch 0005: atomic check > > Patch 0006: PMS_P offset via plat data > > Patch 0007: atomic_get_input_bus_fmts > > Patch 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. Thanks for this work! This also works great on Verdin iMX8M Mini together with the SN65DSI84-based Verdin DSI to LVDS Adapter. Tested-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? > Jagan. > > Jagan Teki (10): > drm: bridge: Add Samsung DSIM bridge driver > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Handle proper DSI host initialization > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > drm: bridge: samsung-dsim: Add i.MX8MM support > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1856 +++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 +--------------- > include/drm/bridge/samsung-dsim.h | 115 + > 8 files changed, 2108 insertions(+), 1653 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h Cheers Marcel
Hey Jagan, On Wed, 5 Oct 2022 at 17:13, Jagan Teki <jagan@amarulasolutions.com> wrote: > > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Patch 0001: Samsung DSIM bridge > > Patch 0002: PHY optional > > Patch 0003: OF-graph or Child node lookup > > Patch 0004: DSI host initialization > > Patch 0005: atomic check > > Patch 0006: PMS_P offset via plat data > > Patch 0007: atomic_get_input_bus_fmts > > Patch 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? > Jagan. > > Jagan Teki (10): > drm: bridge: Add Samsung DSIM bridge driver > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Handle proper DSI host initialization > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > drm: bridge: samsung-dsim: Add i.MX8MM support > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1856 +++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 +--------------- > include/drm/bridge/samsung-dsim.h | 115 + > 8 files changed, 2108 insertions(+), 1653 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h I'm seeing some checkpatch --strict warnings throughout this series, do you mind having a look at them?
Hi Jagan, Am Mittwoch, 5. Oktober 2022, 17:12:59 CEST schrieb Jagan Teki: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Patch 0001: Samsung DSIM bridge > > Patch 0002: PHY optional > > Patch 0003: OF-graph or Child node lookup > > Patch 0004: DSI host initialization > > Patch 0005: atomic check > > Patch 0006: PMS_P offset via plat data > > Patch 0007: atomic_get_input_bus_fmts > > Patch 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. Thanks for working on this! This works on TQMa8MQML + MBa8Mx (imx8mm) using a SN65DSI83 DSI-LVDS-Bridge. Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> Best regards, Alexander > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? > Jagan. > > Jagan Teki (10): > drm: bridge: Add Samsung DSIM bridge driver > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Handle proper DSI host initialization > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > drm: bridge: samsung-dsim: Add i.MX8MM support > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1856 +++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 +--------------- > include/drm/bridge/samsung-dsim.h | 115 + > 8 files changed, 2108 insertions(+), 1653 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h
On Tue, Oct 18, 2022 at 8:35 AM Jagan Teki <jagan@amarulasolutions.com> wrote: > > On Mon, Oct 17, 2022 at 2:31 PM Marek Szyprowski > <m.szyprowski@samsung.com> wrote: > > > > Hi, > > > > On 17.10.2022 10:48, Marek Vasut wrote: > > > On 10/17/22 09:43, Jagan Teki wrote: > > >> On Mon, Oct 17, 2022 at 12:49 PM Marek Vasut <marex@denx.de> wrote: > > >>> On 10/17/22 04:49, Jagan Teki wrote: > > >>>> On Sun, Oct 16, 2022 at 3:16 AM Marek Vasut <marex@denx.de> wrote: > > >>>>> > > >>>>> On 10/5/22 17:13, Jagan Teki wrote: > > >>>>>> Samsung MIPI DSIM controller is common DSI IP that can be used in > > >>>>>> various > > >>>>>> SoCs like Exynos, i.MX8M Mini/Nano. > > >>>>>> > > >>>>>> In order to access this DSI controller between various platform > > >>>>>> SoCs, > > >>>>>> the ideal way to incorporate this in the drm stack is via the drm > > >>>>>> bridge > > >>>>>> driver. > > >>>>>> > > >>>>>> This patch is trying to differentiate platform-specific and > > >>>>>> bridge driver > > >>>>>> code by maintaining exynos platform glue code in exynos_drm_dsi.c > > >>>>>> driver > > >>>>>> and common bridge driver code in samsung-dsim.c providing that > > >>>>>> the new > > >>>>>> platform-specific glue should be supported in the bridge driver, > > >>>>>> unlike > > >>>>>> exynos platform drm drivers. > > >>>>>> > > >>>>>> - Add samsung_dsim_plat_data for keeping platform-specific > > >>>>>> attributes like > > >>>>>> host_ops, irq_ops, and hw_type. > > >>>>>> > > >>>>>> - Initialize the plat_data hooks for exynos platform in > > >>>>>> exynos_drm_dsi.c. > > >>>>>> > > >>>>>> - samsung_dsim_probe is the common probe call across > > >>>>>> exynos_drm_dsi.c and > > >>>>>> samsung-dsim.c. > > >>>>>> > > >>>>>> - plat_data hooks like host_ops and irq_ops are invoked during the > > >>>>>> respective bridge call chains. > > >>>>> > > >>>>> Maybe the Subject should say "Split ... driver" or "Move ... > > >>>>> driver" , > > >>>>> since it is not adding a new driver here ? > > >>>> > > >>>> Though it is not added a completely new driver, it is adding more > > >>>> infrastructure platform code to be compatible with both Exynos and > > >>>> i.MX8M. This is the prime reason for adding that commit head and > > >>>> explaining the same in the commit body. > > >>> > > >>> Diffstat looks like this: > > >>> > > >>> drivers/gpu/drm/bridge/samsung-dsim.c | 1703 > > >>> ++++++++++++++++++++++ > > >>> drivers/gpu/drm/exynos/Kconfig | 1 + > > >>> drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 > > >>> ++--------------------- > > >>> include/drm/bridge/samsung-dsim.h | 113 ++ > > >>> 7 files changed, 1952 insertions(+), 1653 deletions(-) > > >>> > > >>> Looks to me like most of the code is just moved from existing driver in > > >>> this patch. > > >> > > >> Yeah, as I explained (from commit) it is moved, updated, and written > > >> the plat code. How about this head? > > >> > > >> "drm: bridge: Add Samsung DSIM bridge (Split from exynos_drm_dsi)" > > > > > > I disagree with the "Add" part of the Subject, but I'll wait for > > > others' opinion here. > > > > Maybe something like a "Generalize Exynos-DSI DRM driver into a generic > > Samsung DSIM bridge"? I'm using this commit head for next version patches, hope all Okay with it. Thanks, Jagan.
Hello Jagan, On 10/5/22 17:12, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Patch 0001: Samsung DSIM bridge > > Patch 0002: PHY optional > > Patch 0003: OF-graph or Child node lookup > > Patch 0004: DSI host initialization > > Patch 0005: atomic check > > Patch 0006: PMS_P offset via plat data > > Patch 0007: atomic_get_input_bus_fmts > > Patch 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? I tried this series on Armadeus OPOS8MM Dev (i.MX8MM) board with the PowerTrip PH720128T004-ZBC02 DSI panel (720x1280, 2 lanes). It works after I fixed the logic of some video mode flags: in function samsung_dsim_init_link(struct samsung_dsim *dsi): -if (!(dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP)) +if (dsi->mode_flags & MIPI_DSI_MODE_VIDEO_NO_HFP) reg |= DSIM_HFP_MODE; The bit has to be set to disable HFP. Same logic for HPB, HSA and EOT packets. Regards, > Jagan. > > Jagan Teki (10): > drm: bridge: Add Samsung DSIM bridge driver > drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices > drm: bridge: samsung-dsim: Mark PHY as optional > drm: bridge: samsung-dsim: Handle proper DSI host initialization > drm: bridge: samsung-dsim: Add atomic_check > drm: bridge: samsung-dsim: Add platform PLL_P (PMS_P) offset > drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts > drm: bridge: samsung-dsim: Add input_bus_flags > dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support > drm: bridge: samsung-dsim: Add i.MX8MM support > > .../bindings/display/exynos/exynos_dsim.txt | 1 + > MAINTAINERS | 9 + > drivers/gpu/drm/bridge/Kconfig | 12 + > drivers/gpu/drm/bridge/Makefile | 1 + > drivers/gpu/drm/bridge/samsung-dsim.c | 1856 +++++++++++++++++ > drivers/gpu/drm/exynos/Kconfig | 1 + > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 1766 +--------------- > include/drm/bridge/samsung-dsim.h | 115 + > 8 files changed, 2108 insertions(+), 1653 deletions(-) > create mode 100644 drivers/gpu/drm/bridge/samsung-dsim.c > create mode 100644 include/drm/bridge/samsung-dsim.h >
On 05.10.22 17:12, Jagan Teki wrote: > This series supports common bridge support for Samsung MIPI DSIM > which is used in Exynos and i.MX8MM SoC's. > > The final bridge supports both the Exynos and i.MX8MM DSI devices. > > Changes for v7: > * fix the drm bridge attach chain for exynos drm dsi driver > * fix the hw_type checking logic > > Changes for v6: > * handle previous bridge for exynos dsi while attaching bridge > > Changes for v5: > * bridge changes to support multi-arch > * updated and clear commit messages > * add hw_type via plat data > * removed unneeded quirk > * rebased on linux-next > > Changes for v4: > * include Inki Dae in MAINTAINERS > * remove dsi_driver probe in exynos_drm_drv to support multi-arch build > * update init handling to ensure host init done on first cmd transfer > > Changes for v3: > * fix the mult-arch build > * fix dsi host init > * updated commit messages > > Changes for v2: > * fix bridge handling > * fix dsi host init > * correct the commit messages > > Patch 0001: Samsung DSIM bridge > > Patch 0002: PHY optional > > Patch 0003: OF-graph or Child node lookup > > Patch 0004: DSI host initialization > > Patch 0005: atomic check > > Patch 0006: PMS_P offset via plat data > > Patch 0007: atomic_get_input_bus_fmts > > Patch 0008: input_bus_flags > > Patch 0009: document fsl,imx8mm-mipi-dsim > > Patch 0010: add i.MX8MM DSIM support > > Tested in Engicam i.Core MX8M Mini SoM. > > Repo: > https://gitlab.com/openedev/kernel/-/commits/imx8mm-dsi-v7 > > Any inputs? > Jagan. I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge and a Jenson 7" LVDS Display. Thanks for your work, Jagan! Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron DL i.MX8MM
Hi, On Mon, Nov 7, 2022 at 1:34 PM Frieder Schrempf <frieder.schrempf@kontron.de> wrote: > I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge > and a Jenson 7" LVDS Display. > > Thanks for your work, Jagan! > > Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron DL > i.MX8MM As this series has been successfully tested on multiple devices, is it possible to apply it so people can make further adjustments? Thanks
On Thu, Nov 10, 2022 at 9:24 PM Fabio Estevam <festevam@gmail.com> wrote: > > Hi, > > On Mon, Nov 7, 2022 at 1:34 PM Frieder Schrempf > <frieder.schrempf@kontron.de> wrote: > > > I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge > > and a Jenson 7" LVDS Display. > > > > Thanks for your work, Jagan! > > > > Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron DL > > i.MX8MM > > As this series has been successfully tested on multiple devices, is it possible > to apply it so people can make further adjustments? I think the next version patchset on this would be clean and properly address a few comments from Marek Vasut. However, I'm still waiting for Marek's response to my comment on the input bus formats - if it is Okay I will send the v8. https://lore.kernel.org/all/CAMty3ZAM+fetmBQWaSbfjME7-Up4h+Ln3BRHaPgg5tuSsObPdw@mail.gmail.com/ Thanks, Jagan.
On 11/10/22 17:03, Jagan Teki wrote: > On Thu, Nov 10, 2022 at 9:24 PM Fabio Estevam <festevam@gmail.com> wrote: >> >> Hi, >> >> On Mon, Nov 7, 2022 at 1:34 PM Frieder Schrempf >> <frieder.schrempf@kontron.de> wrote: >> >>> I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge >>> and a Jenson 7" LVDS Display. >>> >>> Thanks for your work, Jagan! >>> >>> Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron DL >>> i.MX8MM >> >> As this series has been successfully tested on multiple devices, is it possible >> to apply it so people can make further adjustments? > > I think the next version patchset on this would be clean and properly > address a few comments from Marek Vasut. However, I'm still waiting > for Marek's response to my comment on the input bus formats - if it is > Okay I will send the v8. > https://lore.kernel.org/all/CAMty3ZAM+fetmBQWaSbfjME7-Up4h+Ln3BRHaPgg5tuSsObPdw@mail.gmail.com/ Just send a V8 and let's see how that looks, no need to wait for me.
On Thu, Nov 10, 2022 at 10:29 PM Marek Vasut <marex@denx.de> wrote: > > On 11/10/22 17:03, Jagan Teki wrote: > > On Thu, Nov 10, 2022 at 9:24 PM Fabio Estevam <festevam@gmail.com> wrote: > >> > >> Hi, > >> > >> On Mon, Nov 7, 2022 at 1:34 PM Frieder Schrempf > >> <frieder.schrempf@kontron.de> wrote: > >> > >>> I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge > >>> and a Jenson 7" LVDS Display. > >>> > >>> Thanks for your work, Jagan! > >>> > >>> Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron DL > >>> i.MX8MM > >> > >> As this series has been successfully tested on multiple devices, is it possible > >> to apply it so people can make further adjustments? > > > > I think the next version patchset on this would be clean and properly > > address a few comments from Marek Vasut. However, I'm still waiting > > for Marek's response to my comment on the input bus formats - if it is > > Okay I will send the v8. > > https://lore.kernel.org/all/CAMty3ZAM+fetmBQWaSbfjME7-Up4h+Ln3BRHaPgg5tuSsObPdw@mail.gmail.com/ > > Just send a V8 and let's see how that looks, no need to wait for me. Planning to include your 8M Plus patch as part of the v8, hope it's fine? Jagan.
On 11/10/22 18:37, Jagan Teki wrote: > On Thu, Nov 10, 2022 at 10:29 PM Marek Vasut <marex@denx.de> wrote: >> >> On 11/10/22 17:03, Jagan Teki wrote: >>> On Thu, Nov 10, 2022 at 9:24 PM Fabio Estevam <festevam@gmail.com> wrote: >>>> >>>> Hi, >>>> >>>> On Mon, Nov 7, 2022 at 1:34 PM Frieder Schrempf >>>> <frieder.schrempf@kontron.de> wrote: >>>> >>>>> I tested this on the Kontron DL i.MX8MM which uses a TI SN65DSI84 bridge >>>>> and a Jenson 7" LVDS Display. >>>>> >>>>> Thanks for your work, Jagan! >>>>> >>>>> Tested-by: Frieder Schrempf <frieder.schrempf@kontron.de> # Kontron DL >>>>> i.MX8MM >>>> >>>> As this series has been successfully tested on multiple devices, is it possible >>>> to apply it so people can make further adjustments? >>> >>> I think the next version patchset on this would be clean and properly >>> address a few comments from Marek Vasut. However, I'm still waiting >>> for Marek's response to my comment on the input bus formats - if it is >>> Okay I will send the v8. >>> https://lore.kernel.org/all/CAMty3ZAM+fetmBQWaSbfjME7-Up4h+Ln3BRHaPgg5tuSsObPdw@mail.gmail.com/ >> >> Just send a V8 and let's see how that looks, no need to wait for me. > > Planning to include your 8M Plus patch as part of the v8, hope it's fine? Fine