| Message ID | 20221014221102.7445-3-quic_molvera@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add dma gpi support for QDU1000/QRU1000 SoCs | expand |
On 14/10/2022 18:11, Melody Olvera wrote: > Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > drivers/dma/qcom/gpi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > index cc938a31dc2d..02438735e92b 100644 > --- a/drivers/dma/qcom/gpi.c > +++ b/drivers/dma/qcom/gpi.c > @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev) > } > > static const struct of_device_id gpi_of_match[] = { > + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 }, > + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 }, The feedback was: drop entire patch. There is really no need for this pattern to keep growing. Best regards, Krzysztof
On 15-10-22, 09:42, Krzysztof Kozlowski wrote: > On 14/10/2022 18:11, Melody Olvera wrote: > > Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs. > > > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > > --- > > drivers/dma/qcom/gpi.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c > > index cc938a31dc2d..02438735e92b 100644 > > --- a/drivers/dma/qcom/gpi.c > > +++ b/drivers/dma/qcom/gpi.c > > @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev) > > } > > > > static const struct of_device_id gpi_of_match[] = { > > + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 }, > > + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 }, > > The feedback was: drop entire patch. > > There is really no need for this pattern to keep growing. Right, I have picked the patches so you dont need to add yours to driver file, please check dmaengine/next
On 10/19/2022 6:30 AM, Vinod Koul wrote: > On 15-10-22, 09:42, Krzysztof Kozlowski wrote: >> On 14/10/2022 18:11, Melody Olvera wrote: >>> Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs. >>> >>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >>> --- >>> drivers/dma/qcom/gpi.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c >>> index cc938a31dc2d..02438735e92b 100644 >>> --- a/drivers/dma/qcom/gpi.c >>> +++ b/drivers/dma/qcom/gpi.c >>> @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev) >>> } >>> >>> static const struct of_device_id gpi_of_match[] = { >>> + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 }, >>> + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 }, >> The feedback was: drop entire patch. >> >> There is really no need for this pattern to keep growing. > Right, I have picked the patches so you dont need to add yours to driver > file, please check dmaengine/next > Yes, I think I understand now; I'll just use existing compatibles and drop this PS. Thanks, Melody
diff --git a/drivers/dma/qcom/gpi.c b/drivers/dma/qcom/gpi.c index cc938a31dc2d..02438735e92b 100644 --- a/drivers/dma/qcom/gpi.c +++ b/drivers/dma/qcom/gpi.c @@ -2286,6 +2286,8 @@ static int gpi_probe(struct platform_device *pdev) } static const struct of_device_id gpi_of_match[] = { + { .compatible = "qcom,qdu1000-gpi-dma", .data = (void *)0x10000 }, + { .compatible = "qcom,qru1000-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sc7280-gpi-dma", .data = (void *)0x10000 }, { .compatible = "qcom,sdm845-gpi-dma", .data = (void *)0x0 }, { .compatible = "qcom,sm6350-gpi-dma", .data = (void *)0x10000 },
Add compatible fields for the Qualcomm QDU1000 and QRU1000 SoCs. Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> --- drivers/dma/qcom/gpi.c | 2 ++ 1 file changed, 2 insertions(+)