mbox series

[liburing,0/2] liburing: fix shortening api issues

Message ID 20221019145042.446477-1-dylany@meta.com (mailing list archive)
Headers show
Series liburing: fix shortening api issues | expand

Message

Dylan Yudaken Oct. 19, 2022, 2:50 p.m. UTC 
The liburing public API has a couple of int shortening issues found by
compiling with cc="clang -Wshorten-64-to-32 -Werror"

There are a few more in the main library, and a *lot* in the tests, which
would be nice to fix up at some point. The public API changes are
particularly useful for build systems that include these files and run
with these errors enabled.


Dylan Yudaken (2):
  fix int shortening bug in io_uring_recvmsg_validate
  fix len type of fgettxattr etc

 src/include/liburing.h | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)


base-commit: 13f3fe3af811d8508676dbd1ef552f2b459e1b21

Comments

Jens Axboe Oct. 19, 2022, 7:49 p.m. UTC | #1 
On Wed, 19 Oct 2022 07:50:40 -0700, Dylan Yudaken wrote:
> The liburing public API has a couple of int shortening issues found by
> compiling with cc="clang -Wshorten-64-to-32 -Werror"
> 
> There are a few more in the main library, and a *lot* in the tests, which
> would be nice to fix up at some point. The public API changes are
> particularly useful for build systems that include these files and run
> with these errors enabled.
> 
> [...]

Applied, thanks!

[1/2] fix int shortening bug in io_uring_recvmsg_validate
      commit: d916aa80993438dbcec700202b21b550edc03941
[2/2] fix len type of fgettxattr etc
      commit: 5698e179a1308aa8019a482ca910a832b5737e5f

Best regards,
Ammar Faizi Oct. 19, 2022, 8:52 p.m. UTC | #2 
On 10/19/22 9:50 PM, Dylan Yudaken wrote:
> The liburing public API has a couple of int shortening issues found by
> compiling with cc="clang -Wshorten-64-to-32 -Werror"
> 
> There are a few more in the main library, and a *lot* in the tests, which
> would be nice to fix up at some point. The public API changes are
> particularly useful for build systems that include these files and run
> with these errors enabled.

Let's clean the main library up, but ignore the tests for now. I'll send
a cleanup series for review before the release.