| Message ID | 20221020225804.291712-1-luiz.dentz@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c8836711ad0725fc780dd999784ea169a344734b |
| Headers | show |
| Series | [BlueZ] client: Fix advertise.data command | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/checkpatch | success | Checkpatch PASS |
| tedd_an/gitlint | success | Gitlint PASS |
| tedd_an/setupell | success | Setup ELL PASS |
| tedd_an/buildprep | success | Build Prep PASS |
| tedd_an/build | success | Build Configuration PASS |
| tedd_an/makecheck | success | Make Check PASS |
| tedd_an/makecheckvalgrind | success | Make Check PASS |
| tedd_an/makedistcheck | success | Make Distcheck PASS |
| tedd_an/build_extell | success | Build External ELL PASS |
| tedd_an/build_extell_make | success | Build Make with External ELL PASS |
| tedd_an/scan_build | success | Pass |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=687318 ---Test result--- Test Summary: CheckPatch PASS 1.03 seconds GitLint PASS 0.71 seconds Prep - Setup ELL PASS 26.94 seconds Build - Prep PASS 0.68 seconds Build - Configure PASS 8.32 seconds Build - Make PASS 763.73 seconds Make Check PASS 11.17 seconds Make Check w/Valgrind PASS 292.39 seconds Make Distcheck PASS 241.02 seconds Build w/ext ELL - Configure PASS 8.40 seconds Build w/ext ELL - Make PASS 85.42 seconds Incremental Build w/ patches PASS 0.00 seconds Scan Build PASS 489.74 seconds --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Thu, 20 Oct 2022 15:58:04 -0700 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > advertise.data when no parameter is given shall print what is set on > ad.data not the ad.manufacturer which is a different field set by > advertise.manufacturer. > --- > client/advertising.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here is the summary with links: - [BlueZ] client: Fix advertise.data command https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c8836711ad07 You are awesome, thank you!
diff --git a/client/advertising.c b/client/advertising.c index 097b9437f794..fb9b049fde78 100644 --- a/client/advertising.c +++ b/client/advertising.c @@ -760,7 +760,7 @@ void ad_advertise_data(DBusConnection *conn, int argc, char *argv[]) struct ad_data data; if (argc < 2 || !strlen(argv[1])) { - if (ad.manufacturer.data.len) { + if (ad.data.data.len) { bt_shell_printf("Type: 0x%02x\n", ad.data.type); bt_shell_hexdump(ad.data.data.data, ad.data.data.len); }
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> advertise.data when no parameter is given shall print what is set on ad.data not the ad.manufacturer which is a different field set by advertise.manufacturer. --- client/advertising.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)