| Message ID | 20221021034400.542909-18-zack@kde.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/vmwgfx: fb, cursors and hashtable refactor | expand |
From: Martin Krastev <krastevm@vmware.com> On 21.10.22 г. 6:44 ч., Zack Rusin wrote: > From: Zack Rusin <zackr@vmware.com> > > Fixes a warning about extra docs about a function argument that has been > removed a while back: > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function > parameter 'sync_file' description in 'vmw_execbuf_copy_fence_user' > > Fixes: a0f90c881570 ("drm/vmwgfx: Fix stale file descriptors on failed usercopy") > Signed-off-by: Zack Rusin <zackr@vmware.com> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > index c943ab801ca7..f16fc489d725 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > @@ -3869,7 +3869,6 @@ int vmw_execbuf_fence_commands(struct drm_file *file_priv, > * @fence: Pointer to the fenc object. > * @fence_handle: User-space fence handle. > * @out_fence_fd: exported file descriptor for the fence. -1 if not used > - * @sync_file: Only used to clean up in case of an error in this function. > * > * This function copies fence information to user-space. If copying fails, the > * user-space struct drm_vmw_fence_rep::error member is hopefully left Phantom arg doc goodbye! Reviewed-by: Martin Krastev <krastevm@vmware.com> Regards, Martin
On 10/20/22 20:44, Zack Rusin wrote: > From: Zack Rusin <zackr@vmware.com> > > Fixes a warning about extra docs about a function argument that has been > removed a while back: > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c:3888: warning: Excess function > parameter 'sync_file' description in 'vmw_execbuf_copy_fence_user' > > Fixes: a0f90c881570 ("drm/vmwgfx: Fix stale file descriptors on failed usercopy") > Signed-off-by: Zack Rusin <zackr@vmware.com> > --- > drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > index c943ab801ca7..f16fc489d725 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c > @@ -3869,7 +3869,6 @@ int vmw_execbuf_fence_commands(struct drm_file *file_priv, > * @fence: Pointer to the fenc object. > * @fence_handle: User-space fence handle. > * @out_fence_fd: exported file descriptor for the fence. -1 if not used > - * @sync_file: Only used to clean up in case of an error in this function. > * > * This function copies fence information to user-space. If copying fails, the > * user-space struct drm_vmw_fence_rep::error member is hopefully left
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c index c943ab801ca7..f16fc489d725 100644 --- a/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_execbuf.c @@ -3869,7 +3869,6 @@ int vmw_execbuf_fence_commands(struct drm_file *file_priv, * @fence: Pointer to the fenc object. * @fence_handle: User-space fence handle. * @out_fence_fd: exported file descriptor for the fence. -1 if not used - * @sync_file: Only used to clean up in case of an error in this function. * * This function copies fence information to user-space. If copying fails, the * user-space struct drm_vmw_fence_rep::error member is hopefully left