mbox series

[v3,net,0/5] amd-xgbe: Miscellaneous fixes

Message ID 20221020064215.2341278-1-Raju.Rangoju@amd.com (mailing list archive)
Headers show
Series amd-xgbe: Miscellaneous fixes | expand

Message

Raju Rangoju Oct. 20, 2022, 6:42 a.m. UTC
(1) Fix the rrc for Yellow carp devices. CDR workaround path
    is disabled for YC devices, receiver reset cycle is not
    needed in such cases.

(2) Add enumerations for mailbox command and sub-commands.
    Instead of using hard-coded values, use enums.

(3) Enable PLL_CTL for fixed PHY modes only. Driver does not
    implement SW RRCM for Autoneg Off configuration, hence PLL
    is needed for fixed PHY modes only.

(4) Fix the SFP compliance codes check for DAC cables. Some of
    the passive cables have non-zero data at offset 6 in
    SFP EEPROM data. So, fix the sfp compliance codes check.

(5) Add a quirk for Molex passive cables to extend the rate
    ceiling to 0x78.

Raju Rangoju (5):
  amd-xgbe: Yellow carp devices do not need rrc
  amd-xgbe: use enums for mailbox cmd and sub_cmds
  amd-xgbe: enable PLL_CTL for fixed PHY modes only
  amd-xgbe: fix the SFP compliance codes check for DAC cables
  amd-xgbe: add the bit rate quirk for Molex cables

 drivers/net/ethernet/amd/xgbe/xgbe-pci.c    |  5 ++
 drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 58 +++++++++++++--------
 drivers/net/ethernet/amd/xgbe/xgbe.h        | 26 +++++++++
 3 files changed, 68 insertions(+), 21 deletions(-)

Comments

Tom Lendacky Oct. 20, 2022, 5:33 p.m. UTC | #1
On 10/20/22 01:42, Raju Rangoju wrote:
> (1) Fix the rrc for Yellow carp devices. CDR workaround path
>      is disabled for YC devices, receiver reset cycle is not
>      needed in such cases.
> 
> (2) Add enumerations for mailbox command and sub-commands.
>      Instead of using hard-coded values, use enums.
> 
> (3) Enable PLL_CTL for fixed PHY modes only. Driver does not
>      implement SW RRCM for Autoneg Off configuration, hence PLL
>      is needed for fixed PHY modes only.
> 
> (4) Fix the SFP compliance codes check for DAC cables. Some of
>      the passive cables have non-zero data at offset 6 in
>      SFP EEPROM data. So, fix the sfp compliance codes check.
> 
> (5) Add a quirk for Molex passive cables to extend the rate
>      ceiling to 0x78.
> 
> Raju Rangoju (5):
>    amd-xgbe: Yellow carp devices do not need rrc
>    amd-xgbe: use enums for mailbox cmd and sub_cmds
>    amd-xgbe: enable PLL_CTL for fixed PHY modes only
>    amd-xgbe: fix the SFP compliance codes check for DAC cables
>    amd-xgbe: add the bit rate quirk for Molex cables

For the series,

Acked-by: Tom Lendacky <thomas.lendacky@amd.com>

> 
>   drivers/net/ethernet/amd/xgbe/xgbe-pci.c    |  5 ++
>   drivers/net/ethernet/amd/xgbe/xgbe-phy-v2.c | 58 +++++++++++++--------
>   drivers/net/ethernet/amd/xgbe/xgbe.h        | 26 +++++++++
>   3 files changed, 68 insertions(+), 21 deletions(-)
>
patchwork-bot+netdevbpf@kernel.org Oct. 22, 2022, 5:50 a.m. UTC | #2
Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 20 Oct 2022 12:12:10 +0530 you wrote:
> (1) Fix the rrc for Yellow carp devices. CDR workaround path
>     is disabled for YC devices, receiver reset cycle is not
>     needed in such cases.
> 
> (2) Add enumerations for mailbox command and sub-commands.
>     Instead of using hard-coded values, use enums.
> 
> [...]

Here is the summary with links:
  - [v3,net,1/5] amd-xgbe: Yellow carp devices do not need rrc
    https://git.kernel.org/netdev/net/c/f97fc7ef4146
  - [v3,net,2/5] amd-xgbe: use enums for mailbox cmd and sub_cmds
    https://git.kernel.org/netdev/net/c/1246d0862349
  - [v3,net,3/5] amd-xgbe: enable PLL_CTL for fixed PHY modes only
    https://git.kernel.org/netdev/net/c/fc75c032aee6
  - [v3,net,4/5] amd-xgbe: fix the SFP compliance codes check for DAC cables
    https://git.kernel.org/netdev/net/c/09c5f6bf11ac
  - [v3,net,5/5] amd-xgbe: add the bit rate quirk for Molex cables
    https://git.kernel.org/netdev/net/c/170a9e341a3b

You are awesome, thank you!