| Message ID | 20220915062855.751881-5-alexander.stein@ew.tq-group.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ca69b6c78d5d6cd9a4417d279eda1d2cd2fb3829 |
| Headers | show |
| Series | USB host support for TQMa8MPxL + MBa8MPxL | expand |
On Thu, Sep 15, 2022 at 08:28:55AM +0200, Alexander Stein wrote: > The on-board USB hub has a single reset line which needs to be enabled. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > --- > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 41 +++++++++++++++++++ > 1 file changed, 41 insertions(+) This patch failed to apply, please rebase and resend. thanks, greg k-h
Hi Greg, Am Donnerstag, 22. September 2022, 15:17:06 CEST schrieb Greg Kroah-Hartman: > On Thu, Sep 15, 2022 at 08:28:55AM +0200, Alexander Stein wrote: > > The on-board USB hub has a single reset line which needs to be enabled. > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > --- > > > > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 41 +++++++++++++++++++ > > 1 file changed, 41 insertions(+) > > This patch failed to apply, please rebase and resend. If I rebase this one to usb-testing (or usb-next) this will conflict with additional patches for this file already in linux-next later on, especially fb4f0b69565e ("arm64: dts: tqma8mpql: add USB DR support"). So IMHO this might not the best idea. How to proceed here? Maybe Shawn can take this one once the other 3 patches hit linux-next. Best regards, Alexander
On Thu, Sep 22, 2022 at 03:39:01PM +0200, Alexander Stein wrote: > Hi Greg, > > Am Donnerstag, 22. September 2022, 15:17:06 CEST schrieb Greg Kroah-Hartman: > > On Thu, Sep 15, 2022 at 08:28:55AM +0200, Alexander Stein wrote: > > > The on-board USB hub has a single reset line which needs to be enabled. > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > --- > > > > > > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 41 +++++++++++++++++++ > > > 1 file changed, 41 insertions(+) > > > > This patch failed to apply, please rebase and resend. > > If I rebase this one to usb-testing (or usb-next) this will conflict with > additional patches for this file already in linux-next later on, especially > fb4f0b69565e ("arm64: dts: tqma8mpql: add USB DR support"). So IMHO this might > not the best idea. > How to proceed here? Maybe Shawn can take this one once the other 3 patches > hit linux-next. Yeah, or just wait for 6.1-rc1 to come out? Your call, greg k-h
Hi Shawn, Am Donnerstag, 22. September 2022, 15:47:02 CEST schrieb Greg Kroah-Hartman: > On Thu, Sep 22, 2022 at 03:39:01PM +0200, Alexander Stein wrote: > > Hi Greg, > > > > Am Donnerstag, 22. September 2022, 15:17:06 CEST schrieb Greg Kroah- Hartman: > > > On Thu, Sep 15, 2022 at 08:28:55AM +0200, Alexander Stein wrote: > > > > The on-board USB hub has a single reset line which needs to be > > > > enabled. > > > > > > > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> > > > > --- > > > > > > > > .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 41 > > > > +++++++++++++++++++ > > > > 1 file changed, 41 insertions(+) > > > > > > This patch failed to apply, please rebase and resend. > > > > If I rebase this one to usb-testing (or usb-next) this will conflict with > > additional patches for this file already in linux-next later on, > > especially > > fb4f0b69565e ("arm64: dts: tqma8mpql: add USB DR support"). So IMHO this > > might not the best idea. > > How to proceed here? Maybe Shawn can take this one once the other 3 > > patches > > hit linux-next. > > Yeah, or just wait for 6.1-rc1 to come out? > > Your call, now that patches 1 till 3 have hit linux-next, feel free to pick patch 4 into your tree. Best regards, Alexander
On Thu, Sep 15, 2022 at 08:28:55AM +0200, Alexander Stein wrote: > The on-board USB hub has a single reset line which needs to be enabled. > > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> Applied, thanks!
diff --git a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts index 7bf6f81e87b4..1c440909f580 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts +++ b/arch/arm64/boot/dts/freescale/imx8mp-tqma8mpql-mba8mpxl.dts @@ -461,11 +461,23 @@ &usb3_0 { status = "okay"; }; +&usb3_1 { + fsl,disable-port-power-control; + fsl,permanently-attached; + dr_mode = "host"; + status = "okay"; +}; + &usb3_phy0 { vbus-supply = <®_vcc_5v0>; status = "okay"; }; +&usb3_phy1 { + vbus-supply = <®_vcc_5v0>; + status = "okay"; +}; + &usb_dwc3_0 { /* dual role is implemented, but not a full featured OTG */ hnp-disable; @@ -486,6 +498,31 @@ connector { }; }; +&usb_dwc3_1 { + dr_mode = "host"; + #address-cells = <1>; + #size-cells = <0>; + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_usbhub>; + status = "okay"; + + hub_2_0: hub@1 { + compatible = "usb451,8142"; + reg = <1>; + peer-hub = <&hub_3_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_vcc_3v3>; + }; + + hub_3_0: hub@2 { + compatible = "usb451,8140"; + reg = <2>; + peer-hub = <&hub_2_0>; + reset-gpios = <&gpio1 11 GPIO_ACTIVE_LOW>; + vdd-supply = <®_vcc_3v3>; + }; +}; + &usdhc2 { pinctrl-names = "default", "state_100mhz", "state_200mhz"; pinctrl-0 = <&pinctrl_usdhc2>, <&pinctrl_usdhc2_gpio>; @@ -720,6 +757,10 @@ pinctrl_usbcon0: usb0congrp { fsl,pins = <MX8MP_IOMUXC_GPIO1_IO10__GPIO1_IO10 0x1c0>; }; + pinctrl_usbhub: usbhubgrp { + fsl,pins = <MX8MP_IOMUXC_GPIO1_IO11__GPIO1_IO11 0x10>; + }; + pinctrl_usdhc2: usdhc2grp { fsl,pins = <MX8MP_IOMUXC_SD2_CLK__USDHC2_CLK 0x192>, <MX8MP_IOMUXC_SD2_CMD__USDHC2_CMD 0x1d2>,
The on-board USB hub has a single reset line which needs to be enabled. Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com> --- .../freescale/imx8mp-tqma8mpql-mba8mpxl.dts | 41 +++++++++++++++++++ 1 file changed, 41 insertions(+)