[v15,0/3] ] Add TDX Guest Attestation support

Message

Kuppuswamy Sathyanarayanan Oct. 20, 2022, 4:58 a.m. UTC

Hi All,

Intel's Trust Domain Extensions (TDX) protect guest VMs from malicious
hosts and some physical attacks. VM guest with TDX support is called
as a TDX Guest.

In TDX guest, attestation process is used to verify the TDX guest
trustworthiness to other entities before provisioning secrets to the
guest. For example, a key server may request for attestation before
releasing the encryption keys to mount the encrypted rootfs or
secondary drive.

This patch set adds attestation support for the TDX guest. Details
about the TDX attestation process and the steps involved are explained
in Documentation/x86/tdx.rst (added by patch 2/3).

Following are the details of the patch set:

Patch 1/3 -> Preparatory patch for adding attestation support.
Patch 2/3 -> Adds user interface driver to support attestation.
Patch 3/3 -> Adds selftest support for TDREPORT feature.

Commit log history is maintained in the individual patches.

Kuppuswamy Sathyanarayanan (3):
  x86/tdx: Add a wrapper to get TDREPORT from the TDX Module
  virt: Add TDX guest driver
  selftests: tdx: Test TDX attestation GetReport support

 Documentation/virt/coco/tdx-guest.rst        |  42 +++++
 Documentation/virt/index.rst                 |   1 +
 Documentation/x86/tdx.rst                    |  43 +++++
 arch/x86/coco/tdx/tdx.c                      |  31 ++++
 arch/x86/include/asm/tdx.h                   |   2 +
 drivers/virt/Kconfig                         |   2 +
 drivers/virt/Makefile                        |   1 +
 drivers/virt/coco/tdx-guest/Kconfig          |  10 ++
 drivers/virt/coco/tdx-guest/Makefile         |   2 +
 drivers/virt/coco/tdx-guest/tdx-guest.c      | 131 ++++++++++++++
 include/uapi/linux/tdx-guest.h               |  51 ++++++
 tools/testing/selftests/Makefile             |   1 +
 tools/testing/selftests/tdx/Makefile         |   7 +
 tools/testing/selftests/tdx/config           |   1 +
 tools/testing/selftests/tdx/tdx_guest_test.c | 175 +++++++++++++++++++
 15 files changed, 500 insertions(+)
 create mode 100644 Documentation/virt/coco/tdx-guest.rst
 create mode 100644 drivers/virt/coco/tdx-guest/Kconfig
 create mode 100644 drivers/virt/coco/tdx-guest/Makefile
 create mode 100644 drivers/virt/coco/tdx-guest/tdx-guest.c
 create mode 100644 include/uapi/linux/tdx-guest.h
 create mode 100644 tools/testing/selftests/tdx/Makefile
 create mode 100644 tools/testing/selftests/tdx/config
 create mode 100644 tools/testing/selftests/tdx/tdx_guest_test.c

Comments

Dave Hansen Oct. 20, 2022, 5:08 p.m. UTC | #1

On 10/19/22 21:58, Kuppuswamy Sathyanarayanan wrote:
> Following are the details of the patch set:
> 
> Patch 1/3 -> Preparatory patch for adding attestation support.
> Patch 2/3 -> Adds user interface driver to support attestation.
> Patch 3/3 -> Adds selftest support for TDREPORT feature.
> 
> Commit log history is maintained in the individual patches.

I really appreciate when folks come out and say what they think should
be done with the series.  Is this ready to be applied?  Or, is it just
being thrown over the fence in the general direction of the maintainers
with the hope that they'll divine its true purpose?

Kuppuswamy Sathyanarayanan Oct. 23, 2022, 4:09 p.m. UTC | #2

Hi Dave,

On 10/20/22 10:08 AM, Dave Hansen wrote:
> On 10/19/22 21:58, Kuppuswamy Sathyanarayanan wrote:
>> Following are the details of the patch set:
>>
>> Patch 1/3 -> Preparatory patch for adding attestation support.
>> Patch 2/3 -> Adds user interface driver to support attestation.
>> Patch 3/3 -> Adds selftest support for TDREPORT feature.
>>
>> Commit log history is maintained in the individual patches.
> 
> I really appreciate when folks come out and say what they think should
> be done with the series.  Is this ready to be applied?  Or, is it just

There are some minor changes suggested by Greg in this version. I will
address them in the next version. IMO, the next version can be considered
for the merge.

> being thrown over the fence in the general direction of the maintainers
> with the hope that they'll divine its true purpose?