| Message ID | 20221024115429.1343257-1-heiko.thiery@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc | expand |
Hi Heiko, On Mon, Oct 24, 2022 at 8:54 AM Heiko Thiery <heiko.thiery@gmail.com> wrote: > > With that delay U-Boot is not able to store the environment variables in > the SD card. Since the delay is not required it can be remove. > > Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board) > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > v3: > - Improve commit message and explain why it is a fix (thanks to Fabio) Reviewed-by: Fabio Estevam <festevam@gmail.com>
Hi Heiko, On 22-10-24, Heiko Thiery wrote: > With that delay U-Boot is not able to store the environment variables in > the SD card. Since the delay is not required it can be remove. Now I'm curious, since this doesn't tell us the why, it just tell us about the end result. I'm asking because the NXP EVKs have an issue with the sd-card power line capacity and we need this delay to reach a level which is marked as low within the sd-spec. Regards, Marco > Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board) > > Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> > --- > v3: > - Improve commit message and explain why it is a fix (thanks to Fabio) > > v2: > - add Fixes tag > > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > index a91c136797f6..21442e04a632 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts > @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc { > regulator-min-microvolt = <3300000>; > regulator-max-microvolt = <3300000>; > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; > - off-on-delay-us = <20000>; > enable-active-high; > }; > }; > -- > 2.30.2 > >
Hi Marco, Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch <m.felsch@pengutronix.de>: > > Hi Heiko, > > On 22-10-24, Heiko Thiery wrote: > > With that delay U-Boot is not able to store the environment variables in > > the SD card. Since the delay is not required it can be remove. > > Now I'm curious, since this doesn't tell us the why, it just tell us > about the end result. I'm asking because the NXP EVKs have an issue with > the sd-card power line capacity and we need this delay to reach a level > which is marked as low within the sd-spec. I must admit that I do not know at all why this entry was made. I have now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts I see no delay here.
On 22-10-24, Heiko Thiery wrote: > Hi Marco, > > Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch > <m.felsch@pengutronix.de>: > > > > Hi Heiko, > > > > On 22-10-24, Heiko Thiery wrote: > > > With that delay U-Boot is not able to store the environment variables in > > > the SD card. Since the delay is not required it can be remove. > > > > Now I'm curious, since this doesn't tell us the why, it just tell us > > about the end result. I'm asking because the NXP EVKs have an issue with > > the sd-card power line capacity and we need this delay to reach a level > > which is marked as low within the sd-spec. > > I must admit that I do not know at all why this entry was made. I have > now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts > I see no delay here. Please see <20221024031351.4135651-10-peng.fan@oss.nxp.com>, they will be added. Regards, Marco
Hi Marco, Am Mo., 24. Okt. 2022 um 14:58 Uhr schrieb Marco Felsch <m.felsch@pengutronix.de>: > > On 22-10-24, Heiko Thiery wrote: > > Hi Marco, > > > > Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch > > <m.felsch@pengutronix.de>: > > > > > > Hi Heiko, > > > > > > On 22-10-24, Heiko Thiery wrote: > > > > With that delay U-Boot is not able to store the environment variables in > > > > the SD card. Since the delay is not required it can be remove. > > > > > > Now I'm curious, since this doesn't tell us the why, it just tell us > > > about the end result. I'm asking because the NXP EVKs have an issue with > > > the sd-card power line capacity and we need this delay to reach a level > > > which is marked as low within the sd-spec. > > > > I must admit that I do not know at all why this entry was made. I have > > now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts > > I see no delay here. > > Please see <20221024031351.4135651-10-peng.fan@oss.nxp.com>, they will > be added. I think I have to re-check that and especially why U-Boot is not able with that setting to access the SD card for writing the environment. Thanks! > > Regards, > Marco
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts index a91c136797f6..21442e04a632 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc { regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>; - off-on-delay-us = <20000>; enable-active-high; }; };
With that delay U-Boot is not able to store the environment variables in the SD card. Since the delay is not required it can be remove. Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board) Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com> --- v3: - Improve commit message and explain why it is a fix (thanks to Fabio) v2: - add Fixes tag arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 - 1 file changed, 1 deletion(-)