| Message ID | cover.1666630548.git.leonro@nvidia.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Various cleanups for mlx5 | expand |
On 24 Oct 19:59, Leon Romanovsky wrote: >From: Leon Romanovsky <leonro@nvidia.com> > >Changelog: >v1: >Patch #1: > * Removed extra blank line > * Removed ipsec initialization for uplink This will break functionality, ipsec should only be enabled on nic and uplink but not on other vport representors. Leon let's finish review internally, this series has to go through my trees anyways.
On Tue, Oct 25, 2022 at 12:00:11PM +0100, Saeed Mahameed wrote: > On 24 Oct 19:59, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@nvidia.com> > > > > Changelog: > > v1: > > Patch #1: > > * Removed extra blank line > > * Removed ipsec initialization for uplink > > This will break functionality, ipsec should only be enabled on nic and > uplink but not on other vport representors. I didn't hear any complain from verification. The devlink patch is in my tree for months already. > > Leon let's finish review internally, this series has to go through my trees > anyways. What about other 5 patches? Let's progress with them, please. Thanks > >
On 25 Oct 14:25, Leon Romanovsky wrote: >On Tue, Oct 25, 2022 at 12:00:11PM +0100, Saeed Mahameed wrote: >> On 24 Oct 19:59, Leon Romanovsky wrote: >> > From: Leon Romanovsky <leonro@nvidia.com> >> > >> > Changelog: >> > v1: >> > Patch #1: >> > * Removed extra blank line >> > * Removed ipsec initialization for uplink >> >> This will break functionality, ipsec should only be enabled on nic and >> uplink but not on other vport representors. > >I didn't hear any complain from verification. The devlink patch is in >my tree for months already. > the regression is clear in the code. Ask Raed he added the functionality for uplink. >> >> Leon let's finish review internally, this series has to go through my trees >> anyways. > >What about other 5 patches? Let's progress with them, please. > Sure, I will take other patches into my tree, but please let's do internal reviews next time, no need to clutter ML with mlx5 specific stuff.
On Wed, Oct 26, 2022 at 03:27:31PM +0100, Saeed Mahameed wrote: > On 25 Oct 14:25, Leon Romanovsky wrote: > > On Tue, Oct 25, 2022 at 12:00:11PM +0100, Saeed Mahameed wrote: > > > On 24 Oct 19:59, Leon Romanovsky wrote: > > > > From: Leon Romanovsky <leonro@nvidia.com> > > > > > > > > Changelog: > > > > v1: > > > > Patch #1: > > > > * Removed extra blank line > > > > * Removed ipsec initialization for uplink > > > > > > This will break functionality, ipsec should only be enabled on nic and > > > uplink but not on other vport representors. > > > > I didn't hear any complain from verification. The devlink patch is in > > my tree for months already. > > > > the regression is clear in the code. Ask Raed he added the functionality > for uplink. Just to wrap this discussion. Last half a year or so, all IPsec bugs found internally are assigned on me. Thanks
From: Leon Romanovsky <leonro@nvidia.com> Changelog: v1: Patch #1: * Removed extra blank line * Removed ipsec initialization for uplink v0: https://lore.kernel.org/all/cover.1666545480.git.leonro@nvidia.com ----------------------------------------------------------------------- Hi, This is a batch of various cleanups which I collected during development of mlx5 IPsec full offload support. Thanks. Leon Romanovsky (6): net/mlx5e: Support devlink reload of IPsec core net/mlx5: Return ready to use ASO WQE net/mlx5e: Don't access directly DMA device pointer net/mlx5e: Delete always true DMA check net/mlx5: Remove redundant check net/mlx5e: Use read lock for eswitch get callbacks .../ethernet/mellanox/mlx5/core/en/tc/meter.c | 1 - .../mellanox/mlx5/core/en_accel/ipsec.c | 17 ++++++++--------- .../mellanox/mlx5/core/en_accel/ipsec.h | 5 ++--- .../mellanox/mlx5/core/en_accel/macsec.c | 11 +++++------ .../net/ethernet/mellanox/mlx5/core/en_main.c | 7 ++----- .../net/ethernet/mellanox/mlx5/core/en_rep.c | 9 +++------ .../mellanox/mlx5/core/eswitch_offloads.c | 12 ++++++------ .../net/ethernet/mellanox/mlx5/core/lib/aso.c | 10 +++++----- .../net/ethernet/mellanox/mlx5/core/lib/aso.h | 2 +- 9 files changed, 32 insertions(+), 42 deletions(-)