diff mbox series

[RESEND,v2,1/2] dt-bindings: mfd: ti,j721e-system-controller: add compatible strings for other platforms

Message ID 20221024035405.366208-2-mranostay@ti.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: add new compatibles for J7 platforms | expand

Commit Message

Matt Ranostay Oct. 24, 2022, 3:54 a.m. UTC
There are multiple J7 based platforms, and the j721e-system-controller
shouldn't be define in non-j721e devices device trees.

This is mainly for clarity; but also useful in case there are future
erratas that need to be fixed for a specific platform.

Signed-off-by: Matt Ranostay <mranostay@ti.com>
---
 .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring (Arm) Oct. 25, 2022, 10:55 p.m. UTC | #1
On Sun, 23 Oct 2022 20:54:04 -0700, Matt Ranostay wrote:
> There are multiple J7 based platforms, and the j721e-system-controller
> shouldn't be define in non-j721e devices device trees.
> 
> This is mainly for clarity; but also useful in case there are future
> erratas that need to be fixed for a specific platform.
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
>  1 file changed, 2 insertions(+)
> 

Acked-by: Rob Herring <robh@kernel.org>
Krzysztof Kozlowski Oct. 26, 2022, 2:48 p.m. UTC | #2
On 23/10/2022 23:54, Matt Ranostay wrote:
> There are multiple J7 based platforms, and the j721e-system-controller
> shouldn't be define in non-j721e devices device trees.
> 
> This is mainly for clarity; but also useful in case there are future
> erratas that need to be fixed for a specific platform.
> 

This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions. However, there's no need to repost patches *only* to add the
tags. The upstream maintainer will do that for acks received on the
version they apply.

https://elixir.bootlin.com/linux/v5.17/source/Documentation/process/submitting-patches.rst#L540

If a tag was not added on purpose, please state why and what changed.

Best regards,
Krzysztof
Lee Jones Oct. 31, 2022, 3:29 p.m. UTC | #3
On Sun, 23 Oct 2022, Matt Ranostay wrote:

> There are multiple J7 based platforms, and the j721e-system-controller
> shouldn't be define in non-j721e devices device trees.
> 
> This is mainly for clarity; but also useful in case there are future
> erratas that need to be fixed for a specific platform.
> 
> Signed-off-by: Matt Ranostay <mranostay@ti.com>
> ---
>  .../devicetree/bindings/mfd/ti,j721e-system-controller.yaml     | 2 ++
>  1 file changed, 2 insertions(+)

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
index 873ee0c0973f..76ef4352e13c 100644
--- a/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
+++ b/Documentation/devicetree/bindings/mfd/ti,j721e-system-controller.yaml
@@ -26,7 +26,9 @@  properties:
   compatible:
     items:
       - enum:
+          - ti,j7200-system-controller
           - ti,j721e-system-controller
+          - ti,j721s2-system-controller
       - const: syscon
       - const: simple-mfd