| Message ID | 20221025091903.986819-1-karolina.drobnik@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | i915/i915_gem_context: Remove debug message in i915_gem_context_create_ioctl | expand |
> We know that as long as GEM context create ioctl succeeds, a context was > created. There is no need to write about it, especially when such a message > heavily pollutes dmesg and makes debugging actual errors harder. > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Karolina Drobnik <karolina.drobnik@intel.com> > Cc: Andi Shyti <andi.shyti@linux.intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Thanks, Karolina! Andi > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > index 1e29b1e6d186..1456ca87c04e 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > @@ -2298,7 +2298,6 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, void *data, > } > > args->ctx_id = id; > - drm_dbg(&i915->drm, "HW context %d created\n", args->ctx_id); > > return 0; > > -- > 2.25.1
Hi Karolina, On Tue, Oct 25, 2022 at 11:19:03AM +0200, Karolina Drobnik wrote: > We know that as long as GEM context create ioctl succeeds, a context was > created. There is no need to write about it, especially when such a message > heavily pollutes dmesg and makes debugging actual errors harder. > > Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> > Signed-off-by: Karolina Drobnik <karolina.drobnik@intel.com> > Cc: Andi Shyti <andi.shyti@linux.intel.com> pushed to drm-intel-gt-next. Thank you! Andi > --- > drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c > index 1e29b1e6d186..1456ca87c04e 100644 > --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c > +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c > @@ -2298,7 +2298,6 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, void *data, > } > > args->ctx_id = id; > - drm_dbg(&i915->drm, "HW context %d created\n", args->ctx_id); > > return 0; > > -- > 2.25.1
diff --git a/drivers/gpu/drm/i915/gem/i915_gem_context.c b/drivers/gpu/drm/i915/gem/i915_gem_context.c index 1e29b1e6d186..1456ca87c04e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_context.c @@ -2298,7 +2298,6 @@ int i915_gem_context_create_ioctl(struct drm_device *dev, void *data, } args->ctx_id = id; - drm_dbg(&i915->drm, "HW context %d created\n", args->ctx_id); return 0;
We know that as long as GEM context create ioctl succeeds, a context was created. There is no need to write about it, especially when such a message heavily pollutes dmesg and makes debugging actual errors harder. Suggested-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Karolina Drobnik <karolina.drobnik@intel.com> Cc: Andi Shyti <andi.shyti@linux.intel.com> --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 1 - 1 file changed, 1 deletion(-)