| Message ID | 20221026101134.20865-6-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/i915/sdvo: Fix LVDS fixed mode setup and clean up output setup | expand |
On Wed, 26 Oct 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Stop enumerating the DDC modes for SDVO LVDS outputs (outside > the initial fixed mode setup). intel_panel_mode_valid() will > just reject most of them anyway, and any left over are entirely > pointless as they'll match the fixed mode hdisp+vdisp+vrefresh > so no user visible effect from using them instead of the fixed > mode. > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/gpu/drm/i915/display/intel_sdvo.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c > index d432f70001b7..d7943f9a96e7 100644 > --- a/drivers/gpu/drm/i915/display/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c > @@ -2290,17 +2290,12 @@ static int intel_sdvo_get_tv_modes(struct drm_connector *connector) > > static int intel_sdvo_get_lvds_modes(struct drm_connector *connector) > { > - struct intel_sdvo *intel_sdvo = intel_attached_sdvo(to_intel_connector(connector)); > struct drm_i915_private *dev_priv = to_i915(connector->dev); > - int num_modes = 0; > > drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s]\n", > connector->base.id, connector->name); > > - num_modes += intel_panel_get_modes(to_intel_connector(connector)); > - num_modes += intel_ddc_get_modes(connector, &intel_sdvo->ddc); > - > - return num_modes; > + return intel_panel_get_modes(to_intel_connector(connector)); > } > > static int intel_sdvo_get_modes(struct drm_connector *connector)
diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c index d432f70001b7..d7943f9a96e7 100644 --- a/drivers/gpu/drm/i915/display/intel_sdvo.c +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c @@ -2290,17 +2290,12 @@ static int intel_sdvo_get_tv_modes(struct drm_connector *connector) static int intel_sdvo_get_lvds_modes(struct drm_connector *connector) { - struct intel_sdvo *intel_sdvo = intel_attached_sdvo(to_intel_connector(connector)); struct drm_i915_private *dev_priv = to_i915(connector->dev); - int num_modes = 0; drm_dbg_kms(&dev_priv->drm, "[CONNECTOR:%d:%s]\n", connector->base.id, connector->name); - num_modes += intel_panel_get_modes(to_intel_connector(connector)); - num_modes += intel_ddc_get_modes(connector, &intel_sdvo->ddc); - - return num_modes; + return intel_panel_get_modes(to_intel_connector(connector)); } static int intel_sdvo_get_modes(struct drm_connector *connector)