mbox series

[net,0/3] ip: rework the fix for dflt addr selection for connected nexthop"

Message ID 20221020100952.8748-1-nicolas.dichtel@6wind.com (mailing list archive)
Headers show
Series ip: rework the fix for dflt addr selection for connected nexthop" | expand

Message

Nicolas Dichtel Oct. 20, 2022, 10:09 a.m. UTC
This series reworks the fix that is reverted in the second commit.
As Julian explained, nhc_scope is related to nhc_gw, it's not the scope of
the route.

 net/ipv4/fib_frontend.c  | 4 ++--
 net/ipv4/fib_semantics.c | 2 +-
 net/ipv4/nexthop.c       | 2 +-
 3 files changed, 4 insertions(+), 4 deletions(-)

Comments are welcome.

Regards,
Nicolas

Comments

Julian Anastasov Oct. 20, 2022, 10:59 a.m. UTC | #1
Hello,

On Thu, 20 Oct 2022, Nicolas Dichtel wrote:

> This series reworks the fix that is reverted in the second commit.
> As Julian explained, nhc_scope is related to nhc_gw, it's not the scope of
> the route.
> 
>  net/ipv4/fib_frontend.c  | 4 ++--
>  net/ipv4/fib_semantics.c | 2 +-
>  net/ipv4/nexthop.c       | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> Comments are welcome.

	Patchset looks good to me, thanks!

Reviewed-by: Julian Anastasov <ja@ssi.bg>

Regards

--
Julian Anastasov <ja@ssi.bg>
patchwork-bot+netdevbpf@kernel.org Oct. 27, 2022, 5:40 p.m. UTC | #2
Hello:

This series was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Thu, 20 Oct 2022 12:09:49 +0200 you wrote:
> This series reworks the fix that is reverted in the second commit.
> As Julian explained, nhc_scope is related to nhc_gw, it's not the scope of
> the route.
> 
>  net/ipv4/fib_frontend.c  | 4 ++--
>  net/ipv4/fib_semantics.c | 2 +-
>  net/ipv4/nexthop.c       | 2 +-
>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> [...]

Here is the summary with links:
  - [net,1/3] Revert "ip: fix triggering of 'icmp redirect'"
    https://git.kernel.org/netdev/net/c/745b913a5994
  - [net,2/3] Revert "ip: fix dflt addr selection for connected nexthop"
    https://git.kernel.org/netdev/net/c/e021c329ee19
  - [net,3/3] nh: fix scope used to find saddr when adding non gw nh
    https://git.kernel.org/netdev/net/c/bac0f937c343

You are awesome, thank you!