| Message ID | 20221028165215.43662-2-fnkl.kernel@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | PWM and keyboard backlight driver for ARM Macs | expand |
On 28/10/2022 12:52, Sasha Finkelstein wrote: > Apple SoCs such as the M1 contain a PWM controller used > among other things to control the keyboard backlight. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-apple.yaml b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > new file mode 100644 > index 000000000000..39dc32e00a3f > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml Filename matching compatible, so apple,s5l-fpwm.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple FPWM controller > + > +maintainers: > + - asahi@lists.linux.dev > + - Sasha Finkelstein <fnkl.kernel@gmail.com> > + > +description: |+ Drop |+ > + PWM controller used for keyboard backlight on ARM Macs > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-fpwm > + - apple,t6000-fpwm > + - apple,t8112-fpwm > + - const: apple,s5l-fpwm Is it then derived from Samsung platform? If yes, it is candidate for merging. > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm: fpwm@235044000 { Generic node name, so just "pwm". Drop also label - it's not used in the example. Best regards, Krzysztof
On Fri, 28 Oct 2022 at 20:53, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 28/10/2022 12:52, Sasha Finkelstein wrote: > > + PWM controller used for keyboard backlight on ARM Macs > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - apple,t8103-fpwm > > + - apple,t6000-fpwm > > + - apple,t8112-fpwm > > + - const: apple,s5l-fpwm > > Is it then derived from Samsung platform? If yes, it is candidate for > merging. Apple calls it the 'AppleS5L8920XFPWM' which suggests some samsung lineage, but the register interface is different from the one in pwm-samsung driver.
On Fri, 28 Oct 2022 19:52:13 +0300, Sasha Finkelstein wrote: > Apple SoCs such as the M1 contain a PWM controller used > among other things to control the keyboard backlight. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible:0: 'apple,s5l-fpwm' is not one of ['apple,t8103-fpwm', 'apple,t6000-fpwm', 'apple,t8112-fpwm'] From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: compatible: ['apple,s5l-fpwm'] is too short From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.example.dtb: fpwm@235044000: reg: [[2, 889470976], [0, 16384]] is too long From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/pwm/pwm-apple.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On 28/10/2022 12:52, Sasha Finkelstein wrote: > Apple SoCs such as the M1 contain a PWM controller used > among other things to control the keyboard backlight. > > Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> > --- > .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/pwm-apple.yaml b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > new file mode 100644 > index 000000000000..39dc32e00a3f > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Apple FPWM controller > + > +maintainers: > + - asahi@lists.linux.dev > + - Sasha Finkelstein <fnkl.kernel@gmail.com> > + > +description: |+ > + PWM controller used for keyboard backlight on ARM Macs > + > +properties: > + compatible: > + items: > + - enum: > + - apple,t8103-fpwm > + - apple,t6000-fpwm > + - apple,t8112-fpwm > + - const: apple,s5l-fpwm Missing blank line. > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + power-domains: > + maxItems: 1 > + > + "#pwm-cells": > + const: 2 > + > +required: > + - compatible > + - reg > + - clocks > + > +additionalProperties: false > + > +examples: > + - | > + pwm: fpwm@235044000 { > + compatible = "apple,s5l-fpwm"; As Rob's bot pointed out, this does not match the bindings so you did not test them before sending :( Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/pwm/pwm-apple.yaml b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml new file mode 100644 index 000000000000..39dc32e00a3f --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/pwm-apple.yaml @@ -0,0 +1,51 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/pwm-apple.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Apple FPWM controller + +maintainers: + - asahi@lists.linux.dev + - Sasha Finkelstein <fnkl.kernel@gmail.com> + +description: |+ + PWM controller used for keyboard backlight on ARM Macs + +properties: + compatible: + items: + - enum: + - apple,t8103-fpwm + - apple,t6000-fpwm + - apple,t8112-fpwm + - const: apple,s5l-fpwm + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + power-domains: + maxItems: 1 + + "#pwm-cells": + const: 2 + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + pwm: fpwm@235044000 { + compatible = "apple,s5l-fpwm"; + reg = <0x2 0x35044000 0x0 0x4000>; + power-domains = <&ps_fpwm1>; + clocks = <&clkref>; + #pwm-cells = <2>; + };
Apple SoCs such as the M1 contain a PWM controller used among other things to control the keyboard backlight. Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com> --- .../devicetree/bindings/pwm/pwm-apple.yaml | 51 +++++++++++++++++++ 1 file changed, 51 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-apple.yaml