| Message ID | 685b32aea1db3864560f7c72f280bd44ac7b3450.1666793468.git.sd@queasysnail.net (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | macsec: offload-related fixes | expand |
On Wed, Oct 26, 2022 at 11:56:27PM +0200, Sabrina Dubroca wrote: > macsec_add_rxsa and macsec_add_txsa copy the key to an on-stack > offloading context to pass it to the drivers, but leaves it there when > it's done. Clear it with memzero_explicit as soon as it's not needed > anymore. > > Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure") > Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> > --- > drivers/net/macsec.c | 2 ++ > 1 file changed, 2 insertions(+) > Thanks, Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c index 5a2c1bd65d89..7710d549012f 100644 --- a/drivers/net/macsec.c +++ b/drivers/net/macsec.c @@ -1839,6 +1839,7 @@ static int macsec_add_rxsa(struct sk_buff *skb, struct genl_info *info) secy->key_len); err = macsec_offload(ops->mdo_add_rxsa, &ctx); + memzero_explicit(ctx.sa.key, secy->key_len); if (err) goto cleanup; } @@ -2082,6 +2083,7 @@ static int macsec_add_txsa(struct sk_buff *skb, struct genl_info *info) secy->key_len); err = macsec_offload(ops->mdo_add_txsa, &ctx); + memzero_explicit(ctx.sa.key, secy->key_len); if (err) goto cleanup; }
macsec_add_rxsa and macsec_add_txsa copy the key to an on-stack offloading context to pass it to the drivers, but leaves it there when it's done. Clear it with memzero_explicit as soon as it's not needed anymore. Fixes: 3cf3227a21d1 ("net: macsec: hardware offloading infrastructure") Signed-off-by: Sabrina Dubroca <sd@queasysnail.net> --- drivers/net/macsec.c | 2 ++ 1 file changed, 2 insertions(+)