mbox series

[net,v2,0/2] fix WARNING when removing file in ipvs

Message ID 20221031120705.230059-1-shaozhengchao@huawei.com (mailing list archive)
Headers show
Series fix WARNING when removing file in ipvs | expand

Message

shaozhengchao Oct. 31, 2022, 12:07 p.m. UTC 
When using strace for fault injection, some warnings are trigged when
files are removed. This is because the file fails to be created during
the initialization, but the initialization continues normally. Therefore,
a WARNING is reported when the file is removed during the exit.

---
v2: add macro isolation
---
Zhengchao Shao (2):
  ipvs: fix WARNING in __ip_vs_cleanup_batch()
  ipvs: fix WARNING in ip_vs_app_net_cleanup()

 net/netfilter/ipvs/ip_vs_app.c  | 10 ++++++++--
 net/netfilter/ipvs/ip_vs_conn.c | 26 +++++++++++++++++++++-----
 2 files changed, 29 insertions(+), 7 deletions(-)

Comments

Julian Anastasov Oct. 31, 2022, 3:05 p.m. UTC | #1 
Hello,

On Mon, 31 Oct 2022, Zhengchao Shao wrote:

> When using strace for fault injection, some warnings are trigged when
> files are removed. This is because the file fails to be created during
> the initialization, but the initialization continues normally. Therefore,
> a WARNING is reported when the file is removed during the exit.
> 
> ---
> v2: add macro isolation
> ---
> Zhengchao Shao (2):
>   ipvs: fix WARNING in __ip_vs_cleanup_batch()
>   ipvs: fix WARNING in ip_vs_app_net_cleanup()

	Both patches in v2 look good to me, thanks!

Acked-by: Julian Anastasov <ja@ssi.bg>

>  net/netfilter/ipvs/ip_vs_app.c  | 10 ++++++++--
>  net/netfilter/ipvs/ip_vs_conn.c | 26 +++++++++++++++++++++-----
>  2 files changed, 29 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.1

Regards

--
Julian Anastasov <ja@ssi.bg>