mbox series

[RFC,0/2] mmc: tmio: further cleanups after kmap_atomic removal

Message ID 20221102125430.28466-1-wsa+renesas@sang-engineering.com (mailing list archive)
Headers show
Series mmc: tmio: further cleanups after kmap_atomic removal | expand

Message

Wolfram Sang Nov. 2, 2022, 12:54 p.m. UTC
Thanks to Adrian's patches mentioned in patch 1 in this series, we can
now simplify the TMIO driver a tad further to ease future refactoring.
This is marked as RFC because testing the corner cases is not so easy so
extra eyes for review are more than welcome.

Thanks and happy hacking!

   Wolfram


Wolfram Sang (2):
  mmc: tmio: remove tmio_mmc_k(un)map_atomic helpers
  mmc: tmio: remove 'alignment_shift' from platform data

 drivers/mmc/host/renesas_sdhi_core.c     |  1 -
 drivers/mmc/host/renesas_sdhi_sys_dmac.c | 10 +++++-----
 drivers/mmc/host/tmio_mmc.h              | 11 -----------
 drivers/mmc/host/tmio_mmc_core.c         | 13 +++++++------
 include/linux/mfd/tmio.h                 |  1 -
 5 files changed, 12 insertions(+), 24 deletions(-)

Comments

Arnd Bergmann Nov. 2, 2022, 5:59 p.m. UTC | #1
On Wed, Nov 2, 2022, at 13:54, Wolfram Sang wrote:
> Thanks to Adrian's patches mentioned in patch 1 in this series, we can
> now simplify the TMIO driver a tad further to ease future refactoring.
> This is marked as RFC because testing the corner cases is not so easy so
> extra eyes for review are more than welcome.
>
> Thanks and happy hacking!
>

Hi Wolfram,

I haven't posted my PXA boardfile patches yet, but after that
series, the separate tmio MFD devices (MFD_TMIO, MFD_ASIC3)
will all be gone, and tmio-mmc will only be used by SuperH,
Arm MACH_RENESAS and MACH_UNIPHIER. I hope this doesn't conflict
too much with your work and instead opens up further cleanups.

       Arnd
Wolfram Sang Nov. 2, 2022, 6:58 p.m. UTC | #2
Hi Arnd,

> I haven't posted my PXA boardfile patches yet, but after that
> series, the separate tmio MFD devices (MFD_TMIO, MFD_ASIC3)
> will all be gone, and tmio-mmc will only be used by SuperH,
> Arm MACH_RENESAS and MACH_UNIPHIER. I hope this doesn't conflict
> too much with your work and instead opens up further cleanups.

Definately the latter. You didn't send the patches but you did send the
coverletter for the PXA work. Just skimming from that, I see potential
for more cleanups regarding the TMIO MMC/Renesas SDHI driver. Looking
really forward to it :)

Happy hacking,

   Wolfram
Ulf Hansson Nov. 18, 2022, 9:45 a.m. UTC | #3
On Wed, 2 Nov 2022 at 13:54, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Thanks to Adrian's patches mentioned in patch 1 in this series, we can
> now simplify the TMIO driver a tad further to ease future refactoring.
> This is marked as RFC because testing the corner cases is not so easy so
> extra eyes for review are more than welcome.
>
> Thanks and happy hacking!
>
>    Wolfram
>
>
> Wolfram Sang (2):
>   mmc: tmio: remove tmio_mmc_k(un)map_atomic helpers
>   mmc: tmio: remove 'alignment_shift' from platform data
>
>  drivers/mmc/host/renesas_sdhi_core.c     |  1 -
>  drivers/mmc/host/renesas_sdhi_sys_dmac.c | 10 +++++-----
>  drivers/mmc/host/tmio_mmc.h              | 11 -----------
>  drivers/mmc/host/tmio_mmc_core.c         | 13 +++++++------
>  include/linux/mfd/tmio.h                 |  1 -
>  5 files changed, 12 insertions(+), 24 deletions(-)
>

Applied for next, thanks!

Kind regards
Uffe