| Message ID | 20221102191910.120802-1-marex@denx.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | dt-bindings: media: imx7-csi: Document i.MX8M power-domains property | expand |
On 02/11/2022 15:19, Marek Vasut wrote: > The power-domains property is mandatory on i.MX8M Quad and Mini. > Document the property and mark it as required on the aforementioned > variants of the IP, present in those SoCs. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Martin Kepplinger <martin.kepplinger@puri.sm> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: NXP Linux Team <linux-imx@nxp.com> > To: devicetree@vger.kernel.org You keep skipping me in all your submissions. Again, use get_maintainers.pl and/or update your tree to based on something recent. Patches made on 1-year-old kernel are not for upstream... Best regards, Krzysztof
On 11/2/22 22:33, Krzysztof Kozlowski wrote: > On 02/11/2022 15:19, Marek Vasut wrote: >> The power-domains property is mandatory on i.MX8M Quad and Mini. >> Document the property and mark it as required on the aforementioned >> variants of the IP, present in those SoCs. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> --- >> Cc: Fabio Estevam <festevam@gmail.com> >> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Cc: Lucas Stach <l.stach@pengutronix.de> >> Cc: Martin Kepplinger <martin.kepplinger@puri.sm> >> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >> Cc: Rob Herring <robh+dt@kernel.org> >> Cc: Shawn Guo <shawnguo@kernel.org> >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: NXP Linux Team <linux-imx@nxp.com> >> To: devicetree@vger.kernel.org > > You keep skipping me in all your submissions. I seem to be copying the same CC list from somewhere, lemme update it. > Again, use get_maintainers.pl and/or update your tree to based on > something recent. Patches made on 1-year-old kernel are not for upstream... I am on next-20221102 .
Am Mittwoch, 2. November 2022, 20:19:10 CET schrieb Marek Vasut: > The power-domains property is mandatory on i.MX8M Quad and Mini. > Document the property and mark it as required on the aforementioned > variants of the IP, present in those SoCs. > > Signed-off-by: Marek Vasut <marex@denx.de> > --- > Cc: Fabio Estevam <festevam@gmail.com> > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Martin Kepplinger <martin.kepplinger@puri.sm> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: linux-arm-kernel@lists.infradead.org > Cc: NXP Linux Team <linux-imx@nxp.com> > To: devicetree@vger.kernel.org > --- > .../devicetree/bindings/media/nxp,imx7-csi.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml index > 4f7b782653361..358019e85d907 100644 > --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml > @@ -37,6 +37,9 @@ properties: > items: > - const: mclk > > + power-domains: > + maxItems: 1 > + > port: > $ref: /schemas/graph.yaml#/properties/port > > @@ -50,6 +53,18 @@ required: > > additionalProperties: false > > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8mq-csi > + - fsl,imx8mm-csi > + then: > + required: > + - power-domains > + > examples: > - | > #include <dt-bindings/clock/imx7d-clock.h> Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
On Wed, Nov 02, 2022 at 05:33:46PM -0400, Krzysztof Kozlowski wrote: > On 02/11/2022 15:19, Marek Vasut wrote: > > The power-domains property is mandatory on i.MX8M Quad and Mini. > > Document the property and mark it as required on the aforementioned > > variants of the IP, present in those SoCs. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > --- > > Cc: Fabio Estevam <festevam@gmail.com> > > Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > Cc: Lucas Stach <l.stach@pengutronix.de> > > Cc: Martin Kepplinger <martin.kepplinger@puri.sm> > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Shawn Guo <shawnguo@kernel.org> > > Cc: linux-arm-kernel@lists.infradead.org > > Cc: NXP Linux Team <linux-imx@nxp.com> > > To: devicetree@vger.kernel.org > > You keep skipping me in all your submissions. Marek, could you please also CC the linux-media mailing list ? get_maintainers.pl should report it. > Again, use get_maintainers.pl and/or update your tree to based on > something recent. Patches made on 1-year-old kernel are not for upstream... Krzysztof, as Marek mentioned in a separate reply, this patch was based on mainline, and applies cleanly. Are you waiting for a resubmission to review it, or can I merge it ?
On 28/12/2022 00:11, Laurent Pinchart wrote: > On Wed, Nov 02, 2022 at 05:33:46PM -0400, Krzysztof Kozlowski wrote: >> On 02/11/2022 15:19, Marek Vasut wrote: >>> The power-domains property is mandatory on i.MX8M Quad and Mini. >>> Document the property and mark it as required on the aforementioned >>> variants of the IP, present in those SoCs. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> --- >>> Cc: Fabio Estevam <festevam@gmail.com> >>> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>> Cc: Lucas Stach <l.stach@pengutronix.de> >>> Cc: Martin Kepplinger <martin.kepplinger@puri.sm> >>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >>> Cc: Rob Herring <robh+dt@kernel.org> >>> Cc: Shawn Guo <shawnguo@kernel.org> >>> Cc: linux-arm-kernel@lists.infradead.org >>> Cc: NXP Linux Team <linux-imx@nxp.com> >>> To: devicetree@vger.kernel.org >> >> You keep skipping me in all your submissions. > > Marek, could you please also CC the linux-media mailing list ? > get_maintainers.pl should report it. > >> Again, use get_maintainers.pl and/or update your tree to based on >> something recent. Patches made on 1-year-old kernel are not for upstream... > > Krzysztof, as Marek mentioned in a separate reply, this patch was based > on mainline, and applies cleanly. Are you waiting for a resubmission to > review it, or can I merge it ? > Hm, I thought I acked it. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/28/22 10:18, Krzysztof Kozlowski wrote: > On 28/12/2022 00:11, Laurent Pinchart wrote: >> On Wed, Nov 02, 2022 at 05:33:46PM -0400, Krzysztof Kozlowski wrote: >>> On 02/11/2022 15:19, Marek Vasut wrote: >>>> The power-domains property is mandatory on i.MX8M Quad and Mini. >>>> Document the property and mark it as required on the aforementioned >>>> variants of the IP, present in those SoCs. >>>> >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>> --- >>>> Cc: Fabio Estevam <festevam@gmail.com> >>>> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>> Cc: Lucas Stach <l.stach@pengutronix.de> >>>> Cc: Martin Kepplinger <martin.kepplinger@puri.sm> >>>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >>>> Cc: Rob Herring <robh+dt@kernel.org> >>>> Cc: Shawn Guo <shawnguo@kernel.org> >>>> Cc: linux-arm-kernel@lists.infradead.org >>>> Cc: NXP Linux Team <linux-imx@nxp.com> >>>> To: devicetree@vger.kernel.org >>> >>> You keep skipping me in all your submissions. >> >> Marek, could you please also CC the linux-media mailing list ? >> get_maintainers.pl should report it. >> >>> Again, use get_maintainers.pl and/or update your tree to based on >>> something recent. Patches made on 1-year-old kernel are not for upstream... >> >> Krzysztof, as Marek mentioned in a separate reply, this patch was based >> on mainline, and applies cleanly. Are you waiting for a resubmission to >> review it, or can I merge it ? >> > > Hm, I thought I acked it. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Laurent, shall I still resubmit this one more time ?
Hi Marek, On Tue, Jan 03, 2023 at 12:38:54AM +0100, Marek Vasut wrote: > On 12/28/22 10:18, Krzysztof Kozlowski wrote: > > On 28/12/2022 00:11, Laurent Pinchart wrote: > >> On Wed, Nov 02, 2022 at 05:33:46PM -0400, Krzysztof Kozlowski wrote: > >>> On 02/11/2022 15:19, Marek Vasut wrote: > >>>> The power-domains property is mandatory on i.MX8M Quad and Mini. > >>>> Document the property and mark it as required on the aforementioned > >>>> variants of the IP, present in those SoCs. > >>>> > >>>> Signed-off-by: Marek Vasut <marex@denx.de> > >>>> --- > >>>> Cc: Fabio Estevam <festevam@gmail.com> > >>>> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> > >>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > >>>> Cc: Lucas Stach <l.stach@pengutronix.de> > >>>> Cc: Martin Kepplinger <martin.kepplinger@puri.sm> > >>>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > >>>> Cc: Rob Herring <robh+dt@kernel.org> > >>>> Cc: Shawn Guo <shawnguo@kernel.org> > >>>> Cc: linux-arm-kernel@lists.infradead.org > >>>> Cc: NXP Linux Team <linux-imx@nxp.com> > >>>> To: devicetree@vger.kernel.org > >>> > >>> You keep skipping me in all your submissions. > >> > >> Marek, could you please also CC the linux-media mailing list ? > >> get_maintainers.pl should report it. > >> > >>> Again, use get_maintainers.pl and/or update your tree to based on > >>> something recent. Patches made on 1-year-old kernel are not for upstream... > >> > >> Krzysztof, as Marek mentioned in a separate reply, this patch was based > >> on mainline, and applies cleanly. Are you waiting for a resubmission to > >> review it, or can I merge it ? > >> > > > > Hm, I thought I acked it. > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Laurent, shall I still resubmit this one more time ? No, I have the patch in my tree, I'll send a pull request this week.
On 1/3/23 00:42, Laurent Pinchart wrote: > Hi Marek, > > On Tue, Jan 03, 2023 at 12:38:54AM +0100, Marek Vasut wrote: >> On 12/28/22 10:18, Krzysztof Kozlowski wrote: >>> On 28/12/2022 00:11, Laurent Pinchart wrote: >>>> On Wed, Nov 02, 2022 at 05:33:46PM -0400, Krzysztof Kozlowski wrote: >>>>> On 02/11/2022 15:19, Marek Vasut wrote: >>>>>> The power-domains property is mandatory on i.MX8M Quad and Mini. >>>>>> Document the property and mark it as required on the aforementioned >>>>>> variants of the IP, present in those SoCs. >>>>>> >>>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>>> --- >>>>>> Cc: Fabio Estevam <festevam@gmail.com> >>>>>> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> >>>>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >>>>>> Cc: Lucas Stach <l.stach@pengutronix.de> >>>>>> Cc: Martin Kepplinger <martin.kepplinger@puri.sm> >>>>>> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> >>>>>> Cc: Rob Herring <robh+dt@kernel.org> >>>>>> Cc: Shawn Guo <shawnguo@kernel.org> >>>>>> Cc: linux-arm-kernel@lists.infradead.org >>>>>> Cc: NXP Linux Team <linux-imx@nxp.com> >>>>>> To: devicetree@vger.kernel.org >>>>> >>>>> You keep skipping me in all your submissions. >>>> >>>> Marek, could you please also CC the linux-media mailing list ? >>>> get_maintainers.pl should report it. >>>> >>>>> Again, use get_maintainers.pl and/or update your tree to based on >>>>> something recent. Patches made on 1-year-old kernel are not for upstream... >>>> >>>> Krzysztof, as Marek mentioned in a separate reply, this patch was based >>>> on mainline, and applies cleanly. Are you waiting for a resubmission to >>>> review it, or can I merge it ? >>>> >>> >>> Hm, I thought I acked it. >>> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> Laurent, shall I still resubmit this one more time ? > > No, I have the patch in my tree, I'll send a pull request this week. Thanks!
diff --git a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml index 4f7b782653361..358019e85d907 100644 --- a/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml +++ b/Documentation/devicetree/bindings/media/nxp,imx7-csi.yaml @@ -37,6 +37,9 @@ properties: items: - const: mclk + power-domains: + maxItems: 1 + port: $ref: /schemas/graph.yaml#/properties/port @@ -50,6 +53,18 @@ required: additionalProperties: false +allOf: + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8mq-csi + - fsl,imx8mm-csi + then: + required: + - power-domains + examples: - | #include <dt-bindings/clock/imx7d-clock.h>
The power-domains property is mandatory on i.MX8M Quad and Mini. Document the property and mark it as required on the aforementioned variants of the IP, present in those SoCs. Signed-off-by: Marek Vasut <marex@denx.de> --- Cc: Fabio Estevam <festevam@gmail.com> Cc: Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Lucas Stach <l.stach@pengutronix.de> Cc: Martin Kepplinger <martin.kepplinger@puri.sm> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Rob Herring <robh+dt@kernel.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: linux-arm-kernel@lists.infradead.org Cc: NXP Linux Team <linux-imx@nxp.com> To: devicetree@vger.kernel.org --- .../devicetree/bindings/media/nxp,imx7-csi.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)