diff mbox series

[3/4] ARM: dts: at91: rm9200: fix usb device clk id

Message ID 20221103195730.1681967-4-m.grzeschik@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series ARM: at91: USB Device Port fixes | expand

Commit Message

Michael Grzeschik Nov. 3, 2022, 7:57 p.m. UTC
Referring to the datasheet the index 2 is the MCKUDP. When enabled, it;
"Enables the automatic disable of the Master Clock of the USB Device
Port when a suspend condition occurs". We fix the index to the real UDP
id which; "Enables the 48 MHz clock of the USB Device Port".

Cc: nicolas.ferre@microchip.com
Cc: ludovic.desroches@microchip.com
Cc: alexandre.belloni@bootlin.com
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
 arch/arm/boot/dts/at91rm9200.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Claudiu Beznea Nov. 4, 2022, 8:12 a.m. UTC | #1
On 03.11.2022 21:57, Michael Grzeschik wrote:
> Referring to the datasheet the index 2 is the MCKUDP. When enabled, it;

extra ; at the end of line?

> "Enables the automatic disable of the Master Clock of the USB Device
> Port when a suspend condition occurs". We fix the index to the real UDP
> id which; "Enables the 48 MHz clock of the USB Device Port".
> 
> Cc: nicolas.ferre@microchip.com
> Cc: ludovic.desroches@microchip.com
> Cc: alexandre.belloni@bootlin.com
> Cc: linux-arm-kernel@lists.infradead.org
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>

Could you also add the fixes tag?

> ---
>  arch/arm/boot/dts/at91rm9200.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi
> index 7a113325abb9ed..6f9004ebf42456 100644
> --- a/arch/arm/boot/dts/at91rm9200.dtsi
> +++ b/arch/arm/boot/dts/at91rm9200.dtsi
> @@ -666,7 +666,7 @@ usb1: gadget@fffb0000 {
>                                 compatible = "atmel,at91rm9200-udc";
>                                 reg = <0xfffb0000 0x4000>;
>                                 interrupts = <11 IRQ_TYPE_LEVEL_HIGH 2>;
> -                               clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 2>;
> +                               clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 1>;
>                                 clock-names = "pclk", "hclk";
>                                 status = "disabled";
>                         };
> --
> 2.30.2
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/at91rm9200.dtsi b/arch/arm/boot/dts/at91rm9200.dtsi
index 7a113325abb9ed..6f9004ebf42456 100644
--- a/arch/arm/boot/dts/at91rm9200.dtsi
+++ b/arch/arm/boot/dts/at91rm9200.dtsi
@@ -666,7 +666,7 @@  usb1: gadget@fffb0000 {
 				compatible = "atmel,at91rm9200-udc";
 				reg = <0xfffb0000 0x4000>;
 				interrupts = <11 IRQ_TYPE_LEVEL_HIGH 2>;
-				clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 2>;
+				clocks = <&pmc PMC_TYPE_PERIPHERAL 11>, <&pmc PMC_TYPE_SYSTEM 1>;
 				clock-names = "pclk", "hclk";
 				status = "disabled";
 			};