| Message ID | 20221104072701.20283-3-jgross@suse.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0bafc51babe2344e9b0ff6629a4f044727728349 |
| Headers | show |
| Series | x86: Switch X86_FEATURE_XENPV to cpu_feature_enabled() use | expand |
On 11/4/22 00:26, Juergen Gross wrote: > The check for 64-bit mode when testing X86_FEATURE_XENPV isn't needed, > as Xen PV guests are no longer supported in 32-bit mode. Tiniest nit if you revise this: please call out that this "no longer supported" thing is enforced in Kconfig. It's not just some random edict where we pronounced 32-bit PV guests unsupported. Otherwise: Acked-by: Dave Hansen <dave.hansen@linux.intel.com>
diff --git a/arch/x86/include/asm/entry-common.h b/arch/x86/include/asm/entry-common.h index 674ed46d3ced..117903881fe4 100644 --- a/arch/x86/include/asm/entry-common.h +++ b/arch/x86/include/asm/entry-common.h @@ -24,8 +24,8 @@ static __always_inline void arch_enter_from_user_mode(struct pt_regs *regs) /* * For !SMAP hardware we patch out CLAC on entry. */ - if (boot_cpu_has(X86_FEATURE_SMAP) || - (IS_ENABLED(CONFIG_64BIT) && boot_cpu_has(X86_FEATURE_XENPV))) + if (cpu_feature_enabled(X86_FEATURE_SMAP) || + cpu_feature_enabled(X86_FEATURE_XENPV)) mask |= X86_EFLAGS_AC; WARN_ON_ONCE(flags & mask);
The check for 64-bit mode when testing X86_FEATURE_XENPV isn't needed, as Xen PV guests are no longer supported in 32-bit mode. While at it switch from boot_cpu_has() to cpu_feature_enabled(). Signed-off-by: Juergen Gross <jgross@suse.com> --- arch/x86/include/asm/entry-common.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)