[0/3] Convert git-bisect--helper to OPT_SUBCOMMAND

Message

Đoàn Trần Công Danh Nov. 4, 2022, 11:40 a.m. UTC

This series aims to fix the problem that bisect--helper incorrectly consumes
"--log" when running:

	git bisect run cmd --log

This also clears a way for turning git-bisect into a built-in in a later day.

Đoàn Trần Công Danh (3):
  bisect--helper: remove unused options
  bisect--helper: move all subcommands into their own functions
  bisect--helper: parse subcommand with OPT_SUBCOMMAND

 builtin/bisect--helper.c    | 228 ++++++++++++++++++++----------------
 git-bisect.sh               |  20 ++--
 t/t6030-bisect-porcelain.sh |  10 ++
 3 files changed, 148 insertions(+), 110 deletions(-)

Comments

Ævar Arnfjörð Bjarmason Nov. 4, 2022, 1:55 p.m. UTC | #1

On Fri, Nov 04 2022, Đoàn Trần Công Danh wrote:

> This series aims to fix the problem that bisect--helper incorrectly consumes
> "--log" when running:
>
> 	git bisect run cmd --log

I looked this over, and even though I'm obviously biased towards my own
shiny toy I really like where the progression & end state here is going.

> This also clears a way for turning git-bisect into a built-in in a later day.

Yes, but it would be much appreciated if you could take mine and/or
Johannes's conversion series, locally rebase it on what you have, and
check that any assumptions you've made here check out once we get to
that end goal.