| Message ID | 20221104174215.242539-1-colin.i.king@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ethernet: alteon: remove unused variable len | expand |
On Fri, Nov 04, 2022 at 05:42:15PM +0000, Colin Ian King wrote: > Variable len is being used to accumulate the skb_frag_size but it > is never used afterwards. The variable is redundant and can be > removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> > --- > drivers/net/ethernet/alteon/acenic.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) net patches should have target in their title "[PATCH net-next] ...". It is applicable to all your net patches. Thanks
diff --git a/drivers/net/ethernet/alteon/acenic.c b/drivers/net/ethernet/alteon/acenic.c index d7762da8b2c0..eafef84fe3be 100644 --- a/drivers/net/ethernet/alteon/acenic.c +++ b/drivers/net/ethernet/alteon/acenic.c @@ -2435,7 +2435,7 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb, } else { dma_addr_t mapping; u32 vlan_tag = 0; - int i, len = 0; + int i; mapping = ace_map_tx_skb(ap, skb, NULL, idx); flagsize = (skb_headlen(skb) << 16); @@ -2454,7 +2454,6 @@ static netdev_tx_t ace_start_xmit(struct sk_buff *skb, const skb_frag_t *frag = &skb_shinfo(skb)->frags[i]; struct tx_ring_info *info; - len += skb_frag_size(frag); info = ap->skb->tx_skbuff + idx; desc = ap->tx_ring + idx;
Variable len is being used to accumulate the skb_frag_size but it is never used afterwards. The variable is redundant and can be removed. Signed-off-by: Colin Ian King <colin.i.king@gmail.com> --- drivers/net/ethernet/alteon/acenic.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)