| Message ID | 20221107092930.33325-2-robimarko@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: hk10: use "okay" instead of "ok" | expand |
On 07/11/2022 10:29, Robert Marko wrote: > Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of > harcoding the cell value. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> KOnrad > arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > index 262b937e0bc6..651a231554e0 100644 > --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > @@ -5,6 +5,7 @@ > /dts-v1/; > > #include "ipq8074.dtsi" > +#include <dt-bindings/gpio/gpio.h> > > / { > aliases { > @@ -39,12 +40,12 @@ &blsp1_uart5 { > > &pcie0 { > status = "okay"; > - perst-gpios = <&tlmm 58 0x1>; > + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>; > }; > > &pcie1 { > status = "okay"; > - perst-gpios = <&tlmm 61 0x1>; > + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>; > }; > > &pcie_phy0 {
On 07/11/2022 10:29, Robert Marko wrote: > Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of > harcoding the cell value. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > index 262b937e0bc6..651a231554e0 100644 > --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi > @@ -5,6 +5,7 @@ > /dts-v1/; > > #include "ipq8074.dtsi" > +#include <dt-bindings/gpio/gpio.h> > > / { > aliases { > @@ -39,12 +40,12 @@ &blsp1_uart5 { > > &pcie0 { > status = "okay"; > - perst-gpios = <&tlmm 58 0x1>; > + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>; > }; > > &pcie1 { > status = "okay"; > - perst-gpios = <&tlmm 61 0x1>; > + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>; > }; > > &pcie_phy0 {
On 07/11/2022 10:29, Robert Marko wrote: > Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of > harcoding the cell value. > > Signed-off-by: Robert Marko <robimarko@gmail.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi index 262b937e0bc6..651a231554e0 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi @@ -5,6 +5,7 @@ /dts-v1/; #include "ipq8074.dtsi" +#include <dt-bindings/gpio/gpio.h> / { aliases { @@ -39,12 +40,12 @@ &blsp1_uart5 { &pcie0 { status = "okay"; - perst-gpios = <&tlmm 58 0x1>; + perst-gpios = <&tlmm 58 GPIO_ACTIVE_LOW>; }; &pcie1 { status = "okay"; - perst-gpios = <&tlmm 61 0x1>; + perst-gpios = <&tlmm 61 GPIO_ACTIVE_LOW>; }; &pcie_phy0 {
Use respective GPIO_ACTIVE_LOW/HIGH flags for tlmm GPIOs instead of harcoding the cell value. Signed-off-by: Robert Marko <robimarko@gmail.com> --- arch/arm64/boot/dts/qcom/ipq8074-hk10.dtsi | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)