| Message ID | 20221107173954.v11.5.I4c6d97e6f3cf8cdc691d2d4519883c3018dd4372@changeid (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add LTE SKU for sc7280-evoker family | expand |
On 07/11/2022 10:43, Sheng-Liang Pan wrote: > To keep diffs clean, sort out "Status" to last property. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > > Changes in v11: > - sort out the "Status" property with sc7280-herobrine-audio-rt5682.dtsi > > .../dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > index 2dbdeeb29ecec..fc7a659dfe4ae 100644 > --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi > @@ -13,14 +13,14 @@ sound: sound { > compatible = "google,sc7280-herobrine"; > model = "sc7280-rt5682-max98360a-1mic"; > > - status = "okay"; > - audio-routing = > - "Headphone Jack", "HPOL", > - "Headphone Jack", "HPOR"; > + audio-routing = "Headphone Jack", "HPOL", > + "Headphone Jack", "HPOR"; > > #address-cells = <1>; > #size-cells = <0>; > > + status = "okay"; > + > dai-link@0 { > link-name = "MAX98360"; > reg = <0>; > @@ -50,8 +50,8 @@ codec { > }; > > hp_i2c: &i2c2 { > - status = "okay"; > clock-frequency = <400000>; > + status = "okay"; > > alc5682: codec@1a { > compatible = "realtek,rt5682s"; > @@ -75,8 +75,6 @@ alc5682: codec@1a { > }; > > &lpass_cpu { > - status = "okay"; > - > pinctrl-names = "default"; > pinctrl-0 = <&mi2s0_data0>, <&mi2s0_data1>, <&mi2s0_mclk>, <&mi2s0_sclk>, <&mi2s0_ws>, > <&mi2s1_data0>, <&mi2s1_sclk>, <&mi2s1_ws>; > @@ -84,6 +82,8 @@ &lpass_cpu { > #address-cells = <1>; > #size-cells = <0>; > > + status = "okay"; > + > dai-link@0 { > reg = <MI2S_PRIMARY>; > qcom,playback-sd-lines = <1>;
Hi On Mon, Nov 7, 2022 at 1:46 AM Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> wrote: > > To keep diffs clean, sort out "Status" to last property. > > Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> > --- > > Changes in v11: > - sort out the "Status" property with sc7280-herobrine-audio-rt5682.dtsi > > .../dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) Thanks! I probably would have also removed the 'status = "okay";' from the top-level sound node in this patch, but that can always be done later. Certainly your patch is a step forward. :-) Reviewed-by: Douglas Anderson <dianders@chromium.org>
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi index 2dbdeeb29ecec..fc7a659dfe4ae 100644 --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-audio-rt5682.dtsi @@ -13,14 +13,14 @@ sound: sound { compatible = "google,sc7280-herobrine"; model = "sc7280-rt5682-max98360a-1mic"; - status = "okay"; - audio-routing = - "Headphone Jack", "HPOL", - "Headphone Jack", "HPOR"; + audio-routing = "Headphone Jack", "HPOL", + "Headphone Jack", "HPOR"; #address-cells = <1>; #size-cells = <0>; + status = "okay"; + dai-link@0 { link-name = "MAX98360"; reg = <0>; @@ -50,8 +50,8 @@ codec { }; hp_i2c: &i2c2 { - status = "okay"; clock-frequency = <400000>; + status = "okay"; alc5682: codec@1a { compatible = "realtek,rt5682s"; @@ -75,8 +75,6 @@ alc5682: codec@1a { }; &lpass_cpu { - status = "okay"; - pinctrl-names = "default"; pinctrl-0 = <&mi2s0_data0>, <&mi2s0_data1>, <&mi2s0_mclk>, <&mi2s0_sclk>, <&mi2s0_ws>, <&mi2s1_data0>, <&mi2s1_sclk>, <&mi2s1_ws>; @@ -84,6 +82,8 @@ &lpass_cpu { #address-cells = <1>; #size-cells = <0>; + status = "okay"; + dai-link@0 { reg = <MI2S_PRIMARY>; qcom,playback-sd-lines = <1>;
To keep diffs clean, sort out "Status" to last property. Signed-off-by: Sheng-Liang Pan <sheng-liang.pan@quanta.corp-partner.google.com> --- Changes in v11: - sort out the "Status" property with sc7280-herobrine-audio-rt5682.dtsi .../dts/qcom/sc7280-herobrine-audio-rt5682.dtsi | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-)