| Message ID | b266dcf6d647684a10984d12f98549f93fd378ab.1667902754.git.petrm@nvidia.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 9baedc3c8780256bfc68d318c31d0081cefe92a3 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | mlxsw: Add 802.1X and MAB offload support | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/fixes_present | success | Fixes tag not required for -next series |
| netdev/subject_prefix | success | Link |
| netdev/cover_letter | success | Series has a cover letter |
| netdev/patch_count | success | Link |
| netdev/header_inline | success | No static functions without inline keyword in header files |
| netdev/build_32bit | success | Errors and warnings before: 0 this patch: 0 |
| netdev/cc_maintainers | success | CCed 8 of 8 maintainers |
| netdev/build_clang | success | Errors and warnings before: 0 this patch: 0 |
| netdev/module_param | success | Was 0 now: 0 |
| netdev/verify_signedoff | success | Signed-off-by tag matches author and committer |
| netdev/check_selftest | success | No net selftest shell script |
| netdev/verify_fixes | success | No Fixes tag |
| netdev/build_allmodconfig_warn | success | Errors and warnings before: 0 this patch: 0 |
| netdev/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 8 lines checked |
| netdev/kdoc | success | Errors and warnings before: 0 this patch: 0 |
| netdev/source_inline | success | Was 0 now: 0 |
On Tue, Nov 08, 2022 at 11:47:07AM +0100, Petr Machata wrote: > From: Ido Schimmel <idosch@nvidia.com> > > Currently, FDB entries that are notified to the bridge via > 'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded. With MAB > enabled, this will no longer be universally true. Device drivers will > report locked FDB entries to the bridge to let it know that the > corresponding hosts required authorization, but it does not mean that > these entries are necessarily programmed in the underlying hardware. > > Solve this by determining the offload indication based of the > 'offloaded' bit in the FDB notification. > > Signed-off-by: Ido Schimmel <idosch@nvidia.com> > Reviewed-by: Petr Machata <petrm@nvidia.com> > Signed-off-by: Petr Machata <petrm@nvidia.com> > --- Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
On 8 November 2022 06:47:07 GMT-04:00, Petr Machata <petrm@nvidia.com> wrote: >From: Ido Schimmel <idosch@nvidia.com> > >Currently, FDB entries that are notified to the bridge via >'SWITCHDEV_FDB_ADD_TO_BRIDGE' are always marked as offloaded. With MAB >enabled, this will no longer be universally true. Device drivers will >report locked FDB entries to the bridge to let it know that the >corresponding hosts required authorization, but it does not mean that >these entries are necessarily programmed in the underlying hardware. > >Solve this by determining the offload indication based of the >'offloaded' bit in the FDB notification. > >Signed-off-by: Ido Schimmel <idosch@nvidia.com> >Reviewed-by: Petr Machata <petrm@nvidia.com> >Signed-off-by: Petr Machata <petrm@nvidia.com> >--- > net/bridge/br.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Nikolay Aleksandrov <razor@blackwall.org> >diff --git a/net/bridge/br.c b/net/bridge/br.c >index 96e91d69a9a8..145999b8c355 100644 >--- a/net/bridge/br.c >+++ b/net/bridge/br.c >@@ -172,7 +172,7 @@ static int br_switchdev_event(struct notifier_block *unused, > break; > } > br_fdb_offloaded_set(br, p, fdb_info->addr, >- fdb_info->vid, true); >+ fdb_info->vid, fdb_info->offloaded); > break; > case SWITCHDEV_FDB_DEL_TO_BRIDGE: > fdb_info = ptr;
diff --git a/net/bridge/br.c b/net/bridge/br.c index 96e91d69a9a8..145999b8c355 100644 --- a/net/bridge/br.c +++ b/net/bridge/br.c @@ -172,7 +172,7 @@ static int br_switchdev_event(struct notifier_block *unused, break; } br_fdb_offloaded_set(br, p, fdb_info->addr, - fdb_info->vid, true); + fdb_info->vid, fdb_info->offloaded); break; case SWITCHDEV_FDB_DEL_TO_BRIDGE: fdb_info = ptr;