| Message ID | cover.1667687249.git.lorenzo@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | introduce WED RX support to MT7986 SoC | expand |
> Similar to TX counterpart available on MT7622 and MT7986, introduce > RX Wireless Ethernet Dispatch available on MT7986 SoC in order to > offload traffic received by wlan nic to the wired interfaces (lan/wan). Hi all, I noticed today the series state is 'Awaiting Upstream'. I am wondering if this series is expected to go through a different tree, e.g. wireless one (adding Kalle in cc). In this particular case the series changes only the mtk ethernet driver and mt76 is built since we modify a common include (but there are no changes in mt76). My personal opinion is this series is suited to go through net-next tree but I would be fine even if it goes through Kalle's one. Any opinions? Regards, Lorenzo > > Changes since v3: > - remove reset property in ethsys dts node > - rely on readx_poll_timeout in wo mcu code > - fix typos > - move wo-ccif binding in soc folder > - use reserved-memory for wo-dlm > - improve wo-ccif binding > > Changes since v2: > - rely on of_reserved_mem APIs in mcu code > - add some dts fixes > - rename {tx,rx}_wdma in {rx,tx}_wdma > - update entry in maintainers file > > Changes since v1: > - fix sparse warnings > - rely on memory-region property in mt7622-wed.yaml > - some more binding fixes > > Lorenzo Bianconi (7): > arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet > Dispatch > dt-bindings: net: mediatek: add WED RX binding for MT7986 eth driver > net: ethernet: mtk_wed: introduce wed wo support > net: ethernet: mtk_wed: rename tx_wdma array in rx_wdma > net: ethernet: mtk_wed: add configure wed wo support > net: ethernet: mtk_wed: add rx mib counters > MAINTAINERS: update MEDIATEK ETHERNET entry > > Sujuan Chen (1): > net: ethernet: mtk_wed: introduce wed mcu support > > .../arm/mediatek/mediatek,mt7622-wed.yaml | 52 ++ > .../soc/mediatek/mediatek,mt7986-wo-ccif.yaml | 51 ++ > MAINTAINERS | 1 + > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 65 ++ > drivers/net/ethernet/mediatek/Makefile | 2 +- > drivers/net/ethernet/mediatek/mtk_wed.c | 619 ++++++++++++++++-- > drivers/net/ethernet/mediatek/mtk_wed.h | 21 + > .../net/ethernet/mediatek/mtk_wed_debugfs.c | 87 +++ > drivers/net/ethernet/mediatek/mtk_wed_mcu.c | 387 +++++++++++ > drivers/net/ethernet/mediatek/mtk_wed_regs.h | 129 +++- > drivers/net/ethernet/mediatek/mtk_wed_wo.c | 508 ++++++++++++++ > drivers/net/ethernet/mediatek/mtk_wed_wo.h | 282 ++++++++ > include/linux/soc/mediatek/mtk_wed.h | 106 ++- > 13 files changed, 2256 insertions(+), 54 deletions(-) > create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,mt7986-wo-ccif.yaml > create mode 100644 drivers/net/ethernet/mediatek/mtk_wed_mcu.c > create mode 100644 drivers/net/ethernet/mediatek/mtk_wed_wo.c > create mode 100644 drivers/net/ethernet/mediatek/mtk_wed_wo.h > > -- > 2.38.1 >
On Wed, 9 Nov 2022 16:03:40 +0100 Lorenzo Bianconi wrote: > I noticed today the series state is 'Awaiting Upstream'. I am wondering if > this series is expected to go through a different tree, e.g. wireless one > (adding Kalle in cc). In this particular case the series changes only > the mtk ethernet driver and mt76 is built since we modify a common include (but > there are no changes in mt76). My personal opinion is this series is suited to > go through net-next tree but I would be fine even if it goes through Kalle's > one. Any opinions? Works either way, we'll see what Kalle says. Let me bring it back to Under review in the meantime. While I have you - no acks for the bindings yet? On previous versions?
On 09/11/2022 20:05, Jakub Kicinski wrote: > On Wed, 9 Nov 2022 16:03:40 +0100 Lorenzo Bianconi wrote: >> I noticed today the series state is 'Awaiting Upstream'. I am wondering if >> this series is expected to go through a different tree, e.g. wireless one >> (adding Kalle in cc). In this particular case the series changes only >> the mtk ethernet driver and mt76 is built since we modify a common include (but >> there are no changes in mt76). My personal opinion is this series is suited to >> go through net-next tree but I would be fine even if it goes through Kalle's >> one. Any opinions? > > Works either way, we'll see what Kalle says. > Let me bring it back to Under review in the meantime. > > While I have you - no acks for the bindings yet? On previous versions? Please beware that the first patch should go through my tree. Let me know when things got merged and I'll take it. Regards, Matthias
> On Wed, 9 Nov 2022 16:03:40 +0100 Lorenzo Bianconi wrote: > > I noticed today the series state is 'Awaiting Upstream'. I am wondering if > > this series is expected to go through a different tree, e.g. wireless one > > (adding Kalle in cc). In this particular case the series changes only > > the mtk ethernet driver and mt76 is built since we modify a common include (but > > there are no changes in mt76). My personal opinion is this series is suited to > > go through net-next tree but I would be fine even if it goes through Kalle's > > one. Any opinions? > > Works either way, we'll see what Kalle says. > Let me bring it back to Under review in the meantime. ack, thanks :) > > While I have you - no acks for the bindings yet? On previous versions? not yet, I addressed Krzysztof's comments on v3 in v4 so I am waiting for a new review. Regards, Lorenzo
On Nov 09, Matthias Brugger wrote: > > > On 09/11/2022 20:05, Jakub Kicinski wrote: > > On Wed, 9 Nov 2022 16:03:40 +0100 Lorenzo Bianconi wrote: > > > I noticed today the series state is 'Awaiting Upstream'. I am wondering if > > > this series is expected to go through a different tree, e.g. wireless one > > > (adding Kalle in cc). In this particular case the series changes only > > > the mtk ethernet driver and mt76 is built since we modify a common include (but > > > there are no changes in mt76). My personal opinion is this series is suited to > > > go through net-next tree but I would be fine even if it goes through Kalle's > > > one. Any opinions? > > > > Works either way, we'll see what Kalle says. > > Let me bring it back to Under review in the meantime. > > > > While I have you - no acks for the bindings yet? On previous versions? > > Please beware that the first patch should go through my tree. Let me know > when things got merged and I'll take it. ack thx, will do. Regards, Lorenzo > > Regards, > Matthias
Jakub Kicinski <kuba@kernel.org> writes: > On Wed, 9 Nov 2022 16:03:40 +0100 Lorenzo Bianconi wrote: >> I noticed today the series state is 'Awaiting Upstream'. I am wondering if >> this series is expected to go through a different tree, e.g. wireless one >> (adding Kalle in cc). In this particular case the series changes only >> the mtk ethernet driver and mt76 is built since we modify a common include (but >> there are no changes in mt76). My personal opinion is this series is suited to >> go through net-next tree but I would be fine even if it goes through Kalle's >> one. Any opinions? > > Works either way, we'll see what Kalle says. I would prefer if you can take these to net-next.
Hello: This series was applied to netdev/net-next.git (master) by David S. Miller <davem@davemloft.net>: On Sat, 5 Nov 2022 23:36:15 +0100 you wrote: > Similar to TX counterpart available on MT7622 and MT7986, introduce > RX Wireless Ethernet Dispatch available on MT7986 SoC in order to > offload traffic received by wlan nic to the wired interfaces (lan/wan). > > Changes since v3: > - remove reset property in ethsys dts node > - rely on readx_poll_timeout in wo mcu code > - fix typos > - move wo-ccif binding in soc folder > - use reserved-memory for wo-dlm > - improve wo-ccif binding > > [...] Here is the summary with links: - [v4,net-next,1/8] arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet Dispatch https://git.kernel.org/netdev/net-next/c/eed4f1ddad8c - [v4,net-next,2/8] dt-bindings: net: mediatek: add WED RX binding for MT7986 eth driver https://git.kernel.org/netdev/net-next/c/ceb82ac2e745 - [v4,net-next,3/8] net: ethernet: mtk_wed: introduce wed mcu support https://git.kernel.org/netdev/net-next/c/cc514101a97e - [v4,net-next,4/8] net: ethernet: mtk_wed: introduce wed wo support https://git.kernel.org/netdev/net-next/c/799684448e3e - [v4,net-next,5/8] net: ethernet: mtk_wed: rename tx_wdma array in rx_wdma https://git.kernel.org/netdev/net-next/c/084d60ce0c6c - [v4,net-next,6/8] net: ethernet: mtk_wed: add configure wed wo support https://git.kernel.org/netdev/net-next/c/4c5de09eb0d0 - [v4,net-next,7/8] net: ethernet: mtk_wed: add rx mib counters https://git.kernel.org/netdev/net-next/c/51ef685584e2 - [v4,net-next,8/8] MAINTAINERS: update MEDIATEK ETHERNET entry https://git.kernel.org/netdev/net-next/c/90050f80509c You are awesome, thank you!
Hi David, On 11/11/2022 09:20, patchwork-bot+netdevbpf@kernel.org wrote: > Hello: > > This series was applied to netdev/net-next.git (master) > by David S. Miller <davem@davemloft.net>: > > On Sat, 5 Nov 2022 23:36:15 +0100 you wrote: >> Similar to TX counterpart available on MT7622 and MT7986, introduce >> RX Wireless Ethernet Dispatch available on MT7986 SoC in order to >> offload traffic received by wlan nic to the wired interfaces (lan/wan). >> >> Changes since v3: >> - remove reset property in ethsys dts node >> - rely on readx_poll_timeout in wo mcu code >> - fix typos >> - move wo-ccif binding in soc folder >> - use reserved-memory for wo-dlm >> - improve wo-ccif binding >> >> [...] > > Here is the summary with links: > - [v4,net-next,1/8] arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet Dispatch > https://git.kernel.org/netdev/net-next/c/eed4f1ddad8c As I mentioned in the series, DTS changes should go through my tree to avoid merge conflicts. Please let me know if you drop the patch and I'll take it then. Regards, Matthias > - [v4,net-next,2/8] dt-bindings: net: mediatek: add WED RX binding for MT7986 eth driver > https://git.kernel.org/netdev/net-next/c/ceb82ac2e745 > - [v4,net-next,3/8] net: ethernet: mtk_wed: introduce wed mcu support > https://git.kernel.org/netdev/net-next/c/cc514101a97e > - [v4,net-next,4/8] net: ethernet: mtk_wed: introduce wed wo support > https://git.kernel.org/netdev/net-next/c/799684448e3e > - [v4,net-next,5/8] net: ethernet: mtk_wed: rename tx_wdma array in rx_wdma > https://git.kernel.org/netdev/net-next/c/084d60ce0c6c > - [v4,net-next,6/8] net: ethernet: mtk_wed: add configure wed wo support > https://git.kernel.org/netdev/net-next/c/4c5de09eb0d0 > - [v4,net-next,7/8] net: ethernet: mtk_wed: add rx mib counters > https://git.kernel.org/netdev/net-next/c/51ef685584e2 > - [v4,net-next,8/8] MAINTAINERS: update MEDIATEK ETHERNET entry > https://git.kernel.org/netdev/net-next/c/90050f80509c > > You are awesome, thank you!
Similar to TX counterpart available on MT7622 and MT7986, introduce RX Wireless Ethernet Dispatch available on MT7986 SoC in order to offload traffic received by wlan nic to the wired interfaces (lan/wan). Changes since v3: - remove reset property in ethsys dts node - rely on readx_poll_timeout in wo mcu code - fix typos - move wo-ccif binding in soc folder - use reserved-memory for wo-dlm - improve wo-ccif binding Changes since v2: - rely on of_reserved_mem APIs in mcu code - add some dts fixes - rename {tx,rx}_wdma in {rx,tx}_wdma - update entry in maintainers file Changes since v1: - fix sparse warnings - rely on memory-region property in mt7622-wed.yaml - some more binding fixes Lorenzo Bianconi (7): arm64: dts: mediatek: mt7986: add support for RX Wireless Ethernet Dispatch dt-bindings: net: mediatek: add WED RX binding for MT7986 eth driver net: ethernet: mtk_wed: introduce wed wo support net: ethernet: mtk_wed: rename tx_wdma array in rx_wdma net: ethernet: mtk_wed: add configure wed wo support net: ethernet: mtk_wed: add rx mib counters MAINTAINERS: update MEDIATEK ETHERNET entry Sujuan Chen (1): net: ethernet: mtk_wed: introduce wed mcu support .../arm/mediatek/mediatek,mt7622-wed.yaml | 52 ++ .../soc/mediatek/mediatek,mt7986-wo-ccif.yaml | 51 ++ MAINTAINERS | 1 + arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 65 ++ drivers/net/ethernet/mediatek/Makefile | 2 +- drivers/net/ethernet/mediatek/mtk_wed.c | 619 ++++++++++++++++-- drivers/net/ethernet/mediatek/mtk_wed.h | 21 + .../net/ethernet/mediatek/mtk_wed_debugfs.c | 87 +++ drivers/net/ethernet/mediatek/mtk_wed_mcu.c | 387 +++++++++++ drivers/net/ethernet/mediatek/mtk_wed_regs.h | 129 +++- drivers/net/ethernet/mediatek/mtk_wed_wo.c | 508 ++++++++++++++ drivers/net/ethernet/mediatek/mtk_wed_wo.h | 282 ++++++++ include/linux/soc/mediatek/mtk_wed.h | 106 ++- 13 files changed, 2256 insertions(+), 54 deletions(-) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/mediatek,mt7986-wo-ccif.yaml create mode 100644 drivers/net/ethernet/mediatek/mtk_wed_mcu.c create mode 100644 drivers/net/ethernet/mediatek/mtk_wed_wo.c create mode 100644 drivers/net/ethernet/mediatek/mtk_wed_wo.h