mbox series

[0/1,bpf-next] fix panic bringing up veth with xdp progs

Message ID 20221108221650.808950-1-john.fastabend@gmail.com (mailing list archive)
Headers show
Series fix panic bringing up veth with xdp progs | expand

Message

John Fastabend Nov. 8, 2022, 10:16 p.m. UTC 
Not sure if folks want to take this through BPF tree or networking tree.
I took a quick look and didn't see any pending fixes so seems no one
has noticed the panic yet. It reproducible and easy to repro.

I put bpf in the title thinking it woudl be great to run through the
BPF selftests given its XDP triggering the panic.

Sorry maintainers resent with CC'ing actual lists. Had a scripting
issue. Also dropped henqqi has they are bouncing.

Thanks!

John Fastabend (1):
  bpf: veth driver panics when xdp prog attached before veth_open

 drivers/net/veth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Nov. 10, 2022, 2:25 a.m. UTC | #1 
On Tue,  8 Nov 2022 14:16:49 -0800 John Fastabend wrote:
> Not sure if folks want to take this through BPF tree or networking tree.

Whatever's easiest :) FWIW

Acked-by: Jakub Kicinski <kuba@kernel.org>

> I took a quick look and didn't see any pending fixes so seems no one
> has noticed the panic yet. It reproducible and easy to repro.
> 
> I put bpf in the title thinking it woudl be great to run through the
> BPF selftests given its XDP triggering the panic.
> 
> Sorry maintainers resent with CC'ing actual lists. Had a scripting
> issue. Also dropped henqqi has they are bouncing.

Adding Paolo, who had comments on this patch in the past.

The entire concept is worth mainintaining in your opinion, I take it?
patchwork-bot+netdevbpf@kernel.org Nov. 10, 2022, 5:10 a.m. UTC | #2 
Hello:

This patch was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau <martin.lau@kernel.org>:

On Tue,  8 Nov 2022 14:16:49 -0800 you wrote:
> Not sure if folks want to take this through BPF tree or networking tree.
> I took a quick look and didn't see any pending fixes so seems no one
> has noticed the panic yet. It reproducible and easy to repro.
> 
> I put bpf in the title thinking it woudl be great to run through the
> BPF selftests given its XDP triggering the panic.
> 
> [...]

Here is the summary with links:
  - [1/1,bpf-next] bpf: veth driver panics when xdp prog attached before veth_open
    https://git.kernel.org/bpf/bpf-next/c/5e5dc33d5dac

You are awesome, thank you!