diff mbox series

[V4,2/3] dt-bindings: display: panel: Add NewVision NV3051D bindings

Message ID 20221028205009.15105-3-macroalpha82@gmail.com (mailing list archive)
State New, archived
Headers show
Series drm/panel: Add NewVision NV3051D Panels | expand

Commit Message

Chris Morgan Oct. 28, 2022, 8:50 p.m. UTC
From: Chris Morgan <macromorgan@hotmail.com>

Add documentation for the NewVision NV3051D panel bindings.
Note that for the two expected consumers of this panel binding
the underlying LCD model is unknown. Name "anbernic,rg353p-panel"
is used because the hardware itself is known as "anbernic,rg353p".

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 .../display/panel/newvision,nv3051d.yaml      | 63 +++++++++++++++++++
 1 file changed, 63 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml

Comments

Krzysztof Kozlowski Oct. 28, 2022, 11:01 p.m. UTC | #1
On 28/10/2022 16:50, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Add documentation for the NewVision NV3051D panel bindings.
> Note that for the two expected consumers of this panel binding
> the underlying LCD model is unknown. Name "anbernic,rg353p-panel"
> is used because the hardware itself is known as "anbernic,rg353p".
> 
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>

Didn't you got here tag?

Best regards,
Krzysztof
Chris Morgan Oct. 29, 2022, 2:28 a.m. UTC | #2
On Fri, Oct 28, 2022 at 07:01:12PM -0400, Krzysztof Kozlowski wrote:
> On 28/10/2022 16:50, Chris Morgan wrote:
> > From: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Add documentation for the NewVision NV3051D panel bindings.
> > Note that for the two expected consumers of this panel binding
> > the underlying LCD model is unknown. Name "anbernic,rg353p-panel"
> > is used because the hardware itself is known as "anbernic,rg353p".
> > 
> > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> 
> Didn't you got here tag?

Yes, I'm so sorry. I always seem to miss one detail each time, I
promise I'll get better (eventually, I hope). This one should
already have the "Reviewed-by: Rob Herring <robh@kernel.org>" but
I forgot to include it. Literally the only change from v3 is the
return of a function changing from int to void, since that changed
in the 6.1 kernel.

Thank you.

> 
> Best regards,
> Krzysztof
>
Rob Herring Nov. 1, 2022, 1:11 a.m. UTC | #3
On Fri, Oct 28, 2022 at 09:28:59PM -0500, Chris Morgan wrote:
> On Fri, Oct 28, 2022 at 07:01:12PM -0400, Krzysztof Kozlowski wrote:
> > On 28/10/2022 16:50, Chris Morgan wrote:
> > > From: Chris Morgan <macromorgan@hotmail.com>
> > > 
> > > Add documentation for the NewVision NV3051D panel bindings.
> > > Note that for the two expected consumers of this panel binding
> > > the underlying LCD model is unknown. Name "anbernic,rg353p-panel"
> > > is used because the hardware itself is known as "anbernic,rg353p".
> > > 
> > > Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> > 
> > Didn't you got here tag?
> 
> Yes, I'm so sorry. I always seem to miss one detail each time, I
> promise I'll get better (eventually, I hope). This one should
> already have the "Reviewed-by: Rob Herring <robh@kernel.org>" but
> I forgot to include it. Literally the only change from v3 is the
> return of a function changing from int to void, since that changed
> in the 6.1 kernel.

If you forget, just add the tags by themselves and the tools will pick 
them up.

Reviewed-by: Rob Herring <robh@kernel.org>
Linus Walleij Nov. 10, 2022, 8:52 a.m. UTC | #4
Hi Chris,

thanks for your patch! The following is just nitpicks so take it or
leave it.

On Fri, Oct 28, 2022 at 10:50 PM Chris Morgan <macroalpha82@gmail.com> wrote:

> From: Chris Morgan <macromorgan@hotmail.com>
>
> Add documentation for the NewVision NV3051D panel bindings.
> Note that for the two expected consumers of this panel binding
> the underlying LCD model is unknown. Name "anbernic,rg353p-panel"
> is used because the hardware itself is known as "anbernic,rg353p".
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
(...)

> +  reset-gpios: true

I would add description: and say that this needs to be flagged
GPIO_ACTIVE_LOW since the reset signal is active low.

> +  vdd-supply: true
> +
> +required:
> +  - compatible
> +  - reg
> +  - backlight
> +  - vdd-supply

If someone happen to just wire vdd-supply to some fixed regulator
then they don't need vdd-supply so this is a bit of a tough requirement.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
new file mode 100644
index 000000000000..407de7fb5499
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/newvision,nv3051d.yaml
@@ -0,0 +1,63 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/newvision,nv3051d.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NewVision NV3051D based LCD panel
+
+description: |
+  The NewVision NV3051D is a driver chip used to drive DSI panels. For now,
+  this driver only supports the 640x480 panels found in the Anbernic RG353
+  based devices.
+
+maintainers:
+  - Chris Morgan <macromorgan@hotmail.com>
+
+allOf:
+  - $ref: panel-common.yaml#
+
+properties:
+  compatible:
+    items:
+      - enum:
+          - anbernic,rg353p-panel
+          - anbernic,rg353v-panel
+      - const: newvision,nv3051d
+
+  reg: true
+  backlight: true
+  port: true
+  reset-gpios: true
+  vdd-supply: true
+
+required:
+  - compatible
+  - reg
+  - backlight
+  - vdd-supply
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    dsi {
+        #address-cells = <1>;
+        #size-cells = <0>;
+        panel@0 {
+            compatible = "anbernic,rg353p-panel", "newvision,nv3051d";
+            reg = <0>;
+            backlight = <&backlight>;
+            reset-gpios = <&gpio4 0 GPIO_ACTIVE_LOW>;
+            vdd-supply = <&vcc3v3_lcd>;
+
+            port {
+                mipi_in_panel: endpoint {
+                    remote-endpoint = <&mipi_out_panel>;
+                };
+            };
+        };
+    };
+
+...